Some script fixes

- Dragonecro Nethersoul Dragon: The battle protection should apply to your monsters too, if this card battles one of them due to another effect. Fixed an issue where the ATK changing effect would sometimes cause a script error.
- Neutron Blast: Fixed an issue where the "cannot activate" effect would be applied even if the targeted monster leaves the field, returns, and then attacks again in the same turn. Also, should be able to target a monster that can attack multiple times, but not a monster that has already had the effect of "Neutron Blast" applied to it.
- Witchcrafter Collaboration: Should be able to target a monster that can attack multiple times, but not a monster that has already had the effect of "Witchcrafter Collaboration" applied to it.
- Witchcrafter Genni: Shouldn't be able to copy the effect of "Witchcrafter Collaboration" if the player cannot conduct their Battle Phase that turn.

Author: pyrQ

official/c10805153.lua

@@ -1,91 +1,85 @@
 --ウィッチクラフト・コラボレーション
 --Witchcrafter Collaboration
 --Scripted by Naim
-
 local s,id=GetID()
 function s.initial_effect(c)
 	--Activate
 	local e1=Effect.CreateEffect(c)
+	e1:SetDescription(aux.Stringid(id,0))
 	e1:SetType(EFFECT_TYPE_ACTIVATE)
-	e1:SetCode(EVENT_FREE_CHAIN)
 	e1:SetProperty(EFFECT_FLAG_CARD_TARGET)
+	e1:SetCode(EVENT_FREE_CHAIN)
 	e1:SetCountLimit(1,id)
-	e1:SetCondition(s.condition)
 	e1:SetTarget(s.target)
-	e1:SetOperation(s.operation)
+	e1:SetOperation(s.activate)
 	c:RegisterEffect(e1)
-	--Add this card from GY to hand
+	--Add this card to the hand
 	local e2=Effect.CreateEffect(c)
-	e2:SetDescription(aux.Stringid(id,0))
+	e2:SetDescription(aux.Stringid(id,1))
 	e2:SetCategory(CATEGORY_TOHAND+CATEGORY_LEAVE_GRAVE)
 	e2:SetType(EFFECT_TYPE_FIELD+EFFECT_TYPE_TRIGGER_O)
 	e2:SetCode(EVENT_PHASE+PHASE_END)
 	e2:SetRange(LOCATION_GRAVE)
 	e2:SetCountLimit(1,id)
-	e2:SetCondition(s.thcon2)
-	e2:SetTarget(s.thtg2)
-	e2:SetOperation(s.thop2)
+	e2:SetCondition(function(e,tp) return Duel.IsTurnPlayer(tp) and Duel.IsExistingMatchingCard(aux.FaceupFilter(Card.IsSetCard,SET_WITCHCRAFTER),tp,LOCATION_MZONE,0,1,nil) end)
+	e2:SetTarget(s.thtg)
+	e2:SetOperation(s.thop)
 	c:RegisterEffect(e2)
 end
-s.listed_series={0x128}
-
-function s.condition(e,tp,eg,ep,ev,re,r,rp)
-	return Duel.IsAbleToEnterBP()
-end
+s.listed_series={SET_WITCHCRAFTER}
 function s.tgfilter(c)
-	return c:IsFaceup() and c:IsSetCard(0x128) and not c:IsHasEffect(EFFECT_EXTRA_ATTACK)
+	return c:IsSetCard(SET_WITCHCRAFTER) and c:IsFaceup() and not c:HasFlagEffect(id)
 end
 function s.target(e,tp,eg,ep,ev,re,r,rp,chk,chkc)
 	if chkc then return chkc:IsLocation(LOCATION_MZONE) and chkc:IsControler(tp) and s.tgfilter(chkc) end
-	if chk==0 then return Duel.IsExistingTarget(s.tgfilter,tp,LOCATION_MZONE,0,1,nil) end
-	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_FACEUP)
+	if chk==0 then return (Duel.IsAbleToEnterBP() or (Duel.IsBattlePhase() and not Duel.IsPhase(PHASE_BATTLE)))
+		and Duel.IsExistingTarget(s.tgfilter,tp,LOCATION_MZONE,0,1,nil) end
+	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_APPLYTO)
 	Duel.SelectTarget(tp,s.tgfilter,tp,LOCATION_MZONE,0,1,1,nil)
 end
-function s.operation(e,tp,eg,ep,ev,re,r,rp)
+function s.activate(e,tp,eg,ep,ev,re,r,rp)
 	local tc=Duel.GetFirstTarget()
 	if tc:IsRelateToEffect(e) then
-		--Can make a second attack
-		local e1=Effect.CreateEffect(e:GetHandler())
+		local c=e:GetHandler()
+		tc:RegisterFlagEffect(id,RESETS_STANDARD_PHASE_END,0,1)
+		--It can make a second attack during each Battle Phase this turn
+		local e1=Effect.CreateEffect(c)
+		e1:SetDescription(aux.Stringid(id,2))
 		e1:SetType(EFFECT_TYPE_SINGLE)
-		e1:SetProperty(EFFECT_FLAG_CANNOT_DISABLE)
+		e1:SetProperty(EFFECT_FLAG_CANNOT_DISABLE+EFFECT_FLAG_CLIENT_HINT)
 		e1:SetCode(EFFECT_EXTRA_ATTACK)
-		e1:SetReset(RESET_EVENT+RESETS_STANDARD+RESET_PHASE+PHASE_END)
 		e1:SetValue(1)
+		e1:SetReset(RESETS_STANDARD_PHASE_END)
 		tc:RegisterEffect(e1)
-		tc:RegisterFlagEffect(0,RESET_EVENT+RESETS_STANDARD+RESET_PHASE+PHASE_END,EFFECT_FLAG_CLIENT_HINT,1,0,3201)
-		--Opponent cannot activate spells/traps until end of damage step
-		local e2=Effect.CreateEffect(e:GetHandler())
+		--If it attacks this turn your opponent cannot activate Spell/Trap Cards until the end of the Damage Step
+		local e2=Effect.CreateEffect(c)
 		e2:SetType(EFFECT_TYPE_SINGLE+EFFECT_TYPE_CONTINUOUS)
+		e2:SetProperty(EFFECT_FLAG_CANNOT_DISABLE)
 		e2:SetCode(EVENT_ATTACK_ANNOUNCE)
-		e2:SetOperation(s.atkop)
-		e2:SetReset(RESET_EVENT+RESETS_STANDARD+RESET_PHASE+PHASE_END)
+		e2:SetOperation(s.limop)
+		e2:SetReset(RESETS_STANDARD_PHASE_END)
 		tc:RegisterEffect(e2)
 	end
 end
-function s.atkop(e,tp,eg,ep,ev,re,r,rp)
+function s.limop(e,tp,eg,ep,ev,re,r,rp)
+	--Your opponent cannot activate Spell/Trap Cards until the end of the Damage Step
 	local e1=Effect.CreateEffect(e:GetHandler())
 	e1:SetType(EFFECT_TYPE_FIELD)
 	e1:SetProperty(EFFECT_FLAG_PLAYER_TARGET)
 	e1:SetCode(EFFECT_CANNOT_ACTIVATE)
 	e1:SetTargetRange(0,1)
-	e1:SetValue(s.aclimit)
-	e1:SetReset(RESET_PHASE+PHASE_DAMAGE)
+	e1:SetValue(function(e,re,tp) return re:IsHasType(EFFECT_TYPE_ACTIVATE) end)
+	e1:SetReset(RESET_PHASE|PHASE_DAMAGE)
 	Duel.RegisterEffect(e1,tp)
 end
-function s.aclimit(e,re,tp)
-	return re:IsHasType(EFFECT_TYPE_ACTIVATE) and not re:GetHandler():IsImmuneToEffect(e)
-end
-function s.thcon2(e,tp,eg,ep,ev,re,r,rp)
-	return Duel.IsExistingMatchingCard(aux.FaceupFilter(Card.IsSetCard,0x128),tp,LOCATION_MZONE,0,1,nil) and Duel.GetTurnPlayer()==tp
-end
-function s.thtg2(e,tp,eg,ep,ev,re,r,rp,chk)
+function s.thtg(e,tp,eg,ep,ev,re,r,rp,chk)
 	local c=e:GetHandler()
 	if chk==0 then return c:IsAbleToHand() end
-	Duel.SetOperationInfo(0,CATEGORY_TOHAND,c,1,tp,LOCATION_GRAVE)
+	Duel.SetOperationInfo(0,CATEGORY_TOHAND,c,1,tp,0)
 end
-function s.thop2(e,tp,eg,ep,ev,re,r,rp,chk)
+function s.thop(e,tp,eg,ep,ev,re,r,rp,chk)
 	local c=e:GetHandler()
 	if c:IsRelateToEffect(e) then
-		Duel.SendtoHand(c,tp,REASON_EFFECT)
+		Duel.SendtoHand(c,nil,REASON_EFFECT)
 	end
 end

official/c43845801.lua

@@ -4,51 +4,57 @@ local s,id=GetID()
 function s.initial_effect(c)
 	--Activate
 	local e1=Effect.CreateEffect(c)
+	e1:SetDescription(aux.Stringid(id,0))
 	e1:SetType(EFFECT_TYPE_ACTIVATE)
-	e1:SetCode(EVENT_FREE_CHAIN)
 	e1:SetProperty(EFFECT_FLAG_CARD_TARGET)
-	e1:SetCondition(s.condition)
+	e1:SetCode(EVENT_FREE_CHAIN)
 	e1:SetTarget(s.target)
 	e1:SetOperation(s.activate)
 	c:RegisterEffect(e1)
 end
-s.listed_names={23995346}
-function s.condition(e,tp,eg,ep,ev,re,r,rp)
-	return Duel.IsAbleToEnterBP()
-end
-function s.filter(c)
-	return c:IsFaceup() and c:IsSummonType(SUMMON_TYPE_FUSION)
-		and c:IsCode(23995346) and not c:IsHasEffect(EFFECT_EXTRA_ATTACK)
+s.listed_names={23995346} --"Blue-Eyes Ultimate Dragon"
+function s.tgfilter(c)
+	return c:IsCode(23995346) and c:IsSummonType(SUMMON_TYPE_FUSION) and c:IsFaceup() and not c:HasFlagEffect(id)
 end
 function s.target(e,tp,eg,ep,ev,re,r,rp,chk,chkc)
-	if chkc then return chkc:IsLocation(LOCATION_MZONE) and chkc:IsControler(tp) and s.filter(chkc) end
-	if chk==0 then return Duel.IsExistingTarget(s.filter,tp,LOCATION_MZONE,0,1,nil) end
-	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_TARGET)
-	Duel.SelectTarget(tp,s.filter,tp,LOCATION_MZONE,0,1,1,nil)
+	if chkc then return chkc:IsLocation(LOCATION_MZONE) and chkc:IsControler(tp) and s.tgfilter(chkc) end
+	if chk==0 then return (Duel.IsAbleToEnterBP() or (Duel.IsBattlePhase() and not Duel.IsPhase(PHASE_BATTLE)))
+		and Duel.IsExistingTarget(s.tgfilter,tp,LOCATION_MZONE,0,1,nil) end
+	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_APPLYTO)
+	Duel.SelectTarget(tp,s.tgfilter,tp,LOCATION_MZONE,0,1,1,nil)
 end
 function s.activate(e,tp,eg,ep,ev,re,r,rp)
 	local tc=Duel.GetFirstTarget()
 	if tc:IsRelateToEffect(e) then
-		local e1=Effect.CreateEffect(e:GetHandler())
-		e1:SetDescription(aux.Stringid(id,0))
+		local c=e:GetHandler()
+		tc:RegisterFlagEffect(id,RESETS_STANDARD_PHASE_END,0,1)
+		--It can make a second and third attack during each Battle Phase this turn
+		local e1=Effect.CreateEffect(c)
+		e1:SetDescription(aux.Stringid(id,1))
 		e1:SetType(EFFECT_TYPE_SINGLE)
-		e1:SetCode(EFFECT_EXTRA_ATTACK)
 		e1:SetProperty(EFFECT_FLAG_CANNOT_DISABLE+EFFECT_FLAG_CLIENT_HINT)
+		e1:SetCode(EFFECT_EXTRA_ATTACK)
 		e1:SetValue(2)
-		e1:SetReset(RESET_EVENT+RESETS_STANDARD+RESET_PHASE+PHASE_END)
+		e1:SetReset(RESETS_STANDARD_PHASE_END)
 		tc:RegisterEffect(e1)
-		local e2=Effect.CreateEffect(e:GetHandler())
-		e2:SetType(EFFECT_TYPE_FIELD)
-		e2:SetProperty(EFFECT_FLAG_PLAYER_TARGET)
-		e2:SetCode(EFFECT_CANNOT_ACTIVATE)
-		e2:SetTargetRange(0,1)
-		e2:SetLabelObject(tc)
-		e2:SetValue(1)
-		e2:SetCondition(s.actcon)
-		e2:SetReset(RESET_EVENT+RESETS_STANDARD+RESET_PHASE+PHASE_END)
-		Duel.RegisterEffect(e2,tp)
+		--If it attacks this turn your opponent's cards and effects cannot be activated until the end of the Damage Step
+		local e2=Effect.CreateEffect(c)
+		e2:SetType(EFFECT_TYPE_SINGLE+EFFECT_TYPE_CONTINUOUS)
+		e2:SetProperty(EFFECT_FLAG_CANNOT_DISABLE)
+		e2:SetCode(EVENT_ATTACK_ANNOUNCE)
+		e2:SetOperation(s.limop)
+		e2:SetReset(RESETS_STANDARD_PHASE_END)
+		tc:RegisterEffect(e2)
 	end
 end
-function s.actcon(e)
-	return Duel.GetAttacker()==e:GetLabelObject()
-end
+function s.limop(e,tp,eg,ep,ev,re,r,rp)
+	--Your opponent's cards and effects cannot be activated until the end of the Damage Step
+	local e1=Effect.CreateEffect(e:GetHandler())
+	e1:SetType(EFFECT_TYPE_FIELD)
+	e1:SetProperty(EFFECT_FLAG_PLAYER_TARGET)
+	e1:SetCode(EFFECT_CANNOT_ACTIVATE)
+	e1:SetTargetRange(0,1)
+	e1:SetValue(1)
+	e1:SetReset(RESET_PHASE|PHASE_DAMAGE)
+	Duel.RegisterEffect(e1,tp)
+end

official/c64756282.lua

@@ -56,7 +56,7 @@ function s.efftg(e,tp,eg,ep,ev,re,r,rp,chk)
 	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_REMOVE)
 	local sc=Duel.SelectTarget(tp,s.copyfilter,tp,LOCATION_GRAVE,0,1,1,nil):GetFirst()
 	Duel.Remove(Group.FromCards(sc,c),POS_FACEUP,REASON_COST)
-	local te,ceg,cep,cev,cre,cr,crp=sc:CheckActivateEffect(false,true,true)
+	local te,ceg,cep,cev,cre,cr,crp=sc:CheckActivateEffect(true,true,true)
 	Duel.ClearTargetCard()
 	local tg=te:GetTarget()
 	e:SetProperty(te:GetProperty())

official/c8198620.lua

@@ -1,79 +1,72 @@
 --冥界龍 ドラゴネクロ
 --Dragonecro Nethersoul Dragon
 local s,id=GetID()
+local TOKEN_DARK_SOUL=id+1
 function s.initial_effect(c)
-	c:SetUniqueOnField(1,0,id)
-	--fusion material
 	c:EnableReviveLimit()
+	--Fusion Materials: 2 Zombie monsters
 	Fusion.AddProcMixN(c,true,true,aux.FilterBoolFunctionEx(Card.IsRace,RACE_ZOMBIE),2)
-	--spsummon condition
+	c:AddMustFirstBeFusionSummoned()
+	--You can only control 1 "Dragonecro Nethersoul Dragon"
+	c:SetUniqueOnField(1,0,id)
+	--Monsters cannot be destroyed by battle with this card
 	local e1=Effect.CreateEffect(c)
-	e1:SetType(EFFECT_TYPE_SINGLE)
-	e1:SetProperty(EFFECT_FLAG_CANNOT_DISABLE+EFFECT_FLAG_UNCOPYABLE+EFFECT_FLAG_SINGLE_RANGE)
-	e1:SetCode(EFFECT_SPSUMMON_CONDITION)
-	e1:SetRange(LOCATION_EXTRA)
-	e1:SetValue(s.splimit)
+	e1:SetType(EFFECT_TYPE_FIELD)
+	e1:SetCode(EFFECT_INDESTRUCTABLE_BATTLE)
+	e1:SetRange(LOCATION_MZONE)
+	e1:SetTargetRange(LOCATION_MZONE,LOCATION_MZONE)
+	e1:SetTarget(function(e,c) return c==e:GetHandler():GetBattleTarget() end)
+	e1:SetValue(1)
 	c:RegisterEffect(e1)
-	--battle
+	--Change the ATK of a monster this card battles to 0 and Special Summon 1 "Dark Soul Token"
 	local e2=Effect.CreateEffect(c)
 	e2:SetDescription(aux.Stringid(id,0))
 	e2:SetCategory(CATEGORY_ATKCHANGE+CATEGORY_SPECIAL_SUMMON+CATEGORY_TOKEN)
 	e2:SetType(EFFECT_TYPE_SINGLE+EFFECT_TYPE_TRIGGER_F)
 	e2:SetCode(EVENT_DAMAGE_STEP_END)
-	e2:SetTarget(s.attg)
-	e2:SetOperation(s.atop)
+	e2:SetTarget(s.atktg)
+	e2:SetOperation(s.atkop)
 	c:RegisterEffect(e2)
-	--indes
-	local e3=Effect.CreateEffect(c)
-	e3:SetType(EFFECT_TYPE_FIELD)
-	e3:SetCode(EFFECT_INDESTRUCTABLE_BATTLE)
-	e3:SetRange(LOCATION_MZONE)
-	e3:SetTargetRange(0,LOCATION_MZONE)
-	e3:SetTarget(s.indestg)
-	e3:SetValue(1)
-	c:RegisterEffect(e3)
-end
-s.listed_names={8198621}
-function s.splimit(e,se,sp,st)
-	return not e:GetHandler():IsLocation(LOCATION_EXTRA) or st&SUMMON_TYPE_FUSION==SUMMON_TYPE_FUSION
 end
-function s.attg(e,tp,eg,ep,ev,re,r,rp,chk)
+s.listed_names={id,TOKEN_DARK_SOUL}
+function s.atktg(e,tp,eg,ep,ev,re,r,rp,chk)
 	local bc=e:GetHandler():GetBattleTarget()
 	if chk==0 then return bc and bc:IsRelateToBattle() end
-	Duel.SetOperationInfo(0,CATEGORY_TOKEN,nil,1,0,0)
-	Duel.SetOperationInfo(0,CATEGORY_SPECIAL_SUMMON,nil,1,tp,0)
+	Duel.SetTargetCard(bc)
+	if bc:GetOriginalLevel()>0 then
+		Duel.SetOperationInfo(0,CATEGORY_TOKEN,nil,1,tp,0)
+		Duel.SetOperationInfo(0,CATEGORY_SPECIAL_SUMMON,nil,1,tp,0)
+	end
 end
-function s.atop(e,tp,eg,ep,ev,re,r,rp)
-	local c=e:GetHandler()
-	local bc=c:GetBattleTarget()
-	if bc:IsRelateToBattle() and bc:IsFaceup() then
+function s.atkop(e,tp,eg,ep,ev,re,r,rp)
+	local bc=Duel.GetFirstTarget()
+	if bc:IsRelateToEffect(e) and bc:IsFaceup() then
+		local c=e:GetHandler()
 		local atk=bc:GetBaseAttack()
-		--Change ATK to 0
+		--Change that monster's ATK to 0
 		local e1=Effect.CreateEffect(c)
 		e1:SetType(EFFECT_TYPE_SINGLE)
+		e1:SetProperty(EFFECT_FLAG_CANNOT_DISABLE)
 		e1:SetCode(EFFECT_SET_ATTACK_FINAL)
 		e1:SetValue(0)
-		e1:SetReset(RESET_EVENT+RESETS_STANDARD)
+		e1:SetReset(RESET_EVENT|RESETS_STANDARD)
 		bc:RegisterEffect(e1)
 		local lv=bc:GetOriginalLevel()
 		if lv>0 and Duel.GetLocationCount(tp,LOCATION_MZONE)>0
-			and Duel.IsPlayerCanSpecialSummonMonster(tp,id+1,0,TYPES_TOKEN,-2,0,0,RACE_ZOMBIE,ATTRIBUTE_DARK) then
-			local token=Duel.CreateToken(tp,id+1)
-			Duel.SpecialSummonStep(token,0,tp,tp,false,false,POS_FACEUP)
-			local e1=Effect.CreateEffect(c)
-			e1:SetType(EFFECT_TYPE_SINGLE)
-			e1:SetCode(EFFECT_SET_BASE_ATTACK)
-			e1:SetValue(atk)
-			e1:SetReset(RESET_EVENT+RESETS_STANDARD)
-			token:RegisterEffect(e1)
-			local e2=e1:Clone()
-			e2:SetCode(EFFECT_CHANGE_LEVEL)
-			e2:SetValue(lv)
-			token:RegisterEffect(e2)
+			and Duel.IsPlayerCanSpecialSummonMonster(tp,TOKEN_DARK_SOUL,0,TYPES_TOKEN,atk,0,lv,RACE_ZOMBIE,ATTRIBUTE_DARK) then
+			local token=Duel.CreateToken(tp,TOKEN_DARK_SOUL)
+			token:Level(lv)
+			if Duel.SpecialSummonStep(token,0,tp,tp,false,false,POS_FACEUP) then
+				--Set the Token's original ATK to the original ATK of the monster that this card battled
+				local e1=Effect.CreateEffect(c)
+				e1:SetType(EFFECT_TYPE_SINGLE)
+				e1:SetProperty(EFFECT_FLAG_CANNOT_DISABLE)
+				e1:SetCode(EFFECT_SET_BASE_ATTACK)
+				e1:SetValue(atk)
+				e1:SetReset(RESET_EVENT|RESETS_STANDARD)
+				token:RegisterEffect(e1)
+			end
 			Duel.SpecialSummonComplete()
 		end
 	end
-end
-function s.indestg(e,c)
-	return c==e:GetHandler():GetBattleTarget()
-end
+end