"Double Spell (Anime)" fix

Fixed script errors and overhauled the whole script.

Author: pyrQ

unofficial/c513000055.lua

@@ -2,90 +2,170 @@
 --Double Spell (Anime)
 local s,id=GetID()
 function s.initial_effect(c)
-	--Copy spell
+	--Activate
 	local e1=Effect.CreateEffect(c)
+	e1:SetDescription(aux.Stringid(id,0))
 	e1:SetType(EFFECT_TYPE_ACTIVATE)
-	e1:SetCode(EVENT_FREE_CHAIN)
 	e1:SetProperty(EFFECT_FLAG_CARD_TARGET)
+	e1:SetCode(EVENT_FREE_CHAIN)
+	e1:SetHintTiming(TIMING_CHAIN_END,TIMING_CHAIN_END|TIMING_STANDBY_PHASE|TIMING_MAIN_END|TIMINGS_CHECK_MONSTER_E)
 	e1:SetTarget(s.target)
-	e1:SetOperation(s.operation)
+	e1:SetOperation(s.activate)
 	c:RegisterEffect(e1)
+	--Keep track of Spell Card activations
+	aux.GlobalCheck(s,function()
+		local ge1=Effect.CreateEffect(c)
+		ge1:SetType(EFFECT_TYPE_FIELD+EFFECT_TYPE_CONTINUOUS)
+		ge1:SetCode(EVENT_CHAINING)
+		ge1:SetOperation(s.checkop)
+		Duel.RegisterEffect(ge1,0)
+	end)
 end
-function s.filter(c,e,tp,eg,ep,ev,re,r,rp,tid)
-	local te=c:CheckActivateEffect(false,false,false)
-	if c:GetTurnID()~=tid-1 or not c:IsPreviousPosition(POS_FACEUP) then return false end
-	if c:IsSpell() and te then
-		if c:IsSetCard(0x95) then
-			local tg=te:GetTarget()
-			return not tg or tg(e,tp,eg,ep,ev,re,r,rp,0)
-		else
-			return true
-		end
+function s.checkop(e,tp,eg,ep,ev,re,r,rp)
+	if re:IsSpellEffect() then
+		re:GetHandler():RegisterFlagEffect(id+1,RESETS_STANDARD_PHASE_END&~(RESET_TOGRAVE|RESET_LEAVE),0,1)
 	end
-	return false
 end
-function s.target(e,tp,eg,ep,ev,re,r,rp,chk,chkc)
-	local tid=Duel.GetTurnCount()
-	if chkc then return chkc:IsLocation(LOCATION_GRAVE) and chkc:IsControler(1-tp) and s.filter(chkc,e,tp,eg,ep,ev,re,r,rp,tid) end
-	if chk==0 then
-		local b=e:GetHandler():IsLocation(LOCATION_HAND)
-		local ft=Duel.GetLocationCount(tp,LOCATION_SZONE)
-		if (b and ft>1) or (not b and ft>0) then
-			return Duel.IsExistingTarget(s.filter,tp,0,LOCATION_GRAVE,1,e:GetHandler(),e,tp,eg,ep,ev,re,r,rp,tid)
-		else
-			return false
+function s.tgfilter(c,tp,szone_adjustment)
+	if not c:IsSpell() or c:IsCode(id) or not c:HasFlagEffect(id+1) then return false end
+	if c:GetTurnID()~=Duel.GetTurnCount() then return false end
+	local te=c:GetActivateEffect()
+	--Check for HOPT
+	if not (te and te:CheckCountLimit(tp)) then return false end
+	--Check for "cannot activate" restrictions
+	if c:IsHasEffect(EFFECT_CANNOT_TRIGGER) then return false end
+	local cannot_act_restrictions={Duel.GetPlayerEffect(tp,EFFECT_CANNOT_ACTIVATE)}
+	if cannot_act_restrictions[1] then
+		for _,eff in ipairs(cannot_act_restrictions) do
+			local eff_value=eff:GetValue()
+			if type(eff_value)~='function' or eff_value(eff,te,tp) then return false end
 		end
 	end
-	local ft=Duel.GetLocationCount(tp,LOCATION_SZONE)
-	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_TARGET)
-	Duel.SelectTarget(tp,s.filter,tp,0,LOCATION_GRAVE,1,ft,nil,e,tp,eg,ep,ev,re,r,rp,tid)
+	local res,ceg,cep,cev,cre,cr,crp
+	if not Duel.IsChainSolving() then
+		--Check using the returned values of "Duel.CheckEvent" only for the activation check
+		local te_effect_code=te:GetCode()
+		res,ceg,cep,cev,cre,cr,crp=Duel.CheckEvent(te_effect_code,true)
+		--If it's "EVENT_FREE_CHAIN" then "res" will always be false
+		if not res and te_effect_code~=EVENT_FREE_CHAIN then return false end
+	else
+		local eff=c:IsHasEffect(id)
+		local t=eff:GetLabelObject()
+		ceg,cep,cev,cre,cr,crp=table.unpack(t)
+	end
+	local condition=te:GetCondition()
+	local cost=te:GetCost()
+	local target=te:GetTarget()
+	--Check if the card can be activated
+	if condition and not condition(te,tp,ceg,cep,cev,cre,cr,crp) then return false end
+	if cost and not cost(te,tp,ceg,cep,cev,cre,cr,crp,0) then return false end
+	if target and not target(te,tp,ceg,cep,cev,cre,cr,crp,0) then return false end
+	--Don't need to check for zones for a Field Card
+	if c:IsType(TYPE_FIELD) then return true end
+	--Check for cards that can only be activated in certain zones
+	local zones=0xff
+	if te:IsHasProperty(EFFECT_FLAG_LIMIT_ZONE) then
+		zones=te:GetValue()(te,tp,eg,ep,ev,re,r,rp)
+	end
+	return Duel.GetLocationCount(tp,LOCATION_SZONE,tp,LOCATION_REASON_TOFIELD,zones)-szone_adjustment>0
 end
-function s.operation(e,tp,eg,ep,ev,re,r,rp)
-	local tgg=Duel.GetTargetCards(e)
-	local tc=tgg:GetFirst()
-	while tc and Duel.GetLocationCount(tp,LOCATION_MZONE)>0 do
-		local tpe=tc:GetType()
+function s.target(e,tp,eg,ep,ev,re,r,rp,chk)
+	local c=e:GetHandler()
+	local szone_adjustment=c:IsLocation(LOCATION_SZONE) and 0 or 1
+	if chk==0 then return Duel.IsExistingMatchingCard(s.tgfilter,tp,0,LOCATION_GRAVE,1,c,tp,szone_adjustment) end
+	local g=Duel.GetMatchingGroup(Card.HasFlagEffect,tp,0,LOCATION_GRAVE,c,id+1)
+	for tc in g:Iter() do
 		local te=tc:GetActivateEffect()
-		local tg=te:GetTarget()
-		local co=te:GetCost()
-		local op=te:GetOperation()
-		e:SetCategory(te:GetCategory())
-		e:SetProperty(te:GetProperty())
-		Duel.ClearTargetCard()
-		local loc=LOCATION_SZONE
-		if (tpe&TYPE_FIELD)~=0 then
-			loc=LOCATION_FZONE
-			local of=Duel.GetFieldCard(1-tp,LOCATION_FZONE,0)
-			if of then Duel.Destroy(of,REASON_RULE) end
-			of=Duel.GetFieldCard(tp,LOCATION_FZONE,0)
-			if of and Duel.Destroy(of,REASON_RULE)==0 then Duel.SendtoGrave(tc,REASON_RULE) end
-		end
-		Duel.MoveToField(tc,tp,tp,loc,POS_FACEUP,true)
-		Duel.Hint(HINT_CARD,0,tc:GetCode())
-		tc:CreateEffectRelation(te)
-		if (tpe&TYPE_EQUIP+TYPE_CONTINUOUS+TYPE_FIELD)==0 then
-			tc:CancelToGrave(false)
+		local te_effect_code=te:GetCode()
+		local res,ceg,cep,cev,cre,cr,crp=Duel.CheckEvent(te_effect_code,true)
+		local t={ceg,cep,cev,cre,cr,crp}
+		--Dummy effect to save each card's event parameters
+		local e1=Effect.CreateEffect(c)
+		e1:SetType(EFFECT_TYPE_SINGLE)
+		e1:SetCode(id)
+		e1:SetLabelObject(t)
+		tc:RegisterEffect(e1)
+	end
+	Duel.SetOperationInfo(0,CATEGORY_LEAVE_GRAVE,nil,1,1-tp,0)
+end
+function s.activate(e,tp,eg,ep,ev,re,r,rp)
+	local c=e:GetHandler()
+	local g=Duel.GetMatchingGroup(s.tgfilter,tp,0,LOCATION_GRAVE,c,tp,0)
+	if #g==0 then return end
+	repeat
+		Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_EFFECT)
+		local sc=g:Select(tp,1,1,nil):GetFirst()
+		if sc then
+			s.place_and_activate(sc,e,tp,eg,ep,ev,re,r,rp)
 		end
-		if co then co(te,tp,eg,ep,ev,re,r,rp,1) end
-		if tg then tg(te,tp,eg,ep,ev,re,r,rp,1) end
-		Duel.BreakEffect()
-		local g=Duel.GetChainInfo(0,CHAININFO_TARGET_CARDS)
-		if g then
-			local etc=g:GetFirst()
-			while etc do
-				etc:CreateEffectRelation(te)
-				etc=g:GetNext()
+		g=Duel.GetMatchingGroup(s.tgfilter,tp,0,LOCATION_GRAVE,c,tp,0)
+	until #g==0 or not Duel.SelectEffectYesNo(tp,c)
+end
+function s.place_and_activate(sc,e,tp,eg,ep,ev,re,r,rp)
+	if not s.tgfilter(sc,tp,0) then return end
+	local te=sc:GetActivateEffect()
+	if not te then return end
+	local location=sc:IsType(TYPE_FIELD) and LOCATION_FZONE or LOCATION_SZONE
+	--Adjust "zones" for cards that can only be activated in certain zones
+	local zones=0xff
+	if te:IsHasProperty(EFFECT_FLAG_LIMIT_ZONE) then
+		zones=te:GetValue()(te,tp,eg,ep,ev,re,r,rp)
+	end
+	if not Duel.MoveToField(sc,tp,tp,location,POS_FACEUP,true,zones) then return end
+	--Set activated status, show the card, create relation to itself, and use the effect's count limit (if any)
+	sc:SetStatus(STATUS_ACTIVATED,true)
+	Duel.Hint(HINT_CARD,0,sc:GetCode())
+	sc:CreateEffectRelation(te)
+	te:UseCountLimit(tp)
+	--Mark the card as "to be sent to the GY" if it's not a card that remains on the field after activation
+	if not (sc:IsType(TYPE_FIELD) or sc:IsEquipSpell() or sc:IsContinuousSpellTrap() or sc:IsLinkSpell()
+		or sc:IsHasEffect(EFFECT_REMAIN_FIELD) or te:GetCost()==aux.RemainFieldCost) then
+		sc:CancelToGrave(false)
+	end
+	local eff=sc:IsHasEffect(id)
+	local t=eff:GetLabelObject()
+	eff:Reset()
+	local ceg,cep,cev,cre,cr,crp=table.unpack(t)
+	--Execute the cost, target, and operation with the designated parameters if the card's effects after it's placed on the field aren't negated
+	if not sc:IsDisabled() then
+		local cost=te:GetCost()
+		local target=te:GetTarget()
+		local operation=te:GetOperation()
+		--Set the effect's property so that targeted cards are highlighted normally
+		e:SetProperty(te:GetProperty())
+		--Activation procedure
+		if cost then cost(te,tp,ceg,cep,cev,cre,cr,crp,1) end
+		if target then target(te,tp,ceg,cep,cev,cre,cr,crp,1) end
+		--Manually create the effect relation for any targeted cards
+		local tg=Duel.GetChainInfo(0,CHAININFO_TARGET_CARDS)
+		if tg then
+			for tc in tg:Iter() do
+				tc:CreateEffectRelation(te)
 			end
 		end
-		if op then op(te,tp,eg,ep,ev,re,r,rp) end
-		tc:ReleaseEffectRelation(te)
-		if etc then
-			etc=g:GetFirst()
-			while etc do
-				etc:ReleaseEffectRelation(te)
-				etc=g:GetNext()
-			end
+		e:SetProperty(EFFECT_FLAG_CARD_TARGET)
+		local field_event_eg=Group.FromCards(sc)
+		local current_chain_link=Duel.GetCurrentChain()
+		--Manually raise the events for activating it
+		Duel.RaiseSingleEvent(sc,EVENT_CHAINING,te,0,tp,tp,current_chain_link)
+		Duel.RaiseEvent(field_event_eg,EVENT_CHAINING,te,0,tp,tp,current_chain_link)
+		--Break to separate the activation and the resolution
+		Duel.BreakEffect()
+		--Manually raise the events for the start of resolution
+		Duel.RaiseSingleEvent(sc,EVENT_CHAIN_SOLVING,te,0,tp,tp,current_chain_link)
+		Duel.RaiseEvent(field_event_eg,EVENT_CHAIN_SOLVING,te,0,tp,tp,current_chain_link)
+		--Resolution of the effect
+		if operation then operation(te,tp,ceg,cep,cev,cre,cr,crp) end
+		--Manually raise the events for the end of resolution
+		Duel.RaiseSingleEvent(sc,EVENT_CHAIN_SOLVED,te,0,tp,tp,current_chain_link)
+		Duel.RaiseEvent(field_event_eg,EVENT_CHAIN_SOLVED,te,0,tp,tp,current_chain_link)
+	end
+	--Manually release the effect relation for this card and any targeted cards
+	sc:ReleaseEffectRelation(te)
+	local tg=Duel.GetChainInfo(0,CHAININFO_TARGET_CARDS)
+	if tg then
+		for tc in tg:Iter() do
+			tc:ReleaseEffectRelation(te)
 		end
-		tc=tgg:GetNext()
 	end
 end