Stop streams automatically once dropped and make path params more generic #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwcd
commented
Jun 1, 2024
fwcd
force-pushed
the
stop-guard
branch
2 times, most recently
from
8b2bbc9 to
634645c
Compare
We deal with the type inference problem for empty paths (&[]) by providing a small convenience macro (root![]) that expresses the root path. Closes #15
fwcd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a guard to streams that automatically issues a
STOPonce dropped.Implementing this required a rather major change to the implementation, namely wrapping the internal state into
Arc/Mutex/atomics to makeLighthousecloneable, since the stop guard requires keeping a reference to theLighthousealive (dynamically). This refactoring is implemented in thelh-shared-statebranch, which this PR is based upon.