Skip to content

Commit 725dad9

Browse files
committed
prep for CRAN release
1 parent 9e8c52a commit 725dad9

File tree

5 files changed

+19
-14
lines changed

5 files changed

+19
-14
lines changed

DESCRIPTION

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ Imports:
2323
stringr,
2424
grid,
2525
labelled
26-
Remotes: github::davidgohel/ggiraph
2726
Suggests:
2827
tidyr,
2928
patchwork,
@@ -53,7 +52,7 @@ Suggests:
5352
quarto
5453
VignetteBuilder:
5554
quarto
56-
RoxygenNote: 7.3.2
55+
RoxygenNote: 7.3.3
5756
Roxygen: list(markdown = TRUE)
5857
Encoding: UTF-8
5958
URL: https://github.com/ProjectMOSAIC/ggformula

NEWS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
## ggformula 0.14.0
44

55
* Added support for interactive graphics based on {ggiraph}.
6+
* Modifications to support {ggplot2} version 4.0.
67

78
# ggformula 0.12.2
89

README-example-1.png

-133 KB
Loading

README.md

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11

22
<!-- README.md is generated from README.Rmd. Please edit that file -->
33

4-
# ggformula
4+
# ggformula <img src="man/figures/logo.png" align="right" height="120" alt="" />
55

66
<!-- badges: start -->
77

@@ -62,11 +62,14 @@ penguins |>
6262
legend.position = 'top',
6363
text = element_text(colour = "navy", face = "italic")
6464
)
65-
#> Warning: Removed 2 rows containing non-finite values (`stat_density2d()`).
66-
#> Warning: Computation failed in `stat_density2d()`
67-
#> Caused by error in `if (any(h <= 0)) ...`:
68-
#> ! missing value where TRUE/FALSE needed
69-
#> Warning: Removed 2 rows containing missing values (`geom_point()`).
65+
#> Warning: Removed 2 rows containing non-finite outside the scale range
66+
#> (`stat_density2d()`).
67+
#> Warning: Computation failed in `stat_density2d()`.
68+
#> Caused by error in `precompute_2d_bw()`:
69+
#> ! The bandwidth argument `h` must contain numbers larger than 0.
70+
#> ℹ Please set the `h` argument to stricly positive numbers manually.
71+
#> Warning: Removed 2 rows containing missing values or values outside the scale range
72+
#> (`geom_point()`).
7073
```
7174

7275
![](README-example-1.png)<!-- -->

cran-comments.md

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,15 @@
11
## Submission notes
22

3-
This is a relatively minor update to the package. The main issues addressed are
3+
This release
44

5-
* updating documentation to new CRAN standards
6-
* bug fix in GeomLm
7-
* moving some deprecated functions to defunct (to avoid ggstance, which is no longer supported)
8-
* adding two new (simple) auxiliary functions: gf_annotate() and gf_guides() which thinly wrap ggplot2::annotate() and ggplot2::guides()
5+
* addresses issues caused by the update of {ggplot2}
6+
* adds interactive features based on {ggiraph}, which has also been updated subsequent to {ggplot2}.
97

8+
I am aware of the use of ::: to access ggiraph:::layer_interactive().
9+
I have a request out for that function to be exported by the package.
10+
I'm hoping that will happen soonish. If it does not, I'll likely just copy
11+
the function into {ggformula}, but I'd rather not do that if it can be
12+
avoided.
1013

1114
## Test environments
1215

@@ -17,4 +20,3 @@ This is a relatively minor update to the package. The main issues addressed are
1720

1821
* WinBuilder
1922
* `devtools::check_win_devel()`
20-
* `devtools::check_win_release()`

0 commit comments

Comments
 (0)