Skip to content

Commit 616da22

Browse files
committed
Fix existing tests
1 parent 3fb8a29 commit 616da22

File tree

2 files changed

+7
-14
lines changed

2 files changed

+7
-14
lines changed

src/test/kotlin/io/github/projectmapk/jackson/module/kogera/zIntegration/deser/HasRequiredMarkerTest.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -108,10 +108,10 @@ class HasRequiredMarkerTest {
108108

109109
assertFalse(desc.isRequired("nullableProp"))
110110
assertFalse(desc.isRequired("nullableField"))
111-
assertFalse(desc.isRequired("collectionProp"))
112-
assertFalse(desc.isRequired("collectionField"))
113-
assertFalse(desc.isRequired("mapProp"))
114-
assertFalse(desc.isRequired("mapField"))
111+
assertTrue(desc.isRequired("collectionProp"))
112+
assertTrue(desc.isRequired("collectionField"))
113+
assertTrue(desc.isRequired("mapProp"))
114+
assertTrue(desc.isRequired("mapField"))
115115
assertTrue(desc.isRequired("nonNullProp"))
116116
assertTrue(desc.isRequired("nonNullField"))
117117
}

src/test/kotlin/io/github/projectmapk/jackson/module/kogera/zIntegration/ser/HasRequiredMarkerTest.kt

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,8 @@ class HasRequiredMarkerTest {
6767
val map: Map<*, *> = emptyMap<Any, Any>()
6868
}
6969

70-
// @see KotlinPrimaryAnnotationIntrospector::AnnotatedField.hasRequiredMarker
7170
@Test
72-
fun failing() {
71+
fun `nullToEmpty does not affect for field`() {
7372
val nullToDefaultMapper = ObjectMapper().registerModule(
7473
KotlinModule.Builder()
7574
.enable(KotlinFeature.NullToEmptyCollection)
@@ -78,13 +77,7 @@ class HasRequiredMarkerTest {
7877
)
7978
val desc = nullToDefaultMapper.introspectSer<NullToDefaultTarget>()
8079

81-
assertFalse(
82-
desc.isRequired("collection"),
83-
"KotlinPrimaryAnnotationIntrospector::AnnotatedField.hasRequiredMarker fixed"
84-
)
85-
assertFalse(
86-
desc.isRequired("map"),
87-
"KotlinPrimaryAnnotationIntrospector::AnnotatedField.hasRequiredMarker fixed"
88-
)
80+
assertTrue(desc.isRequired("collection"))
81+
assertTrue(desc.isRequired("map"))
8982
}
9083
}

0 commit comments

Comments
 (0)