Python: Switch to the modern approach for running unit tests

Since the release of Setuptools 41.5.0 in 2019, using "python setup.py test"
to run unit tests is deprecated. A more recent change causes running "python
setup.py test" to fail entirely. Hence switch to "python -m unittest". The
"unittest" module was introduced before 2010.

Author: bvanassche

Makefile.in

@@ -244,7 +244,10 @@ pythonuninstall:
 	echo "WARNING: python doesn't support uninstall"
 
 pythontest:
-	@(dir=`pwd`; cd python; $(PYMAKE) test --basedir=$$dir) ; \
+	@(export LD_LIBRARY_PATH="$$PWD/snmplib/.libs:$$PWD/agent/.libs:$$PWD/agent/helpers/.libs:"; \
+	export MIBDIRS="$$PWD/mibs"; \
+	export PYTHONPATH=$$(echo "$$PWD"/python/build/lib.*); \
+	$(PYTHON) -m unittest python/netsnmp/tests/test.py)
 	if test $$? != 0 ; then \
 	   exit 1 ; \
 	fi

ci/net-snmp-run-python-tests

@@ -1,19 +1,20 @@
 #!/bin/sh
 
-set -x
-killall snmpd
+set -eux
+if killall snmpd; then :; fi
 export LD_LIBRARY_PATH="$PWD/snmplib/.libs:$PWD/agent/.libs:$PWD/agent/helpers/.libs:"
 export MIBDIRS="$PWD/mibs"
 export SNMP_PERSISTENT_DIR=/tmp/net-snmp
 export SNMP_SNMPD_PORT=1161
-export PYTHONPATH="$PWD/python/netsnmp"
-mkdir -p "$SNMP_PERSISTENT_DIR" || exit $?
+for dir in "$PWD"/python/build/lib.*; do
+    export PYTHONPATH="${dir}"
+    break
+done
+mkdir -p "$SNMP_PERSISTENT_DIR"
 agent/snmpd -I-smux -r -f -Lo -c python/netsnmp/tests/snmpd.conf localhost:${SNMP_SNMPD_PORT} &
 pid=$!
-PYTHONPROG=$(sed -n 's/^S\["PYTHONPROG"\]="\(.*\)"$/\1/p' config.status) ||
-    exit $?
-[ -n "$PYTHONPROG" ] || exit 1
-cd python || exit $?
-$PYTHONPROG setup.py --basedir="$PWD/.." test || exit $?
+PYTHONPROG=$(sed -n 's/^S\["PYTHONPROG"\]="\(.*\)"$/\1/p' config.status)
+[ -n "$PYTHONPROG" ]
+$PYTHONPROG -m unittest python/netsnmp/tests/test.py
 kill $pid
 wait

python/README

@@ -70,7 +70,11 @@ Installation:
 
    cd net-snmp/python
    python setup.py build
-   python setup.py test (requires a locally running agent w/ config provided)
+   export LD_LIBRARY_PATH="$PWD/snmplib/.libs:$PWD/agent/.libs:$PWD/agent/helpers/.libs:"
+   export MIBDIRS="$PWD/mibs"
+   export PYTHONPATH="$(echo $PWD/build/lib.*)"
+   # Requires a locally running agent w/ config provided.
+   python -m unittest netsnmp/tests/test.py
    python setup.py install