mibgroup: notification: avoid potential null dereference

The pointer var_val was utilized before check against NULL.

Signed-off-by: Maksim Korotkov <[email protected]>

Author: ProjectMutilation

agent/mibgroup/notification/snmpNotifyFilterProfileTable.c

@@ -394,7 +394,7 @@ write_snmpNotifyFilterProfileRowStatus(int action,
     static struct snmpNotifyFilterProfileTable_data *StorageDel;
     size_t          newlen = name_len - table_offset;
     static int      old_value;
-    int             set_value = *((long *) var_val);
+    int             set_value = var_val ? *((long *) var_val) : RS_NONEXISTENT;
     netsnmp_variable_list *vars;
 
 
@@ -530,16 +530,15 @@ write_snmpNotifyFilterProfileRowStatus(int action,
             /*
              * XXX: ack, and if it is NULL? 
              */
-        } else if (set_value != RS_DESTROY) {
+        } else if (set_value != RS_DESTROY && set_value != RS_NONEXISTENT) {
             /*
              * set the flag? 
              */
             if (StorageTmp == NULL)
                 return SNMP_ERR_GENERR; /* should never ever get here */
 
             old_value = StorageTmp->snmpNotifyFilterProfileRowStatus;
-            StorageTmp->snmpNotifyFilterProfileRowStatus =
-                *((long *) var_val);
+            StorageTmp->snmpNotifyFilterProfileRowStatus = set_value;
         } else {
             /*
              * destroy...  extract it for now 

agent/mibgroup/notification/snmpNotifyTable.c

@@ -523,7 +523,7 @@ write_snmpNotifyRowStatus(int action,
     static struct snmpNotifyTable_data *StorageDel;
     size_t          newlen = name_len - snmpNotifyTable_offset;
     static int      old_value;
-    int             set_value = *((long *) var_val);
+    int             set_value = var_val ? *((long *) var_val) : RS_NONEXISTENT;
     static netsnmp_variable_list *vars, *vp;
 
     DEBUGMSGTL(("snmpNotifyTable",
@@ -645,15 +645,15 @@ write_snmpNotifyRowStatus(int action,
             if (StorageNew != NULL) {
                 snmpNotifyTable_add(StorageNew);
             }
-        } else if (set_value != RS_DESTROY) {
+        } else if (set_value != RS_DESTROY && set_value != RS_NONEXISTENT) {
             /*
              * set the flag? 
              */
             if (StorageTmp == NULL)
                 return SNMP_ERR_GENERR; /* should never ever get here */
 
             old_value = StorageTmp->snmpNotifyRowStatus;
-            StorageTmp->snmpNotifyRowStatus = *((long *) var_val);
+            StorageTmp->snmpNotifyRowStatus = set_value;
         } else {
             /*
              * destroy...  extract it for now