Skip to content

Commit e577369

Browse files
authored
Celery: Update testcases mock (#721)
1 parent d94feab commit e577369

File tree

9 files changed

+24
-45
lines changed

9 files changed

+24
-45
lines changed

backend/app/tests/api/routes/test_llm.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
def test_llm_call_success(
1616
client: TestClient, user_api_key_header: dict[str, str]
1717
) -> None:
18-
"""Test successful LLM call with mocked start_high_priority_job."""
19-
with patch("app.services.llm.jobs.start_high_priority_job") as mock_start_job:
18+
"""Test successful LLM call with mocked start_llm_job."""
19+
with patch("app.services.llm.jobs.start_llm_job") as mock_start_job:
2020
mock_start_job.return_value = "test-task-id"
2121

2222
payload = LLMCallRequest(
@@ -55,7 +55,7 @@ def test_llm_call_with_kaapi_config(
5555
client: TestClient, user_api_key_header: dict[str, str]
5656
) -> None:
5757
"""Test LLM call with Kaapi abstracted config."""
58-
with patch("app.services.llm.jobs.start_high_priority_job") as mock_start_job:
58+
with patch("app.services.llm.jobs.start_llm_job") as mock_start_job:
5959
mock_start_job.return_value = "test-task-id"
6060

6161
payload = LLMCallRequest(
@@ -91,7 +91,7 @@ def test_llm_call_with_native_config(
9191
client: TestClient, user_api_key_header: dict[str, str]
9292
) -> None:
9393
"""Test LLM call with native OpenAI config (pass-through mode)."""
94-
with patch("app.services.llm.jobs.start_high_priority_job") as mock_start_job:
94+
with patch("app.services.llm.jobs.start_llm_job") as mock_start_job:
9595
mock_start_job.return_value = "test-task-id"
9696

9797
payload = LLMCallRequest(
@@ -173,7 +173,7 @@ def test_llm_call_success_with_guardrails(
173173
) -> None:
174174
"""Test successful LLM call when guardrails are enabled (no validators)."""
175175

176-
with patch("app.services.llm.jobs.start_high_priority_job") as mock_start_job:
176+
with patch("app.services.llm.jobs.start_llm_job") as mock_start_job:
177177
mock_start_job.return_value = "test-task-id"
178178

179179
payload = LLMCallRequest(
@@ -214,7 +214,7 @@ def test_llm_call_guardrails_bypassed_still_succeeds(
214214
) -> None:
215215
"""If guardrails service is unavailable (bypassed), request should still succeed."""
216216

217-
with patch("app.services.llm.jobs.start_high_priority_job") as mock_start_job:
217+
with patch("app.services.llm.jobs.start_llm_job") as mock_start_job:
218218
mock_start_job.return_value = "test-task-id"
219219

220220
payload = LLMCallRequest(

backend/app/tests/api/routes/test_stt_evaluation.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -807,7 +807,7 @@ def test_dataset_with_samples(
807807
)
808808
return dataset
809809

810-
@patch("app.api.routes.stt_evaluations.evaluation.start_low_priority_job")
810+
@patch("app.api.routes.stt_evaluations.evaluation.start_stt_batch_submission")
811811
def test_start_stt_evaluation_success(
812812
self,
813813
mock_start_job: MagicMock,

backend/app/tests/api/routes/test_tts_evaluation.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -523,7 +523,7 @@ def test_dataset_with_samples(
523523
dataset_metadata={"sample_count": 3},
524524
)
525525

526-
@patch("app.api.routes.tts_evaluations.evaluation.start_low_priority_job")
526+
@patch("app.api.routes.tts_evaluations.evaluation.start_tts_batch_submission")
527527
def test_start_evaluation_success(
528528
self,
529529
mock_start_job: MagicMock,
@@ -565,14 +565,11 @@ def test_start_evaluation_success(
565565

566566
mock_start_job.assert_called_once()
567567
call_kwargs = mock_start_job.call_args
568-
assert call_kwargs.kwargs["function_path"] == (
569-
"app.services.tts_evaluations.batch_job.execute_batch_submission"
570-
)
571568
assert call_kwargs.kwargs["organization_id"] == user_api_key.organization_id
572569
assert call_kwargs.kwargs["dataset_id"] == dataset.id
573570
assert call_kwargs.kwargs["models"] == ["gemini-2.5-pro-preview-tts"]
574571

575-
@patch("app.api.routes.tts_evaluations.evaluation.start_low_priority_job")
572+
@patch("app.api.routes.tts_evaluations.evaluation.start_tts_batch_submission")
576573
def test_start_evaluation_multiple_models_total_items(
577574
self,
578575
mock_start_job: MagicMock,
@@ -606,7 +603,7 @@ def test_start_evaluation_multiple_models_total_items(
606603
# 5 samples × 1 model
607604
assert data["total_items"] == 5
608605

609-
@patch("app.api.routes.tts_evaluations.evaluation.start_low_priority_job")
606+
@patch("app.api.routes.tts_evaluations.evaluation.start_tts_batch_submission")
610607
def test_start_evaluation_celery_failure(
611608
self,
612609
mock_start_job: MagicMock,

backend/app/tests/services/collections/test_create_collection.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ def test_start_job_creates_collection_job_and_schedules_task(db: Session) -> Non
5252
"""
5353
start_job should:
5454
- update an existing CollectionJob (status=PENDING, action=CREATE)
55-
- call start_low_priority_job with the correct kwargs
55+
- call start_create_collection_job with the correct kwargs
5656
- return the job UUID (same one that was passed in)
5757
"""
5858
project = get_project(db)
@@ -74,7 +74,7 @@ def test_start_job_creates_collection_job_and_schedules_task(db: Session) -> Non
7474
)
7575

7676
with patch(
77-
"app.services.collections.create_collection.start_low_priority_job"
77+
"app.services.collections.create_collection.start_create_collection_job"
7878
) as mock_schedule:
7979
mock_schedule.return_value = "fake-task-id"
8080

@@ -101,10 +101,6 @@ def test_start_job_creates_collection_job_and_schedules_task(db: Session) -> Non
101101

102102
mock_schedule.assert_called_once()
103103
kwargs = mock_schedule.call_args.kwargs
104-
assert (
105-
kwargs["function_path"]
106-
== "app.services.collections.create_collection.execute_job"
107-
)
108104
assert kwargs["project_id"] == project.id
109105
assert kwargs["organization_id"] == project.organization_id
110106
assert kwargs["job_id"] == str(job_id)

backend/app/tests/services/collections/test_delete_collection.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def test_start_job_creates_collection_job_and_schedules_task(db: Session) -> Non
2323
req = DeletionRequest(collection_id=created_collection.id)
2424

2525
with patch(
26-
"app.services.collections.delete_collection.start_low_priority_job"
26+
"app.services.collections.delete_collection.start_delete_collection_job"
2727
) as mock_schedule:
2828
mock_schedule.return_value = "fake-task-id"
2929

@@ -58,10 +58,6 @@ def test_start_job_creates_collection_job_and_schedules_task(db: Session) -> Non
5858

5959
mock_schedule.assert_called_once()
6060
kwargs = mock_schedule.call_args.kwargs
61-
assert (
62-
kwargs["function_path"]
63-
== "app.services.collections.delete_collection.execute_job"
64-
)
6561
assert kwargs["project_id"] == project.id
6662
assert kwargs["organization_id"] == project.organization_id
6763
assert kwargs["job_id"] == str(job.id)

backend/app/tests/services/doctransformer/test_job/test_integration.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ def test_execute_job_end_to_end_workflow(
3737
job = job_crud.create(DocTransformJobCreate(source_document_id=document.id))
3838

3939
with patch(
40-
"app.services.doctransform.job.start_low_priority_job",
40+
"app.services.doctransform.job.start_doctransform_job",
4141
return_value="fake-task-id",
4242
), patch("app.services.doctransform.job.Session") as mock_session_class, patch(
4343
"app.services.doctransform.registry.TRANSFORMERS",

backend/app/tests/services/doctransformer/test_job/test_start_job.py

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def test_start_job_success(
4242
job = self._create_job(db, current_user.project.id, document.id)
4343

4444
with patch(
45-
"app.services.doctransform.job.start_low_priority_job"
45+
"app.services.doctransform.job.start_doctransform_job"
4646
) as mock_schedule:
4747
mock_schedule.return_value = "fake-task-id"
4848

@@ -66,7 +66,6 @@ def test_start_job_success(
6666

6767
mock_schedule.assert_called_once()
6868
kwargs = mock_schedule.call_args.kwargs
69-
assert kwargs["function_path"] == "app.services.doctransform.job.execute_job"
7069
assert kwargs["project_id"] == current_user.project.id
7170
assert kwargs["job_id"] == str(job.id)
7271
assert kwargs["source_document_id"] == str(job.source_document_id)
@@ -87,7 +86,7 @@ def test_start_job_with_nonexistent_document(
8786

8887
with pytest.raises(HTTPException):
8988
with patch(
90-
"app.services.doctransform.job.start_low_priority_job"
89+
"app.services.doctransform.job.start_doctransform_job"
9190
) as mock_schedule:
9291
mock_schedule.return_value = "fake-task-id"
9392
start_job(
@@ -113,7 +112,7 @@ def test_start_job_with_different_formats(
113112
formats = ["markdown", "text", "html"]
114113

115114
with patch(
116-
"app.services.doctransform.job.start_low_priority_job"
115+
"app.services.doctransform.job.start_doctransform_job"
117116
) as mock_schedule:
118117
mock_schedule.return_value = "fake-task-id"
119118

@@ -137,10 +136,6 @@ def test_start_job_with_different_formats(
137136
# scheduler called with correct kwargs
138137
kwargs = mock_schedule.call_args.kwargs
139138
assert kwargs["target_format"] == target_format
140-
assert (
141-
kwargs["function_path"]
142-
== "app.services.doctransform.job.execute_job"
143-
)
144139
assert kwargs["project_id"] == current_user.project.id
145140
assert kwargs["job_id"] == str(job.id)
146141
assert kwargs["source_document_id"] == str(job.source_document_id)
@@ -163,7 +158,7 @@ def test_start_job_with_different_transformers(
163158
job = self._create_job(db, current_user.project.id, document.id)
164159

165160
with patch(
166-
"app.services.doctransform.job.start_low_priority_job"
161+
"app.services.doctransform.job.start_doctransform_job"
167162
) as mock_schedule:
168163
mock_schedule.return_value = "fake-task-id"
169164

@@ -183,7 +178,6 @@ def test_start_job_with_different_transformers(
183178
kwargs = mock_schedule.call_args.kwargs
184179
assert kwargs["transformer_name"] == transformer_name
185180
assert kwargs["target_format"] == "markdown"
186-
assert kwargs["function_path"] == "app.services.doctransform.job.execute_job"
187181
assert kwargs["project_id"] == current_user.project.id
188182
assert kwargs["job_id"] == str(job.id)
189183
assert kwargs["source_document_id"] == str(job.source_document_id)

backend/app/tests/services/llm/test_jobs.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ def test_start_job_success(self, db: Session, llm_call_request: LLMCallRequest):
6464
request = llm_call_request
6565
project = get_project(db)
6666

67-
with patch("app.services.llm.jobs.start_high_priority_job") as mock_schedule:
67+
with patch("app.services.llm.jobs.start_llm_job") as mock_schedule:
6868
mock_schedule.return_value = "fake-task-id-123"
6969

7070
job_id = start_job(db, request, project.id, project.organization_id)
@@ -78,7 +78,6 @@ def test_start_job_success(self, db: Session, llm_call_request: LLMCallRequest):
7878

7979
mock_schedule.assert_called_once()
8080
_, kwargs = mock_schedule.call_args
81-
assert kwargs["function_path"] == "app.services.llm.jobs.execute_job"
8281
assert kwargs["project_id"] == project.id
8382
assert kwargs["organization_id"] == project.organization_id
8483
assert kwargs["job_id"] == str(job_id)
@@ -90,7 +89,7 @@ def test_start_job_celery_scheduling_fails(
9089
"""Test start_job when Celery task scheduling fails."""
9190
project = get_project(db)
9291

93-
with patch("app.services.llm.jobs.start_high_priority_job") as mock_schedule:
92+
with patch("app.services.llm.jobs.start_llm_job") as mock_schedule:
9493
mock_schedule.side_effect = Exception("Celery connection failed")
9594

9695
with pytest.raises(HTTPException) as exc_info:
@@ -1190,7 +1189,7 @@ def test_start_chain_job_success(self, db: Session, chain_request):
11901189
project = get_project(db)
11911190

11921191
with (
1193-
patch("app.services.llm.jobs.start_high_priority_job") as mock_schedule,
1192+
patch("app.services.llm.jobs.start_llm_chain_job") as mock_schedule,
11941193
patch("app.services.llm.jobs.JobCrud") as mock_job_crud_class,
11951194
):
11961195
mock_schedule.return_value = "fake-task-id"
@@ -1206,14 +1205,12 @@ def test_start_chain_job_success(self, db: Session, chain_request):
12061205

12071206
assert job_id == mock_job.id
12081207
mock_schedule.assert_called_once()
1209-
_, kwargs = mock_schedule.call_args
1210-
assert kwargs["function_path"] == "app.services.llm.jobs.execute_chain_job"
12111208

12121209
def test_start_chain_job_celery_failure(self, db: Session, chain_request):
12131210
project = get_project(db)
12141211

12151212
with (
1216-
patch("app.services.llm.jobs.start_high_priority_job") as mock_schedule,
1213+
patch("app.services.llm.jobs.start_llm_chain_job") as mock_schedule,
12171214
patch("app.services.llm.jobs.JobCrud") as mock_job_crud_class,
12181215
):
12191216
mock_schedule.side_effect = Exception("Celery connection failed")

backend/app/tests/services/response/test_jobs_response.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ def test_start_job(db: Session):
1818

1919
project = get_project(db)
2020
# Patch Celery scheduling
21-
with patch("app.services.response.jobs.start_high_priority_job") as mock_schedule:
21+
with patch("app.services.response.jobs.start_response_job") as mock_schedule:
2222
mock_schedule.return_value = "fake-task-id"
2323

2424
job_id = start_job(db, request, project.id, project.organization_id)
@@ -33,7 +33,6 @@ def test_start_job(db: Session):
3333
# Validate Celery was called correctly
3434
mock_schedule.assert_called_once()
3535
_, kwargs = mock_schedule.call_args
36-
assert kwargs["function_path"] == "app.services.response.jobs.execute_job"
3736
assert kwargs["project_id"] == project.id
3837
assert kwargs["organization_id"] == project.organization_id
3938
assert kwargs["job_id"] == str(job_id)
@@ -48,7 +47,7 @@ def test_start_job_celery_exception(db: Session):
4847
)
4948
project = get_project(db)
5049

51-
with patch("app.services.response.jobs.start_high_priority_job") as mock_schedule:
50+
with patch("app.services.response.jobs.start_response_job") as mock_schedule:
5251
mock_schedule.side_effect = Exception("Celery connection failed")
5352

5453
with pytest.raises(HTTPException) as exc_info:

0 commit comments

Comments
 (0)