remove unused boolean return in action

HSGamer · HSGamer · commit 872585832372 · 2025-10-19T23:47:02.000+07:00
diff --git a/editor-extra/src/main/java/io/github/projectunified/minigamecore/editor/extra/action/BooleanAction.java b/editor-extra/src/main/java/io/github/projectunified/minigamecore/editor/extra/action/BooleanAction.java
@@ -30,15 +30,15 @@ public List<String> complete(EditorActor actor, String[] args) {
      * @param actor the actor
      * @param value the value
      * @param args  the arguments
-     * @return true if the action is executed successfully
      */
-    public abstract boolean execute(EditorActor actor, boolean value, String[] args);
+    public abstract void execute(EditorActor actor, boolean value, String[] args);
 
     @Override
-    public boolean execute(EditorActor actor, String[] args) {
+    public void execute(EditorActor actor, String[] args) {
         if (args.length < 1) {
-            return actor.sendUsage(this);
+            actor.sendUsage(this);
+            return;
         }
-        return execute(actor, Boolean.parseBoolean(args[0]), Arrays.copyOfRange(args, 1, args.length));
+        execute(actor, Boolean.parseBoolean(args[0]), Arrays.copyOfRange(args, 1, args.length));
     }
 }
diff --git a/editor-extra/src/main/java/io/github/projectunified/minigamecore/editor/extra/action/EnumAction.java b/editor-extra/src/main/java/io/github/projectunified/minigamecore/editor/extra/action/EnumAction.java
@@ -32,9 +32,8 @@ public EnumAction(Class<T> enumClass) {
      * @param actor the actor
      * @param value the value
      * @param args  the arguments
-     * @return true if the action is executed successfully
      */
-    public abstract boolean execute(EditorActor actor, T value, String[] args);
+    public abstract void execute(EditorActor actor, T value, String[] args);
 
     @Override
     public String usage() {
@@ -50,16 +49,16 @@ public List<String> complete(EditorActor actor, String[] args) {
     }
 
     @Override
-    public boolean execute(EditorActor actor, String[] args) {
+    public void execute(EditorActor actor, String[] args) {
         if (args.length < 1) {
-            return actor.sendUsage(this);
+            actor.sendUsage(this);
+            return;
         }
         try {
             T value = Enum.valueOf(enumClass, args[0].toUpperCase(Locale.ROOT));
-            return execute(actor, value, args);
+            execute(actor, value, args);
         } catch (IllegalArgumentException e) {
             actor.sendMessage("Invalid value: " + args[0], false);
-            return false;
         }
     }
 }
diff --git a/editor-extra/src/main/java/io/github/projectunified/minigamecore/editor/extra/action/NumberAction.java b/editor-extra/src/main/java/io/github/projectunified/minigamecore/editor/extra/action/NumberAction.java
@@ -34,9 +34,8 @@ public List<String> complete(EditorActor actor, String[] args) {
      * @param actor the actor
      * @param value the value
      * @param args  the arguments
-     * @return true if the action is executed successfully
      */
-    public abstract boolean execute(EditorActor actor, Number value, String[] args);
+    public abstract void execute(EditorActor actor, Number value, String[] args);
 
     /**
      * Get number suggestions
@@ -49,16 +48,16 @@ public Stream<? extends Number> valueComplete(EditorActor actor) {
     }
 
     @Override
-    public boolean execute(EditorActor actor, String[] args) {
+    public void execute(EditorActor actor, String[] args) {
         if (args.length < 1) {
-            return actor.sendUsage(this);
+            actor.sendUsage(this);
+            return;
         }
         String value = args[0];
         try {
-            return execute(actor, Double.parseDouble(value), Arrays.copyOfRange(args, 1, args.length));
+            execute(actor, Double.parseDouble(value), Arrays.copyOfRange(args, 1, args.length));
         } catch (NumberFormatException e) {
             actor.sendMessage("Invalid Number: " + value, false);
-            return false;
         }
     }
 }
diff --git a/editor-extra/src/main/java/io/github/projectunified/minigamecore/editor/extra/editor/ListEditor.java b/editor-extra/src/main/java/io/github/projectunified/minigamecore/editor/extra/editor/ListEditor.java
@@ -24,15 +24,14 @@ protected ListEditor() {
         this.actionMap = new HashMap<>();
         this.actionMap.put("add", new EditorAction() {
             @Override
-            public boolean execute(EditorActor actor, String[] args) {
+            public void execute(EditorActor actor, String[] args) {
                 T value = create(actor, args);
                 if (value == null) {
                     actor.sendMessage("Cannot create (" + Arrays.toString(args) + ")", false);
-                    return false;
+                    return;
                 }
                 list.add(value);
                 actor.sendMessage("Added (" + Arrays.toString(args) + ") at index " + (list.size() - 1), true);
-                return true;
             }
 
             @Override
@@ -52,32 +51,31 @@ public String usage() {
         });
         this.actionMap.put("edit", new EditorAction() {
             @Override
-            public boolean execute(EditorActor actor, String[] args) {
+            public void execute(EditorActor actor, String[] args) {
                 if (args.length < 1) {
-                    return false;
+                    return;
                 }
                 int index;
                 try {
                     index = Integer.parseInt(args[0]);
                 } catch (NumberFormatException e) {
                     actor.sendMessage("Invalid index: " + args[0], false);
-                    return false;
+                    return;
                 }
                 if (index < 0 || index >= list.size()) {
                     actor.sendMessage("Index out of bounds: " + index, false);
-                    return false;
+                    return;
                 }
                 T value = list.get(index);
                 T edited = edit(value, actor, Arrays.copyOfRange(args, 1, args.length));
                 if (edited == null) {
                     actor.sendMessage("Cannot edit (" + Arrays.toString(args) + ")", false);
-                    return false;
+                    return;
                 }
                 if (edited != value) {
                     list.set(index, edited);
                 }
                 actor.sendMessage("Edited (" + Arrays.toString(args) + ")", true);
-                return true;
             }
 
             @Override
@@ -115,24 +113,23 @@ public String usage() {
         });
         this.actionMap.put("remove", new EditorAction() {
             @Override
-            public boolean execute(EditorActor actor, String[] args) {
+            public void execute(EditorActor actor, String[] args) {
                 if (args.length < 1) {
-                    return false;
+                    return;
                 }
                 int index;
                 try {
                     index = Integer.parseInt(args[0]);
                 } catch (NumberFormatException e) {
                     actor.sendMessage("Invalid index: " + args[0], false);
-                    return false;
+                    return;
                 }
                 if (index < 0 || index >= list.size()) {
                     actor.sendMessage("Index out of bounds: " + index, false);
-                    return false;
+                    return;
                 }
                 list.remove(index);
                 actor.sendMessage("Removed element at index " + index, true);
-                return true;
             }
 
             @Override
@@ -157,42 +154,41 @@ public String usage() {
         });
         this.actionMap.put("move", new EditorAction() {
             @Override
-            public boolean execute(EditorActor actor, String[] args) {
+            public void execute(EditorActor actor, String[] args) {
                 if (args.length < 2) {
-                    return false;
+                    return;
                 }
 
                 int index;
                 try {
                     index = Integer.parseInt(args[0]);
                 } catch (NumberFormatException e) {
                     actor.sendMessage("Invalid index: " + args[0], false);
-                    return false;
+                    return;
                 }
 
                 int newIndex;
                 try {
                     newIndex = Integer.parseInt(args[1]);
                 } catch (NumberFormatException e) {
                     actor.sendMessage("Invalid new index: " + args[1], false);
-                    return false;
+                    return;
                 }
 
                 if (index < 0 || index >= list.size()) {
                     actor.sendMessage("Index out of bounds: " + index, false);
-                    return false;
+                    return;
                 }
 
                 if (newIndex < 0 || newIndex >= list.size()) {
                     actor.sendMessage("New index out of bounds: " + newIndex, false);
-                    return false;
+                    return;
                 }
 
                 T value = list.get(index);
                 list.remove(index);
                 list.add(newIndex, value);
                 actor.sendMessage("Moved element at index " + index + " to index " + newIndex, true);
-                return true;
             }
 
             @Override
diff --git a/editor-extra/src/main/java/io/github/projectunified/minigamecore/editor/extra/editor/ValueEditor.java b/editor-extra/src/main/java/io/github/projectunified/minigamecore/editor/extra/editor/ValueEditor.java
@@ -22,15 +22,14 @@ protected ValueEditor() {
         this.actionMap = new HashMap<>();
         this.actionMap.put("set", new EditorAction() {
             @Override
-            public boolean execute(EditorActor actor, String[] args) {
+            public void execute(EditorActor actor, String[] args) {
                 T value = create(actor, args);
                 if (value == null) {
                     actor.sendMessage("Cannot create (" + Arrays.toString(args) + ")", false);
-                    return false;
+                    return;
                 }
                 ValueEditor.this.value = value;
                 actor.sendMessage("Set (" + Arrays.toString(args) + ")", true);
-                return true;
             }
 
             @Override
@@ -50,20 +49,19 @@ public Collection<String> complete(EditorActor actor, String[] args) {
         });
         this.actionMap.put("edit", new EditorAction() {
             @Override
-            public boolean execute(EditorActor actor, String[] args) {
+            public void execute(EditorActor actor, String[] args) {
                 if (value == null) {
-                    return false;
+                    return;
                 }
                 T edited = edit(value, actor, args);
                 if (edited == null) {
                     actor.sendMessage("Cannot edit (" + Arrays.toString(args) + ")", false);
-                    return false;
+                    return;
                 }
                 if (edited != value) {
                     value = edited;
                 }
                 actor.sendMessage("Edited (" + Arrays.toString(args) + ")", true);
-                return true;
             }
 
             @Override
diff --git a/editor/src/main/java/io/github/projectunified/minigamecore/editor/Editor.java b/editor/src/main/java/io/github/projectunified/minigamecore/editor/Editor.java
@@ -75,17 +75,19 @@ default Collection<String> complete(EditorActor actor, String[] args) {
     }
 
     @Override
-    default boolean execute(EditorActor actor, String[] args) {
+    default void execute(EditorActor actor, String[] args) {
         if (args.length == 0) {
-            return actor.sendUsage(this);
+            actor.sendUsage(this);
+            return;
         }
         String command = args[0];
         EditorAction action = actions().get(command);
         if (action == null) {
-            return false;
+            actor.sendMessage("Invalid action: " + command, false);
+            return;
         }
         String[] subArgs = new String[args.length - 1];
         System.arraycopy(args, 1, subArgs, 0, args.length - 1);
-        return action.execute(actor, subArgs);
+        action.execute(actor, subArgs);
     }
 }
diff --git a/editor/src/main/java/io/github/projectunified/minigamecore/editor/EditorAction.java b/editor/src/main/java/io/github/projectunified/minigamecore/editor/EditorAction.java
@@ -12,9 +12,8 @@ public interface EditorAction {
      *
      * @param actor the actor
      * @param args  the arguments
-     * @return true if the action is executed successfully
      */
-    boolean execute(EditorActor actor, String[] args);
+    void execute(EditorActor actor, String[] args);
 
     /**
      * Get the description of the action
diff --git a/editor/src/main/java/io/github/projectunified/minigamecore/editor/EditorActor.java b/editor/src/main/java/io/github/projectunified/minigamecore/editor/EditorActor.java
@@ -16,15 +16,13 @@ public interface EditorActor {
      * Send the usage of the action
      *
      * @param action the action
-     * @return true if the usage is sent successfully
      */
-    boolean sendUsage(EditorAction action);
+    void sendUsage(EditorAction action);
 
     /**
      * Send the usage of the editor
      *
      * @param editor the editor
-     * @return true if the usage is sent successfully
      */
-    boolean sendUsage(Editor<?> editor);
+    void sendUsage(Editor<?> editor);
 }

Original file line number	Diff line number	Diff line change
`@@ -32,9 +32,8 @@ public EnumAction(Class<T> enumClass) {`
`32`	`32`	`* @param actor the actor`
`33`	`33`	`* @param value the value`
`34`	`34`	`* @param args the arguments`
`35`		`- * @return true if the action is executed successfully`
`36`	`35`	`*/`
`37`		`- public abstract boolean execute(EditorActor actor, T value, String[] args);`
	`36`	`+ public abstract void execute(EditorActor actor, T value, String[] args);`
`38`	`37`
`39`	`38`	`@Override`
`40`	`39`	`public String usage() {`
`@@ -50,16 +49,16 @@ public List<String> complete(EditorActor actor, String[] args) {`
`50`	`49`	`}`
`51`	`50`
`52`	`51`	`@Override`
`53`		`- public boolean execute(EditorActor actor, String[] args) {`
	`52`	`+ public void execute(EditorActor actor, String[] args) {`
`54`	`53`	`if (args.length < 1) {`
`55`		`- return actor.sendUsage(this);`
	`54`	`+ actor.sendUsage(this);`
	`55`	`+ return;`
`56`	`56`	`}`
`57`	`57`	`try {`
`58`	`58`	`T value = Enum.valueOf(enumClass, args[0].toUpperCase(Locale.ROOT));`
`59`		`- return execute(actor, value, args);`
	`59`	`+ execute(actor, value, args);`
`60`	`60`	`} catch (IllegalArgumentException e) {`
`61`	`61`	`actor.sendMessage("Invalid value: " + args[0], false);`
`62`		`- return false;`
`63`	`62`	`}`
`64`	`63`	`}`
`65`	`64`	`}`
Original file line number	Diff line number	Diff line change
`@@ -34,9 +34,8 @@ public List<String> complete(EditorActor actor, String[] args) {`
`34`	`34`	`* @param actor the actor`
`35`	`35`	`* @param value the value`
`36`	`36`	`* @param args the arguments`
`37`		`- * @return true if the action is executed successfully`
`38`	`37`	`*/`
`39`		`- public abstract boolean execute(EditorActor actor, Number value, String[] args);`
	`38`	`+ public abstract void execute(EditorActor actor, Number value, String[] args);`
`40`	`39`
`41`	`40`	`/**`
`42`	`41`	`* Get number suggestions`
`@@ -49,16 +48,16 @@ public Stream<? extends Number> valueComplete(EditorActor actor) {`
`49`	`48`	`}`
`50`	`49`
`51`	`50`	`@Override`
`52`		`- public boolean execute(EditorActor actor, String[] args) {`
	`51`	`+ public void execute(EditorActor actor, String[] args) {`
`53`	`52`	`if (args.length < 1) {`
`54`		`- return actor.sendUsage(this);`
	`53`	`+ actor.sendUsage(this);`
	`54`	`+ return;`
`55`	`55`	`}`
`56`	`56`	`String value = args[0];`
`57`	`57`	`try {`
`58`		`- return execute(actor, Double.parseDouble(value), Arrays.copyOfRange(args, 1, args.length));`
	`58`	`+ execute(actor, Double.parseDouble(value), Arrays.copyOfRange(args, 1, args.length));`
`59`	`59`	`} catch (NumberFormatException e) {`
`60`	`60`	`actor.sendMessage("Invalid Number: " + value, false);`
`61`		`- return false;`
`62`	`61`	`}`
`63`	`62`	`}`
`64`	`63`	`}`
Original file line number	Diff line number	Diff line change
`@@ -75,17 +75,19 @@ default Collection<String> complete(EditorActor actor, String[] args) {`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`@Override`
`78`		`- default boolean execute(EditorActor actor, String[] args) {`
	`78`	`+ default void execute(EditorActor actor, String[] args) {`
`79`	`79`	`if (args.length == 0) {`
`80`		`- return actor.sendUsage(this);`
	`80`	`+ actor.sendUsage(this);`
	`81`	`+ return;`
`81`	`82`	`}`
`82`	`83`	`String command = args[0];`
`83`	`84`	`EditorAction action = actions().get(command);`
`84`	`85`	`if (action == null) {`
`85`		`- return false;`
	`86`	`+ actor.sendMessage("Invalid action: " + command, false);`
	`87`	`+ return;`
`86`	`88`	`}`
`87`	`89`	`String[] subArgs = new String[args.length - 1];`
`88`	`90`	`System.arraycopy(args, 1, subArgs, 0, args.length - 1);`
`89`		`- return action.execute(actor, subArgs);`
	`91`	`+ action.execute(actor, subArgs);`
`90`	`92`	`}`
`91`	`93`	`}`
Original file line number	Diff line number	Diff line change
`@@ -16,15 +16,13 @@ public interface EditorActor {`
`16`	`16`	`* Send the usage of the action`
`17`	`17`	`*`
`18`	`18`	`* @param action the action`
`19`		`- * @return true if the usage is sent successfully`
`20`	`19`	`*/`
`21`		`- boolean sendUsage(EditorAction action);`
	`20`	`+ void sendUsage(EditorAction action);`
`22`	`21`
`23`	`22`	`/**`
`24`	`23`	`* Send the usage of the editor`
`25`	`24`	`*`
`26`	`25`	`* @param editor the editor`
`27`		`- * @return true if the usage is sent successfully`
`28`	`26`	`*/`
`29`		`- boolean sendUsage(Editor<?> editor);`
	`27`	`+ void sendUsage(Editor<?> editor);`
`30`	`28`	`}`