add a boolean check for bottom location

Author: HSGamer

common/src/main/java/me/hsgamer/unihologram/common/api/Hologram.java

@@ -119,4 +119,13 @@ default int size() {
      * @param location the location
      */
     void setLocation(T location);
+
+    /**
+     * Check if the location is at the bottom of the hologram
+     *
+     * @return true if it is
+     */
+    default boolean isLocationBottom() {
+        return false;
+    }
 }

display/src/main/java/me/hsgamer/unihologram/display/DisplayHologram.java

@@ -108,19 +108,8 @@ public interface DisplayHologram<T> extends Hologram<T> {
      */
     void setAlignment(DisplayTextAlignment alignment);
 
-    /**
-     * Get the origin location.
-     * This is the location of the text display, while {@link Hologram#getLocation()} is the location of the top of the display.
-     *
-     * @return the origin location
-     */
-    T getOriginLocation();
-
-    /**
-     * Set the origin location
-     *
-     * @param originLocation the origin location
-     * @see #getOriginLocation()
-     */
-    void setOriginLocation(T originLocation);
+    @Override
+    default boolean isLocationBottom() {
+        return true;
+    }
 }

spigot/fancyholograms/src/main/java/me/hsgamer/unihologram/spigot/fancyholograms/hologram/FHHologram.java

@@ -28,15 +28,13 @@
 import java.awt.*;
 import java.util.ArrayList;
 import java.util.List;
-import java.util.Objects;
 import java.util.function.Consumer;
 import java.util.stream.Collectors;
 
 /**
  * The hologram for FancyHolograms
  */
 public class FHHologram implements me.hsgamer.unihologram.common.api.Hologram<Location>, Colored, PlayerVisibility, DisplayHologram<Location> {
-    private static final double LINE_HEIGHT = 0.25;
     private final Hologram hologram;
 
     /**
@@ -60,36 +58,6 @@ public FHHologram(Hologram hologram) {
         this.hologram = hologram;
     }
 
-    private static Location getTopLocation(Location location, float scale, int lineCount) {
-        Location newLocation = Objects.requireNonNull(location).clone();
-        newLocation.setY(newLocation.getY() + LINE_HEIGHT * scale * lineCount);
-        return newLocation;
-    }
-
-    private static Location getBottomLocation(Location location, float yScale, int lineCount) {
-        Location newLocation = Objects.requireNonNull(location).clone();
-        newLocation.setY(newLocation.getY() - LINE_HEIGHT * yScale * lineCount);
-        return newLocation;
-    }
-
-    private Location getTopLocation() {
-        return getTopLocation(hologram.getData().getLocation(), hologram.getData().getScale().y, hologram.getData().getText().size());
-    }
-
-    private void setTopLocation(Location location) {
-        hologram.getData().setLocation(getBottomLocation(location, hologram.getData().getScale().y, hologram.getData().getText().size()));
-    }
-
-    private void updateTopLocation(float yScale, int lineCount) {
-        Location topLocation = getTopLocation(hologram.getData().getLocation(), hologram.getData().getScale().y, hologram.getData().getText().size());
-        Location bottomLocation = getBottomLocation(topLocation, yScale, lineCount);
-        hologram.getData().setLocation(bottomLocation);
-    }
-
-    private void updateTopLocation(int lineCount) {
-        updateTopLocation(hologram.getData().getScale().y, lineCount);
-    }
-
     private void checkHologramInitialized() {
         Preconditions.checkArgument(isInitialized(), "Hologram is not initialized");
     }
@@ -132,7 +100,6 @@ private void editLine(Consumer<List<HologramLine>> consumer) {
         checkHologramInitialized();
         List<HologramLine> lines = new ArrayList<>(getLines());
         consumer.accept(lines);
-        updateTopLocation(lines.size());
         setLines(lines);
     }
 
@@ -178,13 +145,13 @@ public boolean isInitialized() {
     @Override
     public Location getLocation() {
         checkHologramInitialized();
-        return getTopLocation();
+        return hologram.getData().getLocation();
     }
 
     @Override
     public void setLocation(Location location) {
         checkHologramInitialized();
-        setTopLocation(location);
+        hologram.getData().setLocation(location);
         updateHologram();
     }
 
@@ -242,7 +209,6 @@ public DisplayScale getScale() {
     @Override
     public void setScale(DisplayScale scale) {
         checkHologramInitialized();
-        updateTopLocation(scale.y, hologram.getData().getText().size());
         hologram.getData().setScale(scale.x, scale.y, scale.z);
         updateHologram();
     }
@@ -350,17 +316,4 @@ public void setAlignment(DisplayTextAlignment alignment) {
         }
         updateHologram();
     }
-
-    @Override
-    public Location getOriginLocation() {
-        checkHologramInitialized();
-        return hologram.getData().getLocation();
-    }
-
-    @Override
-    public void setOriginLocation(Location originLocation) {
-        checkHologramInitialized();
-        hologram.getData().setLocation(originLocation);
-        updateHologram();
-    }
 }

spigot/test/src/main/java/me/hsgamer/unihologram/spigot/test/command/MainCommand.java

@@ -23,7 +23,6 @@ public MainCommand(UniHologramTest plugin) {
         subCommandManager.registerSubcommand(new MoveCommand(plugin));
         subCommandManager.registerSubcommand(new BackgroundColorCommand(plugin));
         subCommandManager.registerSubcommand(new BillboardCommand(plugin));
-        subCommandManager.registerSubcommand(new MoveOriginCommand(plugin));
         subCommandManager.registerSubcommand(new ScaleCommand(plugin));
         subCommandManager.registerSubcommand(new ShadowedCommand(plugin));
         subCommandManager.registerSubcommand(new ShadowRadiusCommand(plugin));