Skip to content

Commit 136af5b

Browse files
committed
Adds support of DataModel 3.0
1 parent 01b40b4 commit 136af5b

File tree

4 files changed

+21
-14
lines changed

4 files changed

+21
-14
lines changed

composer.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@
1616
],
1717
"require": {
1818
"php": ">=5.5.0",
19-
"wikibase/data-model": "~2.5",
20-
"wikibase/data-model-serialization": "~1.2",
21-
"data-values/data-values": "~1.0|~0.1",
22-
"data-values/common": "~0.2.0",
19+
"wikibase/data-model": "~3.0",
20+
"wikibase/data-model-serialization": "~1.7.0",
21+
"data-values/data-values": "~1.0",
22+
"data-values/common": "~0.3.0",
2323
"data-values/geo": "~1.0",
24-
"data-values/number": "~0.4.0",
25-
"data-values/time": "~0.6.0",
24+
"data-values/number": "~0.6.0",
25+
"data-values/time": "~0.8.0",
2626
"data-values/validators": "~0.1.0",
2727
"data-values/serialization": "~1.0",
2828
"addwiki/mediawiki-api-base": "~0.2",
@@ -31,7 +31,7 @@
3131
"symfony/config": "~2.6",
3232
"ask/ask": "~1.0",
3333
"ask/serialization": "~1.0",
34-
"ppp/wikidataquery-api": "~1.1"
34+
"ppp/wikidataquery-api": "~1.2"
3535
},
3636
"require-dev": {
3737
"squizlabs/php_codesniffer": "~2.1",

src/DataModel/SerializedEntity.php

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,13 @@ public function getId() {
4444
return $this->entityId;
4545
}
4646

47+
/**
48+
* @see EntityDocument::setId
49+
*/
50+
public function setId( $id ) {
51+
throw new InvalidArgumentException( 'Read only entity' );
52+
}
53+
4754
/**
4855
* @see EntityDocument::getType
4956
*/

tests/unit/Api/WikidataQueryItemIdForQueryLookupTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,13 +119,13 @@ public function getEntityIdsForQueryProvider() {
119119
new SomeProperty(
120120
new EntityIdValue( new PropertyId( 'P42' ) ),
121121
new ValueDescription(
122-
new TimeValue( '+00000001952-03-11T00:00:00Z', 0, 0, 0, TimeValue::PRECISION_DAY, '' )
122+
new TimeValue( '+00000001952-03-11T00:00:00Z', 0, 0, 0, TimeValue::PRECISION_DAY, 'foo' )
123123
)
124124
),
125125
new BetweenQuery(
126126
new PropertyId( 'P42' ),
127-
new TimeValue( '+00000001952-03-11T00:00:00Z', 0, 0, 0, TimeValue::PRECISION_DAY, '' ),
128-
new TimeValue( '+00000001952-03-11T00:00:00Z', 0, 0, 0, TimeValue::PRECISION_DAY, '' )
127+
new TimeValue( '+00000001952-03-11T00:00:00Z', 0, 0, 0, TimeValue::PRECISION_DAY, 'foo' ),
128+
new TimeValue( '+00000001952-03-11T00:00:00Z', 0, 0, 0, TimeValue::PRECISION_DAY, 'foo' )
129129
)
130130
],
131131
];

tests/unit/MongoDB/MongoDBEntityIdForQueryLookupTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -193,12 +193,12 @@ public function getEntityIdsForQueryProvider() {
193193
new SomeProperty(
194194
new EntityIdValue( new PropertyId( 'P42' ) ),
195195
new ValueDescription(
196-
new TimeValue( '+00000001952-03-11T00:00:00Z', 0, 0, 0, TimeValue::PRECISION_DAY, '' )
196+
new TimeValue( '+1952-03-11T00:00:00Z', 0, 0, 0, TimeValue::PRECISION_DAY, 'foo' )
197197
)
198198
),
199199
new QueryOptions( 10, 0 ),
200200
Item::ENTITY_TYPE,
201-
[ 'sclaims.time' => new MongoRegex( '/^P42\-\+00000001952\-03\-11/' ) ],
201+
[ 'sclaims.time' => new MongoRegex( '/^P42\-\+1952\-03\-11/' ) ],
202202
0,
203203
10,
204204
[ [ '_id' => 'Q1' ] ]
@@ -207,12 +207,12 @@ public function getEntityIdsForQueryProvider() {
207207
new SomeProperty(
208208
new EntityIdValue( new PropertyId( 'P42' ) ),
209209
new ValueDescription(
210-
new TimeValue( '+00000001952-00-00T00:00:00Z', 0, 0, 0, TimeValue::PRECISION_YEAR, '' )
210+
new TimeValue( '+1952-00-00T00:00:00Z', 0, 0, 0, TimeValue::PRECISION_YEAR, 'foo' )
211211
)
212212
),
213213
new QueryOptions( 10, 0 ),
214214
Item::ENTITY_TYPE,
215-
[ 'sclaims.time' => new MongoRegex( '/^P42\-\+00000001952/' ) ],
215+
[ 'sclaims.time' => new MongoRegex( '/^P42\-\+1952/' ) ],
216216
0,
217217
10,
218218
[ [ '_id' => 'Q1' ] ]

0 commit comments

Comments
 (0)