Reviewer comments

Author: chillenzer

lib/python/picongpu/picmi/grid.py

@@ -89,12 +89,8 @@ def get_as_pypicongpu(self):
             raise ValueError("Z: boundary condition not supported")
 
         g = grid.Grid3D()
-        g.cell_size_x_si = self.get_cell_size()[0]
-        g.cell_size_y_si = self.get_cell_size()[1]
-        g.cell_size_z_si = self.get_cell_size()[2]
-        g.cell_cnt_x = self.number_of_cells[0]
-        g.cell_cnt_y = self.number_of_cells[1]
-        g.cell_cnt_z = self.number_of_cells[2]
+        g.cell_size_x_si, g.cell_size_y_si, g.cell_size_z_si = self.get_cell_size()
+        g.cell_cnt_x, g.cell_cnt_y, g.cell_cnt_z = self.number_of_cells
         g.boundary_condition_x = picongpu_boundary_condition_by_picmi_id[self.lower_boundary_conditions[0]]
         g.boundary_condition_y = picongpu_boundary_condition_by_picmi_id[self.lower_boundary_conditions[1]]
         g.boundary_condition_z = picongpu_boundary_condition_by_picmi_id[self.lower_boundary_conditions[2]]

test/python/picongpu/compiling/distribution.py

@@ -93,7 +93,7 @@ def test_gaussian(self):
             sigma_rear=5.0e-6,
             power=4.0,
             factor=-1.0,
-            vacuum_front=50 * 9.07264e-5,
+            vacuum_front=50 * 9.07264e-5 / 2048,
             density=8e24,
         )
         self._compile_distribution(gaussian_dist)

test/python/picongpu/end-to-end/free_formula_density.py

@@ -39,7 +39,7 @@ def __init__(self):
         self.distributions = {
             "predefined": picmi.GaussianDistribution(**self.parameters),
             "free_form": picmi.AnalyticDistribution(
-                lambda x, y, z: self.free_form(y, cell_size_y=1.0, **self.parameters)
+                lambda x, y, z: self.free_form(y, cell_size_y=CELL_SIZE[1], **self.parameters)
             ),
         }
 
@@ -57,9 +57,9 @@ def free_form(
         factor,
     ):
         # apparently, our SI position is the centre of the cell
-        y += -0.5 * CELL_SIZE[1]
+        y += -0.5 * cell_size_y
         # The last term undoes the shift to the cell origin.
-        vacuum_y = int(vacuum_front / CELL_SIZE[1]) * CELL_SIZE[1] - 0.5 * CELL_SIZE[1]
+        vacuum_y = int(vacuum_front / cell_size_y) * cell_size_y - 0.5 * cell_size_y
 
         exponent = sympy.Piecewise(
             (sympy.Abs((y - center_front) / sigma_front), y < center_front),

test/python/picongpu/quick/pypicongpu/rendering/pmaccprinter.py

@@ -70,6 +70,9 @@
     #        "trunc": (???, "pmacc::math::trunc(x)"),
     #        "lround": (???, "pmacc::math::lround(x)"),
     #        "llround": (???, "pmacc::math::llround(x)"),
+    # Sinc can be used but isn't translated into the pmacc equivalent
+    # but the defining formula.
+    # Bessel functions are available upon request...
 }