'Cancel' for PromiseKit --

    * Delete CancellableGuarantee and all its usages
    * In PromiseKit Core: instead of using additional functions and methods with the 'CC' suffix, created a new 'cancellable' function to wrap any Promise or Guarantee
    * In the extensions: Rename methods with 'CC' suffix to 'cancellable' prefix (may revisit this)
    * Fix the CancellableCatchable 'recover' methods to properly handle cancellation errors
    * Added an 'afterTask' property to Guarantee, to keep track of the task for calls to 'after'. This way the timer can be appropriately cancelled if the returned Guarantee is passed to the new 'cancellable' function. (may revisit this)
    * Update all cancellable tests for the cancellable API changes

Author: dougzilla32

Sources/SKProductsRequest+Promise.swift

@@ -59,7 +59,7 @@ extension SKProductsRequest {
 
      - Returns: A cancellable promise that fulfills if the request succeeds.
      */
-    public func startCC(_: PMKNamespacer) -> CancellablePromise<SKProductsResponse> {
+    public func cancellableStart(_: PMKNamespacer) -> CancellablePromise<SKProductsResponse> {
         let proxy = SKDelegate()
         delegate = proxy
         proxy.retainCycle = proxy

Sources/SKReceiptRefreshRequest+Promise.swift

@@ -45,7 +45,7 @@ private class ReceiptRefreshObserver: NSObject, SKRequestDelegate, CancellableTa
 //////////////////////////////////////////////////////////// Cancellation
 
 extension SKReceiptRefreshRequest {
-    public func promiseCC() -> CancellablePromise<SKReceiptRefreshRequest> {
+    public func cancellablePromise() -> CancellablePromise<SKReceiptRefreshRequest> {
         let rro = ReceiptRefreshObserver(request: self)
         return CancellablePromise(task: rro, promise: rro.promise, resolver: rro.seal)
     }

Tests/TestStoreKit.swift

@@ -40,7 +40,7 @@ extension SKProductsRequestTests {
         let ex = expectation(description: "")
 
         let request = MockProductsRequest()
-        request.startCC(.promise).done { _ in
+        request.cancellableStart(.promise).done { _ in
             XCTFail()
         }.catch(policy: .allErrors) {
             $0.isCancelled ? ex.fulfill() : XCTFail()