Skip to content

Commit 162eff7

Browse files
authored
Merge pull request #6 from igor-makarov/master
remove usage of NSSelectorFromString to avoid app review problems
2 parents ef9d161 + 7b882d3 commit 162eff7

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

Sources/UIViewController+AnyPromise.m

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,9 @@ @interface PMKGenericDelegate : NSObject <UINavigationControllerDelegate> {
1313
+ (instancetype)delegateWithPromise:(AnyPromise **)promise;
1414
@end
1515

16-
16+
@interface UIViewController ()
17+
- (AnyPromise*) promise;
18+
@end
1719

1820
@implementation UIViewController (PromiseKit)
1921

@@ -56,7 +58,7 @@ - (AnyPromise *)promiseViewController:(UIViewController *)vc animated:(BOOL)anim
5658
}
5759

5860
if (!promise) {
59-
if (![vc respondsToSelector:NSSelectorFromString(@"promise")]) {
61+
if (![vc respondsToSelector:@selector(promise)]) {
6062
id userInfo = @{NSLocalizedDescriptionKey: @"ViewController is not promisable"};
6163
id err = [NSError errorWithDomain:PMKErrorDomain code:PMKInvalidUsageError userInfo:userInfo];
6264
return [AnyPromise promiseWithValue:err];

Tests/TestUIViewController.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ private class MockViewController: UIViewController, Promisable {
9393

9494
var appeared = false
9595

96-
private override func viewDidAppear(_ animated: Bool) {
96+
fileprivate override func viewDidAppear(_ animated: Bool) {
9797
appeared = true
9898
}
9999
}

0 commit comments

Comments
 (0)