Merge pull request #18 from rgomez90/development

Adam Warner · web-flow · commit 0dfef84823f0 · 2018-10-29T09:55:56.000Z
Check for invalid  StringSplitter maxChunk
diff --git a/Matterhook.NET.MatterhookClient/StringSplitter.cs b/Matterhook.NET.MatterhookClient/StringSplitter.cs
@@ -18,7 +18,8 @@ public class StringSplitter
         /// <returns></returns>
         public static IEnumerable<string> SplitTextIntoChunks(string str, int maxChunkSize, bool preserveWords = true)
         {
-            if (string.IsNullOrEmpty(str)) throw new ArgumentException("Text can't be null or empty",nameof(str));
+            if (string.IsNullOrEmpty(str)) throw new ArgumentException("Text can't be null or empty.", nameof(str));
+            if (maxChunkSize < 1) throw new ArgumentException("Max. chunk size must be at least 1 char.", nameof(maxChunkSize));
             if (str.Length < maxChunkSize) yield return str;
             else if (preserveWords)
             {

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,8 @@ public class StringSplitter`
`18`	`18`	`/// <returns></returns>`
`19`	`19`	`public static IEnumerable<string> SplitTextIntoChunks(string str, int maxChunkSize, bool preserveWords = true)`
`20`	`20`	`{`
`21`		`- if (string.IsNullOrEmpty(str)) throw new ArgumentException("Text can't be null or empty",nameof(str));`
	`21`	`+ if (string.IsNullOrEmpty(str)) throw new ArgumentException("Text can't be null or empty.", nameof(str));`
	`22`	`+ if (maxChunkSize < 1) throw new ArgumentException("Max. chunk size must be at least 1 char.", nameof(maxChunkSize));`
`22`	`23`	`if (str.Length < maxChunkSize) yield return str;`
`23`	`24`	`else if (preserveWords)`
`24`	`25`	`{`