Skip to content

Commit f84a983

Browse files
Merge pull request #38 from Promptly-Technologies-LLC/29-improve-contributing-page-on-documentation-website
Added guidance on code contribution and opening issues
2 parents 8971db4 + ff40f5c commit f84a983

File tree

2 files changed

+51
-11
lines changed

2 files changed

+51
-11
lines changed

docs/authentication.qmd

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ This template implements a comprehensive authentication system with security bes
3232

3333
The diagrams below show the main authentication flows.
3434

35-
### Registration and login flow
35+
## Registration and login flow
3636

3737
``` {python}
3838
#| echo: false
@@ -87,7 +87,7 @@ auth.render('static/auth_flow', format='png', cleanup=True)
8787

8888
![Registration and login flow](static/auth_flow.png)
8989

90-
### Password reset flow
90+
## Password reset flow
9191

9292
``` {python}
9393
#| echo: false

docs/contributing.qmd

Lines changed: 49 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,46 @@ title: "Contributing"
44

55
## Contributors
66

7-
Fork the repository, create a new branch, make your changes, and submit a pull request.
7+
### Opening issues and bug reports
88

9-
### Render the documentation
9+
When opening a new issue or submitting a bug report, please include:
1010

11-
The README and documentation website are rendered with [Quarto](https://quarto.org/docs/). Make changes to the `.qmd` files in the root folder and the `docs` folder. Then run the following commands to render:
11+
1. A clear, descriptive title
12+
2. For bug reports:
13+
- Description of the expected behavior
14+
- Description of the actual behavior
15+
- Steps to reproduce the issue
16+
- Version information (OS, Python version, package version)
17+
- Any relevant error messages or screenshots
18+
3. For feature requests:
19+
- Description of the proposed feature
20+
- Use case or motivation for the feature
21+
- Any implementation suggestions (optional)
22+
23+
Labels help categorize issues:
24+
- Use `bug` for reporting problems
25+
- Use `enhancement` for feature requests
26+
- Use `documentation` for documentation improvements
27+
- Use `question` for general queries
28+
29+
### Contributing code
30+
31+
To contribute code to the project:
32+
33+
1. Fork the repository and clone your fork locally
34+
2. Create a new branch from `main` with a descriptive name
35+
3. Review the [customization](https://promptlytechnologies.com/fastapi-jinja2-postgres-webapp/customization.html), [architecture](https://promptlytechnologies.com/fastapi-jinja2-postgres-webapp/architecture.html), and [authentication](https://promptlytechnologies.com/fastapi-jinja2-postgres-webapp/authentication.html) pages for guidance on design patterns and code structure and style
36+
4. Ensure all tests pass, including `mypy` type checking
37+
5. Stage, commit, and push your changes to the branch:
38+
- Use clear, descriptive commit messages
39+
- Keep commits focused and atomic
40+
6. Submit your pull request:
41+
- Provide a clear description of the changes
42+
- Link to any related issues
43+
44+
### Rendering the documentation
45+
46+
The README and documentation website are rendered with [Quarto](https://quarto.org/docs/). If you ,make changes to the `.qmd` files in the root folder and the `docs` folder, run the following commands to re-render the docs:
1247

1348
``` bash
1449
# To render the documentation website
@@ -19,17 +54,22 @@ quarto render index.qmd --output-dir . --output README.md --to gfm
1954

2055
Due to a quirk of Quarto, an unnecessary `index.html` file is created in the root folder when the README is rendered. This file can be safely deleted.
2156

57+
Note that even if your pull request is merged, your changes will not be reflected on the live website until a maintainer republishes the docs.
58+
2259
## Maintainers
2360

24-
### Increment the version
61+
### Git flow
2562

26-
Run the following command to increment the version:
63+
When creating new features,
2764

28-
``` bash
29-
poetry version patch minor
30-
```
65+
1. Open a Github issue with the label `feature` and assign it to yourself.
66+
2. Create a new branch from the issue sidebar.
67+
3. Follow the instructions in the popup to check out the branch locally and make your changes on the branch.
68+
4. Commit your changes and push to the branch.
69+
5. When you are ready to merge, open a pull request from the branch to main.
70+
6. Assign someone else for code review.
3171

32-
### Publish the documentation
72+
### Publishing the documentation
3373

3474
To publish the documentation to GitHub Pages, run the following command:
3575

0 commit comments

Comments
 (0)