Add immediate retrying on a status 0 error (#29)

* Add immediate retrying on a status 0 error

* Fix tests

* Bump version

Author: andrew-propelauth

package.json

@@ -5,7 +5,7 @@
         "type": "git",
         "url": "https://github.com/PropelAuth/javascript"
     },
-    "version": "2.0.15",
+    "version": "2.0.16",
     "keywords": [
         "auth",
         "user",

src/client.ts

@@ -1,5 +1,6 @@
 import { AuthenticationInfo, fetchAuthenticationInfo, logout } from "./api"
 import { currentTimeSeconds, getLocalStorageNumber, hasLocalStorage, hasWindow } from "./helpers"
+import {runWithRetriesOnAnyError} from "./fetch_retries";
 
 const LOGGED_IN_AT_KEY = "__PROPEL_AUTH_LOGGED_IN_AT"
 const LOGGED_OUT_AT_KEY = "__PROPEL_AUTH_LOGGED_OUT_AT"
@@ -271,7 +272,7 @@ export function createClient(authOptions: IAuthOptions): IAuthClient {
     async function forceRefreshToken(returnCached: boolean): Promise<AuthenticationInfo | null> {
         try {
             // Happy case, we fetch auth info and save it
-            const authenticationInfo = await fetchAuthenticationInfo(clientState.authUrl)
+            const authenticationInfo = await runWithRetriesOnAnyError(() => fetchAuthenticationInfo(clientState.authUrl))
             setAuthenticationInfoAndUpdateDownstream(authenticationInfo)
             return authenticationInfo
         } catch (e) {

src/fetch_retries.ts

@@ -0,0 +1,30 @@
+export const DEFAULT_RETRIES = 3
+
+export const runWithRetriesOnAnyError = async <T>(fn: () => Promise<T>): Promise<T> => {
+    return runWithRetriesInner(fn, DEFAULT_RETRIES)
+}
+
+const runWithRetriesInner = async <T>(fn: () => Promise<T>, numRetriesLeft: number): Promise<T> => {
+    try {
+        return await fn()
+    } catch (e) {
+        if (numRetriesLeft <= 0) {
+            throw e
+        }
+        await delay(numRetriesLeftToDelay(numRetriesLeft))
+        return runWithRetriesInner(fn, numRetriesLeft - 1)
+    }
+}
+
+const delay = (ms: number) => new Promise((resolve) => setTimeout(resolve, ms))
+
+const numRetriesLeftToDelay = (numRetriesLeft: number) => {
+    // We could be fancy, but we only retry 3 times so...
+    if (numRetriesLeft >= 3) {
+        return 100
+    } else if (numRetriesLeft === 2) {
+        return 200
+    } else {
+        return 300
+    }
+}

src/tests/index.test.ts

@@ -4,12 +4,15 @@
 import { createClient } from "../index"
 import { OrgIdToOrgMemberInfo } from "../org"
 import { ok, ResponseStatus, setupMockFetch, UnauthorizedResponse, UnknownErrorResponse } from "./mockfetch.test"
+import {DEFAULT_RETRIES} from "../fetch_retries";
 
 const INITIAL_TIME_MILLIS = 1619743452595
 const INITIAL_TIME_SECONDS = INITIAL_TIME_MILLIS / 1000
 
 beforeAll(() => {
     jest.useFakeTimers("modern")
+    // @ts-ignore
+    global.setTimeout = jest.fn(cb => cb());
 })
 
 beforeEach(() => {
@@ -276,8 +279,10 @@ test("client continues to use cached value if the API fails and the value hasn't
     // The API will now fail, but that failure should be logged and not effect this method
     const { mockFetch: errorMockFetch } = setupMockFetchThatReturnsUnknownError()
     const newAuthenticationInfo = await client.getAuthenticationInfoOrNull()
+
     expect(newAuthenticationInfo?.accessToken).toBe(expectedAccessToken)
-    expectCorrectEndpointWasHit(errorMockFetch, "https://www.example.com/api/v1/refresh_token")
+    const numTimesCalled = 1 + DEFAULT_RETRIES
+    expectCorrectEndpointWasHit(errorMockFetch, "https://www.example.com/api/v1/refresh_token", numTimesCalled)
 })
 
 test("client cannot use cached value if the API fails and the value has expired", async () => {
@@ -410,6 +415,7 @@ test("if a new client is created and cannot get an access token, it should trigg
 
     const post401AuthenticationInfo1 = await client1.getAuthenticationInfoOrNull()
     expect(post401AuthenticationInfo1).toBeNull()
+    jest.useRealTimers()
     const post401AuthenticationInfo0 = await client0.getAuthenticationInfoOrNull()
     expect(post401AuthenticationInfo0).toBeNull()