Merge pull request #1 from Prot10/fix/code-review-improvements

Fix/code review improvements

Author: Prot10

.gitignore

@@ -36,3 +36,7 @@ npm-debug.log*
 .env
 .env.local
 .env.*.local
+
+# Profiling
+*.profraw
+*.profdata

CLAUDE.md

@@ -78,7 +78,8 @@ MyMacCleaner/
     │   │   ├── HomebrewService.swift
     │   │   └── LocalizationManager.swift
     │   ├── Models/
-    │   │   └── ScanResult.swift
+    │   │   ├── ScanResult.swift
+    │   │   └── PermissionCategory.swift
     │   └── Extensions/
     ├── Features/
     │   ├── Home/
@@ -98,7 +99,14 @@ MyMacCleaner/
     │   ├── Performance/
     │   ├── Applications/
     │   ├── PortManagement/
-    │   └── SystemHealth/
+    │   ├── SystemHealth/
+    │   ├── StartupItems/
+    │   └── Permissions/
+    │       ├── PermissionsView.swift
+    │       ├── PermissionsViewModel.swift
+    │       └── Components/
+    │           ├── PermissionCategoryCard.swift
+    │           └── PermissionFolderRow.swift
     ├── Resources/
     │   └── Assets.xcassets/
     └── MyMacCleaner.entitlements
@@ -831,6 +839,90 @@ MyMacCleaner/
 
 ---
 
+### 2026-01-05 - Permissions Management Page & Warning Fixes
+
+**Session Goal**: Add new Permissions page for reviewing and managing folder access permissions, fix all compiler warnings
+
+**Completed**:
+
+**Permissions Management Page:**
+- Created PermissionCategory.swift data models:
+  - PermissionCategoryType enum (fullDiskAccess, userFolders, systemFolders, applicationData, startupPaths)
+  - FolderAccessInfo struct (path, displayName, status, requiresFDA, canTriggerTCCDialog)
+  - FolderAccessStatus enum (accessible, denied, notExists, checking)
+  - PermissionCategoryState struct for UI state
+- Created PermissionsViewModel.swift:
+  - buildCategories() creates all 5 category states with folder paths
+  - checkAllPermissions() tests actual read access to each folder
+  - requestFolderAccess() triggers TCC dialog for user folders
+  - revokeFolderAccess() opens appropriate System Settings pane
+  - Auto-refresh on app activation
+- Created PermissionFolderRow.swift component:
+  - Status icon (green checkmark / red X / orange ?)
+  - Folder displayName and path
+  - "Grant" button (green for TCC, blue gear for FDA)
+  - "Revoke" button (red, opens System Settings)
+- Created PermissionCategoryCard.swift:
+  - Expandable glassCard with header showing category status
+  - Lists all folders with PermissionFolderRow
+- Created PermissionsView.swift:
+  - Header with title, subtitle, and refresh button
+  - Summary card showing X/Y folders accessible
+  - Expandable category cards
+  - Auto-refresh on NSApplication.didBecomeActiveNotification
+- Updated ContentView.swift:
+  - Added NavigationSection.permissions case
+  - Icon: "lock.shield.fill", Color: Theme.Colors.permissions (indigo)
+- Updated AppState.swift:
+  - Added permissionsViewModel property
+- Updated Theme.swift:
+  - Added permissions color (indigo)
+- Updated Localizable.xcstrings:
+  - Added 25+ translation keys (EN/IT/ES) for permissions UI
+
+**Warning Fixes:**
+- Fixed AuthorizationService.swift:73,91 - "capture of 'self' with non-Sendable type"
+  - Moved escapeForAppleScript() call before async block to capture escaped string instead of self
+- Fixed SpaceLensViewModel.swift:178 - "makeIterator unavailable from async"
+  - Changed `for case let fileURL as URL in enumerator` to `while let fileURL = enumerator.nextObject() as? URL`
+- Fixed PortManagementViewModel.swift:148 - "call to actor-isolated method"
+  - Made parseLsofOutput() and parseAddressPort() nonisolated functions
+- Fixed FileScanner.swift:211,298 - "makeIterator unavailable from async"
+  - Changed both for-in loops to while-let pattern
+- Fixed AppUpdateChecker.swift:95 - "reference to captured var"
+  - Used collected.count instead of mutable captured variable
+- Fixed StartupItemsService.swift:180,520 - "call to actor-isolated method"
+  - Reordered modifiers to `private static nonisolated func` for parseBTMOutput and getCodeSigningTeam
+
+**Files Created**:
+- `MyMacCleaner/Core/Models/PermissionCategory.swift`
+- `MyMacCleaner/Features/Permissions/PermissionsView.swift`
+- `MyMacCleaner/Features/Permissions/PermissionsViewModel.swift`
+- `MyMacCleaner/Features/Permissions/Components/PermissionCategoryCard.swift`
+- `MyMacCleaner/Features/Permissions/Components/PermissionFolderRow.swift`
+
+**Files Modified**:
+- `MyMacCleaner/App/ContentView.swift` (added permissions navigation)
+- `MyMacCleaner/App/AppState.swift` (added permissionsViewModel)
+- `MyMacCleaner/Core/Design/Theme.swift` (added permissions color)
+- `MyMacCleaner/Core/Services/AuthorizationService.swift` (fixed self capture warning)
+- `MyMacCleaner/Core/Services/FileScanner.swift` (fixed makeIterator warning)
+- `MyMacCleaner/Core/Services/AppUpdateChecker.swift` (fixed captured var warning)
+- `MyMacCleaner/Core/Services/StartupItemsService.swift` (fixed actor-isolated warnings)
+- `MyMacCleaner/Features/SpaceLens/SpaceLensViewModel.swift` (fixed makeIterator warning)
+- `MyMacCleaner/Features/PortManagement/PortManagementViewModel.swift` (fixed actor-isolated warning)
+- `MyMacCleaner/Resources/Localizable.xcstrings` (added permissions translations)
+
+**Key Technical Decisions**:
+- TCC folders (Downloads, Documents, Desktop) trigger system permission dialog via FileManager.contentsOfDirectory()
+- FDA folders cannot trigger dialog programmatically - show "Open Settings" button
+- Permission revocation not possible programmatically on macOS - opens appropriate System Settings pane
+- Auto-refresh permissions when app becomes active (user returns from System Settings)
+
+**Build Status**: SUCCESS (0 warnings)
+
+---
+
 ## Constraints & Guidelines
 
 ### Code Quality

MyMacCleaner.xcodeproj/project.pbxproj

@@ -29,9 +29,22 @@
 		650DE2B32EE843C200C84519 /* MyMacCleanerUITests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = MyMacCleanerUITests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
 /* End PBXFileReference section */
 
+/* Begin PBXFileSystemSynchronizedBuildFileExceptionSet section */
+		650DE29E2EE843C000C84520 /* Exceptions for "MyMacCleaner" folder in "MyMacCleaner" target */ = {
+			isa = PBXFileSystemSynchronizedBuildFileExceptionSet;
+			membershipExceptions = (
+				Info.plist,
+			);
+			target = 650DE29A2EE843C000C84519 /* MyMacCleaner */;
+		};
+/* End PBXFileSystemSynchronizedBuildFileExceptionSet section */
+
 /* Begin PBXFileSystemSynchronizedRootGroup section */
 		650DE29D2EE843C000C84519 /* MyMacCleaner */ = {
 			isa = PBXFileSystemSynchronizedRootGroup;
+			exceptions = (
+				650DE29E2EE843C000C84520 /* Exceptions for "MyMacCleaner" folder in "MyMacCleaner" target */,
+			);
 			path = MyMacCleaner;
 			sourceTree = "<group>";
 		};

MyMacCleaner/App/ContentView.swift

@@ -48,6 +48,7 @@ enum NavigationSection: String, CaseIterable, Identifiable {
     case startupItems
     case portManagement
     case systemHealth
+    case permissions
 
     var id: String { rawValue }
 
@@ -60,6 +61,7 @@ enum NavigationSection: String, CaseIterable, Identifiable {
         case .startupItems: return "power.circle.fill"
         case .portManagement: return "network"
         case .systemHealth: return "heart.text.square.fill"
+        case .permissions: return "lock.shield.fill"
         }
     }
 
@@ -80,6 +82,7 @@ enum NavigationSection: String, CaseIterable, Identifiable {
         case .startupItems: return Theme.Colors.startup   // Yellow
         case .portManagement: return Theme.Colors.ports   // Cyan
         case .systemHealth: return Theme.Colors.health    // Red
+        case .permissions: return Theme.Colors.permissions // Indigo
         }
     }
 }
@@ -365,6 +368,8 @@ struct DetailContentView: View {
             PortManagementView(viewModel: appState.portManagementViewModel)
         case .systemHealth:
             SystemHealthView(viewModel: appState.systemHealthViewModel)
+        case .permissions:
+            PermissionsView(viewModel: appState.permissionsViewModel)
         }
     }
 }

MyMacCleaner/App/MyMacCleanerApp.swift

@@ -183,6 +183,12 @@ struct PermissionsSettingsView: View {
 }
 
 struct AboutSettingsView: View {
+    private var appVersion: String {
+        let version = Bundle.main.infoDictionary?["CFBundleShortVersionString"] as? String ?? "1.0.0"
+        let build = Bundle.main.infoDictionary?["CFBundleVersion"] as? String ?? "1"
+        return "\(version) (\(build))"
+    }
+
     var body: some View {
         VStack(spacing: 16) {
             Image(systemName: "sparkles")
@@ -192,7 +198,7 @@ struct AboutSettingsView: View {
             Text("MyMacCleaner")
                 .font(.title.bold())
 
-            Text("Version 1.0.0")
+            Text("Version \(appVersion)")
                 .foregroundStyle(.secondary)
 
             Text(String(localized: "settings.aboutDescription"))

MyMacCleaner/Core/Design/Theme.swift

@@ -35,14 +35,15 @@ enum Theme {
         static let error = Color.red
         static let info = Color.blue
 
-        // Section colors (7 distinct colors)
+        // Section colors (8 distinct colors)
         static let home = Color.blue                    // Blue
         static let storage = Color.orange               // Orange
         static let memory = Color.purple                // Purple
         static let apps = Color.green                   // Green
         static let startup = Color.yellow               // Yellow
         static let ports = Color.cyan                   // Cyan / Light Blue
         static let health = Color.red                   // Red
+        static let permissions = Color.indigo           // Indigo
     }
 
     // MARK: - Typography
@@ -105,6 +106,56 @@ enum Theme {
         static let springBouncy = SwiftUI.Animation.spring(response: 0.5, dampingFraction: 0.6)
         static let springSmooth = SwiftUI.Animation.spring(response: 0.6, dampingFraction: 0.85)
     }
+
+    // MARK: - Thresholds & Constants
+
+    enum Thresholds {
+        /// Minimum file size to include in scans (1 KB)
+        static let minimumFileSize: Int64 = 1024
+
+        /// Disk space thresholds for health warnings
+        enum DiskSpace {
+            /// Below this is critical (20 GB)
+            static let criticalFreeSpace: Int64 = 20 * 1024 * 1024 * 1024
+            /// Below this is warning (50 GB)
+            static let warningFreeSpace: Int64 = 50 * 1024 * 1024 * 1024
+        }
+
+        /// Startup items thresholds for health score
+        enum StartupItems {
+            /// Above this is warning
+            static let warningCount = 10
+            /// Above this is critical
+            static let criticalCount = 20
+        }
+
+        /// Memory usage thresholds (percentage)
+        enum Memory {
+            /// Above this is warning (80%)
+            static let warningUsage: Double = 0.80
+            /// Above this is critical (90%)
+            static let criticalUsage: Double = 0.90
+        }
+    }
+
+    // MARK: - Timing Constants
+
+    enum Timing {
+        /// Short delay for visual feedback (50ms)
+        static let visualFeedback: UInt64 = 50_000_000
+        /// Delay for progress display (80ms)
+        static let progressStep: UInt64 = 80_000_000
+        /// Medium delay (200ms)
+        static let shortPause: UInt64 = 200_000_000
+        /// Delay to show completion (300ms)
+        static let completionDisplay: UInt64 = 300_000_000
+        /// Auto-dismiss toast (3s)
+        static let toastDuration: UInt64 = 3_000_000_000
+        /// Clear results delay (5s)
+        static let clearResultsDelay: UInt64 = 5_000_000_000
+        /// Process refresh interval (seconds)
+        static let processRefreshInterval: TimeInterval = 2.0
+    }
 }
 
 // MARK: - Shadow Style

MyMacCleaner/Core/Design/ToastView.swift

@@ -1,35 +1,45 @@
 import SwiftUI
 
-// MARK: - Toast View
-
-struct ToastView: View {
-    let message: String
-    let type: HomeViewModel.ToastType
-    let onDismiss: () -> Void
+// MARK: - Shared Toast Type
 
-    @State private var isVisible = false
+/// Shared toast notification type used across all ViewModels
+/// Consolidates the previously duplicated ToastType enums
+enum ToastType: Sendable {
+    case success
+    case error
+    case info
 
     var icon: String {
-        switch type {
+        switch self {
         case .success: return "checkmark.circle.fill"
         case .error: return "xmark.circle.fill"
         case .info: return "info.circle.fill"
         }
     }
 
-    var iconColor: Color {
-        switch type {
+    var color: Color {
+        switch self {
         case .success: return .green
         case .error: return .red
         case .info: return .blue
         }
     }
+}
+
+// MARK: - Toast View
+
+struct ToastView: View {
+    let message: String
+    let type: ToastType
+    let onDismiss: () -> Void
+
+    @State private var isVisible = false
 
     var body: some View {
         HStack(spacing: Theme.Spacing.sm) {
-            Image(systemName: icon)
+            Image(systemName: type.icon)
                 .font(.title3)
-                .foregroundStyle(iconColor)
+                .foregroundStyle(type.color)
 
             Text(message)
                 .font(Theme.Typography.subheadline)
@@ -52,7 +62,7 @@ struct ToastView: View {
         )
         .overlay(
             RoundedRectangle(cornerRadius: Theme.CornerRadius.large)
-                .strokeBorder(iconColor.opacity(0.3), lineWidth: 1)
+                .strokeBorder(type.color.opacity(0.3), lineWidth: 1)
         )
         .shadow(color: .black.opacity(0.15), radius: 20, y: 10)
         .opacity(isVisible ? 1 : 0)