refactor: Improve async update checking and command escaping in services

Author: Prot10

MyMacCleaner/Core/Services/AppUpdateChecker.swift

@@ -80,24 +80,29 @@ actor AppUpdateChecker {
     func checkUpdates(for appURLs: [URL], progress: @escaping (Double) -> Void) async -> [AppUpdate] {
         var updates: [AppUpdate] = []
         let total = appURLs.count
-        var completed = 0
 
-        await withTaskGroup(of: AppUpdate?.self) { group in
+        let results = await withTaskGroup(of: AppUpdate?.self, returning: [AppUpdate?].self) { group in
             for appURL in appURLs {
                 group.addTask {
                     await self.checkSparkleUpdate(for: appURL)
                 }
             }
 
+            var collected: [AppUpdate?] = []
             for await update in group {
-                completed += 1
+                collected.append(update)
+                let currentProgress = Double(collected.count) / Double(total)
                 await MainActor.run {
-                    progress(Double(completed) / Double(total))
-                }
-                if let update = update, update.hasUpdate {
-                    updates.append(update)
+                    progress(currentProgress)
                 }
             }
+            return collected
+        }
+
+        for result in results {
+            if let update = result, update.hasUpdate {
+                updates.append(update)
+            }
         }
 
         return updates

MyMacCleaner/Core/Services/AuthorizationService.swift

@@ -67,10 +67,13 @@ final class AuthorizationService {
     // MARK: - Private Methods
 
     private func runWithAdminPrivileges(_ command: String) async -> Bool {
+        // Escape command before entering async block to avoid capturing self
+        let escapedCommand = escapeForAppleScript(command)
+
         return await withCheckedContinuation { continuation in
             DispatchQueue.global(qos: .userInitiated).async {
                 let script = """
-                do shell script "\(self.escapeForAppleScript(command))" with administrator privileges
+                do shell script "\(escapedCommand)" with administrator privileges
                 """
 
                 var error: NSDictionary?
@@ -85,10 +88,13 @@ final class AuthorizationService {
     }
 
     private func runWithAdminPrivilegesAndCapture(_ command: String) async -> String? {
+        // Escape command before entering async block to avoid capturing self
+        let escapedCommand = escapeForAppleScript(command)
+
         return await withCheckedContinuation { continuation in
             DispatchQueue.global(qos: .userInitiated).async {
                 let script = """
-                do shell script "\(self.escapeForAppleScript(command))" with administrator privileges
+                do shell script "\(escapedCommand)" with administrator privileges
                 """
 
                 var error: NSDictionary?

MyMacCleaner/Core/Services/FileScanner.swift

@@ -208,7 +208,7 @@ actor FileScanner {
             return items
         }
 
-        for case let fileURL as URL in enumerator {
+        while let fileURL = enumerator.nextObject() as? URL {
             // Check depth
             let depth = fileURL.pathComponents.count - url.pathComponents.count
             if depth > maxDepth {
@@ -295,7 +295,7 @@ actor FileScanner {
             return 0
         }
 
-        for case let fileURL as URL in enumerator {
+        while let fileURL = enumerator.nextObject() as? URL {
             guard let resourceValues = try? fileURL.resourceValues(forKeys: resourceKeys),
                   resourceValues.isDirectory == false else {
                 continue

MyMacCleaner/Core/Services/StartupItemsService.swift

@@ -188,7 +188,7 @@ actor StartupItemsService {
         }
     }
 
-    nonisolated private static func parseBTMOutput(_ output: String) -> [StartupItem] {
+    private static nonisolated func parseBTMOutput(_ output: String) -> [StartupItem] {
         var items: [StartupItem] = []
         let lines = output.components(separatedBy: "\n")
 
@@ -505,7 +505,7 @@ actor StartupItemsService {
 
                             let name = parts[0]
                             let path = parts[1]
-                            // isHidden is parsed but not used currently (parts[2])
+                            // parts[2] contains isHidden but not used currently
 
                             let item = StartupItem(
                                 id: "loginitem:\(path)",
@@ -706,7 +706,7 @@ actor StartupItemsService {
 
     // MARK: - Code Signing
 
-    nonisolated private static func getCodeSigningTeam(for path: String) -> String? {
+    private static nonisolated func getCodeSigningTeam(for path: String) -> String? {
         let process = Process()
         process.executableURL = URL(fileURLWithPath: "/usr/bin/codesign")
         process.arguments = ["-dv", "--verbose=2", path]