Skip to content

Commit f3f3efc

Browse files
Prot10claude
Prot10
and
claude
committed
fix: restore app icon with proper AppIcon.appiconset format
- The logo.icon format (macOS 26 Liquid Glass) wasn't compiling correctly - Added proper AppIcon.appiconset with all required PNG sizes - Removed update banner feature from HomeView (will revisit later) - Version bumped to 1.1.5 (build 7) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 0a7dfcf commit f3f3efc

15 files changed

Lines changed: 120 additions & 42 deletions

File tree

‎MyMacCleaner.xcodeproj/project.pbxproj‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -407,14 +407,14 @@
407407
650DE2BE2EE843C200C84519 /* Debug */ = {
408408
isa = XCBuildConfiguration;
409409
buildSettings = {
410-
ASSETCATALOG_COMPILER_APPICON_NAME = logo;
410+
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
411411
ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = AccentColor;
412412
AUTOMATION_APPLE_EVENTS = NO;
413413
CODE_SIGN_ENTITLEMENTS = MyMacCleaner/MyMacCleaner.entitlements;
414414
"CODE_SIGN_IDENTITY[sdk=macosx*]" = "Apple Development";
415415
CODE_SIGN_STYLE = Manual;
416416
COMBINE_HIDPI_IMAGES = YES;
417-
CURRENT_PROJECT_VERSION = 6;
417+
CURRENT_PROJECT_VERSION = 7;
418418
DEVELOPMENT_TEAM = "";
419419
"DEVELOPMENT_TEAM[sdk=macosx*]" = 7K4SKUHU47;
420420
ENABLE_HARDENED_RUNTIME = YES;
@@ -434,7 +434,7 @@
434434
"$(inherited)",
435435
"@executable_path/../Frameworks",
436436
);
437-
MARKETING_VERSION = 1.1.4;
437+
MARKETING_VERSION = 1.1.5;
438438
PRODUCT_BUNDLE_IDENTIFIER = com.mymaccleaner.MyMacCleaner;
439439
PRODUCT_NAME = "$(TARGET_NAME)";
440440
PROVISIONING_PROFILE_SPECIFIER = "";
@@ -453,14 +453,14 @@
453453
650DE2BF2EE843C200C84519 /* Release */ = {
454454
isa = XCBuildConfiguration;
455455
buildSettings = {
456-
ASSETCATALOG_COMPILER_APPICON_NAME = logo;
456+
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
457457
ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = AccentColor;
458458
AUTOMATION_APPLE_EVENTS = NO;
459459
CODE_SIGN_ENTITLEMENTS = MyMacCleaner/MyMacCleaner.entitlements;
460460
"CODE_SIGN_IDENTITY[sdk=macosx*]" = "Developer ID Application";
461461
CODE_SIGN_STYLE = Manual;
462462
COMBINE_HIDPI_IMAGES = YES;
463-
CURRENT_PROJECT_VERSION = 6;
463+
CURRENT_PROJECT_VERSION = 7;
464464
DEVELOPMENT_TEAM = "";
465465
"DEVELOPMENT_TEAM[sdk=macosx*]" = 7K4SKUHU47;
466466
ENABLE_HARDENED_RUNTIME = YES;
@@ -480,7 +480,7 @@
480480
"$(inherited)",
481481
"@executable_path/../Frameworks",
482482
);
483-
MARKETING_VERSION = 1.1.4;
483+
MARKETING_VERSION = 1.1.5;
484484
PRODUCT_BUNDLE_IDENTIFIER = com.mymaccleaner.MyMacCleaner;
485485
PRODUCT_NAME = "$(TARGET_NAME)";
486486
PROVISIONING_PROFILE_SPECIFIER = "";
@@ -501,10 +501,10 @@
501501
buildSettings = {
502502
BUNDLE_LOADER = "$(TEST_HOST)";
503503
CODE_SIGN_STYLE = Automatic;
504-
CURRENT_PROJECT_VERSION = 6;
504+
CURRENT_PROJECT_VERSION = 7;
505505
GENERATE_INFOPLIST_FILE = YES;
506506
MACOSX_DEPLOYMENT_TARGET = 14.0;
507-
MARKETING_VERSION = 1.1.4;
507+
MARKETING_VERSION = 1.1.5;
508508
PRODUCT_BUNDLE_IDENTIFIER = com.mymaccleaner.MyMacCleanerTests;
509509
PRODUCT_NAME = "$(TARGET_NAME)";
510510
SWIFT_EMIT_LOC_STRINGS = NO;
@@ -518,10 +518,10 @@
518518
buildSettings = {
519519
BUNDLE_LOADER = "$(TEST_HOST)";
520520
CODE_SIGN_STYLE = Automatic;
521-
CURRENT_PROJECT_VERSION = 6;
521+
CURRENT_PROJECT_VERSION = 7;
522522
GENERATE_INFOPLIST_FILE = YES;
523523
MACOSX_DEPLOYMENT_TARGET = 14.0;
524-
MARKETING_VERSION = 1.1.4;
524+
MARKETING_VERSION = 1.1.5;
525525
PRODUCT_BUNDLE_IDENTIFIER = com.mymaccleaner.MyMacCleanerTests;
526526
PRODUCT_NAME = "$(TARGET_NAME)";
527527
SWIFT_EMIT_LOC_STRINGS = NO;
@@ -534,9 +534,9 @@
534534
isa = XCBuildConfiguration;
535535
buildSettings = {
536536
CODE_SIGN_STYLE = Automatic;
537-
CURRENT_PROJECT_VERSION = 6;
537+
CURRENT_PROJECT_VERSION = 7;
538538
GENERATE_INFOPLIST_FILE = YES;
539-
MARKETING_VERSION = 1.1.4;
539+
MARKETING_VERSION = 1.1.5;
540540
PRODUCT_BUNDLE_IDENTIFIER = com.mymaccleaner.MyMacCleanerUITests;
541541
PRODUCT_NAME = "$(TARGET_NAME)";
542542
SWIFT_EMIT_LOC_STRINGS = NO;
@@ -549,9 +549,9 @@
549549
isa = XCBuildConfiguration;
550550
buildSettings = {
551551
CODE_SIGN_STYLE = Automatic;
552-
CURRENT_PROJECT_VERSION = 6;
552+
CURRENT_PROJECT_VERSION = 7;
553553
GENERATE_INFOPLIST_FILE = YES;
554-
MARKETING_VERSION = 1.1.4;
554+
MARKETING_VERSION = 1.1.5;
555555
PRODUCT_BUNDLE_IDENTIFIER = com.mymaccleaner.MyMacCleanerUITests;
556556
PRODUCT_NAME = "$(TARGET_NAME)";
557557
SWIFT_EMIT_LOC_STRINGS = NO;

‎MyMacCleaner/Features/Home/HomeView.swift‎

Lines changed: 5 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,10 @@ import SwiftUI
22

33
struct HomeView: View {
44
@ObservedObject var viewModel: HomeViewModel
5-
@Environment(UpdateManager.self) var updateManager
65
@State private var isVisible = false
76

87
private let sectionColor = Theme.Colors.home
98

10-
/// Base animation index that accounts for optional banners above the main content
11-
private var baseAnimationIndex: Int {
12-
var index = 1 // Start after header
13-
if updateManager.updateAvailable && !updateManager.updateDismissed { index += 1 }
14-
if !viewModel.hasFullDiskAccess && !viewModel.showPermissionPrompt { index += 1 }
15-
return index
16-
}
17-
189
var body: some View {
1910
ZStack {
2011
ScrollView {
@@ -23,26 +14,15 @@ struct HomeView: View {
2314
headerSection
2415
.staggeredAnimation(index: 0, isActive: isVisible)
2516

26-
// Update banner (if update available)
27-
if updateManager.updateAvailable && !updateManager.updateDismissed,
28-
let version = updateManager.availableVersion {
29-
UpdateBanner(updateManager: updateManager, availableVersion: version)
30-
.staggeredAnimation(index: 1, isActive: isVisible)
31-
.transition(.asymmetric(
32-
insertion: .push(from: .top),
33-
removal: .push(from: .bottom)
34-
))
35-
}
36-
3717
// Permission banner (if needed)
3818
if !viewModel.hasFullDiskAccess && !viewModel.showPermissionPrompt {
3919
PermissionBanner(permissionsService: PermissionsService.shared)
40-
.staggeredAnimation(index: updateManager.updateAvailable ? 2 : 1, isActive: isVisible)
20+
.staggeredAnimation(index: 1, isActive: isVisible)
4121
}
4222

4323
// Smart Scan Button
4424
smartScanSection
45-
.staggeredAnimation(index: baseAnimationIndex, isActive: isVisible)
25+
.staggeredAnimation(index: 2, isActive: isVisible)
4626

4727
// Scan Results (if available)
4828
if viewModel.showScanResults {
@@ -53,16 +33,16 @@ struct HomeView: View {
5333
print("View details for \(result.category.rawValue)")
5434
}
5535
)
56-
.staggeredAnimation(index: baseAnimationIndex + 1, isActive: isVisible)
36+
.staggeredAnimation(index: 3, isActive: isVisible)
5737
}
5838

5939
// Quick Stats
6040
quickStatsSection
61-
.staggeredAnimation(index: viewModel.showScanResults ? baseAnimationIndex + 2 : baseAnimationIndex + 1, isActive: isVisible)
41+
.staggeredAnimation(index: viewModel.showScanResults ? 4 : 3, isActive: isVisible)
6242

6343
// Quick Actions
6444
quickActionsSection
65-
.staggeredAnimation(index: viewModel.showScanResults ? baseAnimationIndex + 3 : baseAnimationIndex + 2, isActive: isVisible)
45+
.staggeredAnimation(index: viewModel.showScanResults ? 5 : 4, isActive: isVisible)
6646
}
6747
.padding(Theme.Spacing.lg)
6848
}
@@ -114,8 +94,6 @@ struct HomeView: View {
11494
.animation(Theme.Animation.springSmooth, value: viewModel.showPermissionPrompt)
11595
.animation(Theme.Animation.springSmooth, value: viewModel.isCleaning)
11696
.animation(Theme.Animation.spring, value: viewModel.showToast)
117-
.animation(Theme.Animation.spring, value: updateManager.updateDismissed)
118-
.animation(Theme.Animation.spring, value: updateManager.updateAvailable)
11997
.onAppear {
12098
withAnimation(Theme.Animation.springSmooth) {
12199
isVisible = true

‎MyMacCleaner/Resources/Assets.xcassets/AppIcon.appiconset/Contents.json‎

Lines changed: 68 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,68 @@
1+
{
2+
"images" : [
3+
{
4+
"filename" : "icon_16x16.png",
5+
"idiom" : "mac",
6+
"scale" : "1x",
7+
"size" : "16x16"
8+
},
9+
{
10+
"filename" : "icon_16x16@2x.png",
11+
"idiom" : "mac",
12+
"scale" : "2x",
13+
"size" : "16x16"
14+
},
15+
{
16+
"filename" : "icon_32x32.png",
17+
"idiom" : "mac",
18+
"scale" : "1x",
19+
"size" : "32x32"
20+
},
21+
{
22+
"filename" : "icon_32x32@2x.png",
23+
"idiom" : "mac",
24+
"scale" : "2x",
25+
"size" : "32x32"
26+
},
27+
{
28+
"filename" : "icon_128x128.png",
29+
"idiom" : "mac",
30+
"scale" : "1x",
31+
"size" : "128x128"
32+
},
33+
{
34+
"filename" : "icon_128x128@2x.png",
35+
"idiom" : "mac",
36+
"scale" : "2x",
37+
"size" : "128x128"
38+
},
39+
{
40+
"filename" : "icon_256x256.png",
41+
"idiom" : "mac",
42+
"scale" : "1x",
43+
"size" : "256x256"
44+
},
45+
{
46+
"filename" : "icon_256x256@2x.png",
47+
"idiom" : "mac",
48+
"scale" : "2x",
49+
"size" : "256x256"
50+
},
51+
{
52+
"filename" : "icon_512x512.png",
53+
"idiom" : "mac",
54+
"scale" : "1x",
55+
"size" : "512x512"
56+
},
57+
{
58+
"filename" : "icon_512x512@2x.png",
59+
"idiom" : "mac",
60+
"scale" : "2x",
61+
"size" : "512x512"
62+
}
63+
],
64+
"info" : {
65+
"author" : "xcode",
66+
"version" : 1
67+
}
68+
}

‎MyMacCleaner/Resources/Assets.xcassets/AppIcon.appiconset/icon_128x128.png‎

11.2 KB
Loading

‎MyMacCleaner/Resources/Assets.xcassets/AppIcon.appiconset/icon_128x128@2x.png‎

28 KB
Loading

‎MyMacCleaner/Resources/Assets.xcassets/AppIcon.appiconset/icon_16x16.png‎

874 Bytes
Loading

‎MyMacCleaner/Resources/Assets.xcassets/AppIcon.appiconset/icon_16x16@2x.png‎

1.77 KB
Loading

‎MyMacCleaner/Resources/Assets.xcassets/AppIcon.appiconset/icon_256x256.png‎

28 KB
Loading

‎MyMacCleaner/Resources/Assets.xcassets/AppIcon.appiconset/icon_256x256@2x.png‎

76.3 KB
Loading

‎MyMacCleaner/Resources/Assets.xcassets/AppIcon.appiconset/icon_32x32.png‎

1.77 KB
Loading

0 commit comments

Comments
 (0)