Make Issuer Key ID subpacket non-critical (#175)

caarlos0 · web-flow · commit 7e9e0395ebec · 2023-06-26T11:41:00.000+02:00
Fix signature verification in RPM versions prior to 4.17.
diff --git a/openpgp/packet/signature.go b/openpgp/packet/signature.go
@@ -904,7 +904,7 @@ func (sig *Signature) buildSubpackets(issuer PublicKey) (subpackets []outputSubp
 	if sig.IssuerKeyId != nil && sig.Version == 4 {
 		keyId := make([]byte, 8)
 		binary.BigEndian.PutUint64(keyId, *sig.IssuerKeyId)
-		subpackets = append(subpackets, outputSubpacket{true, issuerSubpacket, true, keyId})
+		subpackets = append(subpackets, outputSubpacket{true, issuerSubpacket, false, keyId})
 	}
 	if sig.IssuerFingerprint != nil {
 		contents := append([]uint8{uint8(issuer.Version)}, sig.IssuerFingerprint...)

Original file line number	Diff line number	Diff line change
`@@ -904,7 +904,7 @@ func (sig *Signature) buildSubpackets(issuer PublicKey) (subpackets []outputSubp`
`904`	`904`	`if sig.IssuerKeyId != nil && sig.Version == 4 {`
`905`	`905`	`keyId := make([]byte, 8)`
`906`	`906`	`binary.BigEndian.PutUint64(keyId, *sig.IssuerKeyId)`
`907`		`- subpackets = append(subpackets, outputSubpacket{true, issuerSubpacket, true, keyId})`
	`907`	`+ subpackets = append(subpackets, outputSubpacket{true, issuerSubpacket, false, keyId})`
`908`	`908`	`}`
`909`	`909`	`if sig.IssuerFingerprint != nil {`
`910`	`910`	`contents := append([]uint8{uint8(issuer.Version)}, sig.IssuerFingerprint...)`