add retries to submitTransaction

Author: christianwwwwwwww

sdk/src/network-client.ts

@@ -126,6 +126,18 @@ class AleoNetworkClient {
         }
     }
 
+
+    /**
+     * Wrapper around the POST helper to allow mocking in tests.
+     *
+     * @param url The URL to POST to.
+     * @param options The RequestInit options for the POST request.
+     * @returns The Response object from the POST request.
+     */
+    private async sendPost(url: string, options: RequestInit) {
+      return post(url, options);
+    }    
+
     /**
      * Attempt to find records in the Aleo blockchain.
      *
@@ -1347,12 +1359,13 @@ class AleoNetworkClient {
                 ? transaction.toString()
                 : transaction;
         try {
-            const response = await post(this.host + "/transaction/broadcast", {
-                body: transaction_string,
-                headers: Object.assign({}, this.headers, {
-                    "Content-Type": "application/json",
-                }),
-            });
+          const response = await retryWithBackoff(() =>
+            this.sendPost(this.host + "/transaction/broadcast", {
+              body: transaction_string,
+              headers: Object.assign({}, this.headers, {
+                "Content-Type": "application/json",
+              }),
+            }));
 
             try {
                 const text = await response.text();

sdk/tests/network-client.test.ts

@@ -18,6 +18,7 @@ import {
     TransitionObject,
 } from "@provablehq/sdk/%%NETWORK%%.js";
 import { beaconPrivateKeyString } from "./data/account-data";
+import * as utils from "../src/utils";
 
 async function catchError(f: () => Promise<any>): Promise<Error | null> {
     try {
@@ -234,6 +235,27 @@ describe("NodeConnection", () => {
             expect(attemptCount).to.be.greaterThan(1);
           }
         });
+      
+        it("should retry failed transaction submissions and eventually give up", async () => {
+            const client = new AleoNetworkClient("http://localhost:1234");
+          
+            let attemptCount = 0;
+          
+            // @ts-ignore override for testing
+            client["sendPost"] = async () => {
+              attemptCount++;
+              console.warn(`fake sendPost attempt ${attemptCount}`);
+              throw new Error("503 Service Unavailable");
+            };
+          
+            try {
+              await client.submitTransaction("dummy_tx_string");
+              throw new Error("Expected submitTransaction to fail");
+            } catch (err: any) {
+              expect(err.message).to.include("503");
+              expect(attemptCount).to.be.greaterThan(1);
+            }
+          });
       });