wait for tx confirmation

Author: christianwwwwwwww

sdk/src/network-client.ts

@@ -961,24 +961,46 @@ class AleoNetworkClient {
    * @param {string} solution The string representation of the solution desired to be submitted to the network.
    */
   async waitForTransactionConfirmation(
-      transactionId: string,
-      checkInterval: number = 2000,  // Poll every 2 seconds
-      timeout: number = 45000        // Timeout after 45 seconds
-  ): Promise<Transaction> {
+    transactionId: string,
+    checkInterval: number = 2000,
+    timeout: number = 45000
+  ): Promise<"accepted" | "rejected"> {
     const startTime = Date.now();
-
-    return new Promise<Transaction>((resolve, reject) => {
+  
+    return new Promise((resolve, reject) => {
       const interval = setInterval(async () => {
+        const elapsed = Date.now() - startTime;
+  
+        if (elapsed > timeout) {
+          clearInterval(interval);
+          return reject(new Error("Transaction confirmation timed out"));
+        }
+  
         try {
-          // Replace with actual Aleo transaction lookup API
-          const transaction = <Transaction>await this.getTransactionObject(transactionId);
-          resolve(transaction);
-          if (Date.now() - startTime > timeout) {
+          const res = await fetch(`https://api.explorer.provable.com/v1/mainnet/transaction/confirmed/${transactionId}`);
+        
+          if (!res.ok) {
+            const text = await res.text();
+            console.error("Non-OK response:", res.status, text);
+            clearInterval(interval);
+            return reject(new Error(`HTTP ${res.status}: ${text}`));
+          }
+          
+          const data = await res.json();
+        
+          if (data?.status === "accepted") {
+            clearInterval(interval);
+            return resolve("accepted");
+          }
+        
+          if (data?.status === "rejected") {
             clearInterval(interval);
-            reject(new Error("Transaction confirmation timed out"));
+            return resolve("rejected");
           }
-        } catch (error) {
-          console.error("Error checking transaction:", error);
+        
+          // no status? keep polling
+        } catch (err) {
+          console.error("Polling error:", err);
         }
       }, checkInterval);
     });

sdk/tests/network-client.test.ts

@@ -198,6 +198,27 @@ describe('NodeConnection', () => {
         });
     });
 
+    describe('waitForTransactionConfirmation', () => {
+        it('should return accepted for a valid tx ID', async () => {
+          const connection = new AleoNetworkClient("https://api.explorer.provable.com/");
+          const status = await connection.waitForTransactionConfirmation("at1dl9lze8wscct0dee8x9tjnfmpjvj33hh23jcnp5f0ywjn5552yrsperzl9");
+          expect(status).to.equal("accepted");
+        });
+
+        it('should return rejected for a rejected tx ID', async () => {
+          const connection = new AleoNetworkClient("https://api.explorer.provable.com/");
+          const status = await connection.waitForTransactionConfirmation("at1x5ed0pyjpt3770e0m60psvdvqeww5z5f32t7velrmrjfhvzgysxqll4g6a");
+          expect(status).to.equal("rejected");
+        });
+      
+        it('should throw for an invalid tx ID', async () => {
+          const connection = new AleoNetworkClient("https://api.explorer.provable.com/");
+          await expectThrows(() =>
+            connection.waitForTransactionConfirmation("at1dl9lze8wscct0dee8x9tjnfmpj12345678jcnp5f0ywjn5552yrsperzl9")
+          );
+        });
+      });
+      
     describe('findUnspentRecords', () => {
         it('should fail if block heights or private keys are incorrectly specified', async () => {
             await expectThrows(
@@ -395,3 +416,4 @@ describe('NodeConnection', () => {
         });
     })
 });
+