address comments and add tests

Author: christianwwwwwwww

sdk/src/network-client.ts

@@ -138,17 +138,18 @@ class AleoNetworkClient {
      */
     async fetchData<Type>(url = "/"): Promise<Type> {
       try {
-          return await retryWithBackoff(() => this.fetchRaw(url).then(parseJSON), {
-              retryOnStatus: [500, 502, 503, 504],
-              shouldRetry: (err) => {
-                  const msg = err?.message?.toLowerCase?.() || "";
-                  return msg.includes("network") || msg.includes("timeout") || msg.includes("503");
-              }
-          });
+        const raw = await retryWithBackoff(() => this.fetchRaw(url), {
+          retryOnStatus: [500, 502, 503, 504],
+          shouldRetry: (err) => {
+            const msg = err?.message?.toLowerCase?.() || "";
+            return msg.includes("network") || msg.includes("timeout") || msg.includes("503");
+          }
+        });
+        return parseJSON(raw);
       } catch (error) {
-          throw new Error(`Error fetching data: ${error}`);
+        throw new Error(`Error fetching data: ${error}`);
       }
-  }
+    }
 
 
     /**
@@ -400,7 +401,7 @@ class AleoNetworkClient {
                                                               // Attempt to see if the serial number is spent
                                                               try {
                                                                   await retryWithBackoff(() => this.getTransitionId(serialNumber), {
-                                                                      retryOnStatus: [500, 502, 503],
+                                                                      retryOnStatus: [500, 502, 503, 504],
                                                                       shouldRetry: (err) => {
                                                                           const msg = err?.message?.toLowerCase?.() || "";
                                                                           return msg.includes("timeout") || msg.includes("503") || msg.includes("network");

sdk/tests/network-client.test.ts

@@ -18,7 +18,7 @@ import {
     TransitionObject,
 } from "@provablehq/sdk/%%NETWORK%%.js";
 import { beaconPrivateKeyString } from "./data/account-data";
-import * as utils from "../src/utils";
+import { retryWithBackoff } from "../src/utils";
 
 async function catchError(f: () => Promise<any>): Promise<Error | null> {
     try {
@@ -237,24 +237,52 @@ describe("NodeConnection", () => {
         });
 
         it("should retry failed transaction submissions and eventually give up", async () => {
-          const client = new AleoNetworkClient("http://localhost:1234");
-      
-          let attemptCount = 0;
-      
-          // @ts-ignore override for testing
-          client["sendPost"] = async () => {
+            const client = new AleoNetworkClient("http://localhost:1234");
+          
+            let attemptCount = 0;
+          
+            client["sendPost"] = async () => {
+              attemptCount++;
+              console.warn(`fake sendPost attempt ${attemptCount}`);
+              const error = new Error("503 Service Unavailable") as any;
+              error.status = 503;
+              throw error;
+            };
+          
+            try {
+              await retryWithBackoff(() =>
+                client["sendPost"]("http://fakeurl", { method: "POST" }), {
+                  retryOnStatus: [503],
+                }
+              );
+              throw new Error("Expected retryWithBackoff to fail");
+            } catch (err: any) {
+              expect(err.message).to.include("503");
+              expect(attemptCount).to.be.greaterThan(1);
+            }
+          });
+
+        it("should retry solution submission and eventually throw", async () => {
+        const client = new AleoNetworkClient("http://localhost:1234");
+
+        let attemptCount = 0;
+
+        client["sendPost"] = async function () {
             attemptCount++;
-            console.warn(`fake sendPost attempt ${attemptCount}`);
-            throw Object.assign(new Error("503 Service Unavailable"), { status: 503 });
-          };
-      
-          try {
-            await client.submitTransaction("dummy_tx_string");
-            throw new Error("Expected submitTransaction to fail");
-          } catch (err: any) {
-            expect(err.message).to.include("503");
+            throw Object.assign(new Error("Network error"), { status: 503 });
+        };
+
+        try {
+            await retryWithBackoff(() =>
+            client["sendPost"]("http://fakeurl", { method: "POST" }), {
+                retryOnStatus: [503],
+            }
+            );
+            throw new Error("Expected sendPost to fail");
+        } catch (err: any) {
+            expect(err.message).to.include("Network error");
             expect(attemptCount).to.be.greaterThan(1);
-          }
+        }
         });
       });