refactor waitForTransactionConfirmation return + test updates

Author: christianwwwwwwww

sdk/src/network-client.ts

@@ -1201,7 +1201,7 @@ class AleoNetworkClient {
     transactionId: string,
     checkInterval: number = 2000,
     timeout: number = 45000
-  ): Promise<"accepted" | "rejected"> {
+  ): Promise<ConfirmedTransactionJSON> {
     const startTime = Date.now();
 
     return new Promise((resolve, reject) => {
@@ -1236,16 +1236,16 @@ class AleoNetworkClient {
             return;
           }
 
-          const data = await res.json();
-        
+          const text = await res.text();
+          const data = parseJSON(text);          
           if (data?.status === "accepted") {
             clearInterval(interval);
-            return resolve("accepted");
+            return resolve(data);
           }
 
           if (data?.status === "rejected") {
             clearInterval(interval);
-            return resolve("rejected");
+            return reject(new Error(`Transaction ${transactionId} was rejected by the network`));
           }
 
           // no status? keep polling

sdk/tests/network-client.test.ts

@@ -214,18 +214,23 @@ describe('NodeConnection', () => {
             : (isTestnet ? testnetRejectedTx : mainnetRejectedTx);
         }
 
-        it('should return accepted for a valid tx ID', async () => {
+        it('should return confirmed transaction data for an accepted tx ID', async () => {
           const connection = new AleoNetworkClient(host);
           const txId = getTxId(connection, "accepted");
-          const status = await connection.waitForTransactionConfirmation(txId);
-          expect(status).to.equal("accepted");
+          const data = await connection.waitForTransactionConfirmation(txId);
+          expect(data.status).to.equal("accepted");
+          expect(data.type).to.be.a("string");
         });
 
-        it('should return rejected for a rejected tx ID', async () => {
+        it('should throw for a rejected tx ID', async () => {
           const connection = new AleoNetworkClient(host);
           const txId = getTxId(connection, "rejected");
-          const status = await connection.waitForTransactionConfirmation(txId);
-          expect(status).to.equal("rejected");
+          try {
+            await connection.waitForTransactionConfirmation(txId);
+            throw new Error("Expected waitForTransactionConfirmation to throw for rejected tx");
+          } catch (err: any) {
+            expect(err.message).to.include("was rejected by the network");
+          }
         });
 
         it('should throw for a malformed tx ID', async () => {