handle malformed txs and and not yet present txs

Author: christianwwwwwwww

sdk/src/network-client.ts

@@ -1218,9 +1218,16 @@ class AleoNetworkClient {
 
           if (!res.ok) {
             const text = await res.text();
-            console.error("Non-OK response:", res.status, text);
-            clearInterval(interval);
-            return reject(new Error(`HTTP ${res.status}: ${text}`));
+          
+            // Break early if the response indicates an invalid format
+            if (res.status >= 400 && res.status < 500 && text.includes("Invalid URL")) {
+              clearInterval(interval);
+              return reject(new Error(`Malformed transaction ID: ${text}`));
+            }
+          
+            // Log and continue polling for 404s or 5XX errors in case a tx doesn't exist yet
+            console.warn("Non-OK response (retrying):", res.status, text);
+            return;
           }
 
           const data = await res.json();

sdk/tests/network-client.test.ts

@@ -211,12 +211,16 @@ describe('NodeConnection', () => {
           expect(status).to.equal("rejected");
         });
 
-        it('should throw for an invalid tx ID', async () => {
-          const connection = new AleoNetworkClient("https://api.explorer.provable.com/");
-          await expectThrows(() =>
-            connection.waitForTransactionConfirmation("at1dl9lze8wscct0dee8x9tjnfmpj12345678jcnp5f0ywjn5552yrsperzl9")
-          );
-        });
+        it('should throw for a malformed tx ID', async () => {
+            const connection = new AleoNetworkClient("https://api.explorer.provable.com/");
+            try {
+              await connection.waitForTransactionConfirmation("at1dl9lze8wscct0dee8x9tjnfmpj12345678jcnp5f0ywjn5552yrsperzl9");
+              throw new Error("Expected waitForTransactionConfirmation to throw");
+            } catch (err: any) {
+              expect(err.message).to.include("Malformed transaction ID");
+              expect(err.message).to.include("Invalid URL");
+            }
+          });
       });
 
     describe('findUnspentRecords', () => {