Skip to content

Commit ed88ed7

Browse files
committed
fixed doc strings, generate_record_view_key() method name, and punctuation
1 parent 3fab502 commit ed88ed7

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

wasm/src/utilities/encrypt.rs

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ pub struct EncryptionToolkit;
4141

4242
#[wasm_bindgen]
4343
impl EncryptionToolkit {
44-
/// Returns the number of field elements required to decrypt an Entry
44+
/// Returns the number of field elements required to decrypt an Entry.
4545
pub(crate) fn num_entry_randomizers(entry: &CiphertextEntryNative) -> Result<u16, String> {
4646
match entry {
4747
// Constant and public entries do not need to be encrypted.
@@ -87,6 +87,7 @@ impl EncryptionToolkit {
8787
// Initialize an index to keep track of the randomizer index.
8888
let mut index: usize = 0;
8989

90+
// Get the reference of the native record.
9091
let record_native = &**record;
9192

9293
// Decrypt the owner.
@@ -149,8 +150,8 @@ impl EncryptionToolkit {
149150

150151
/// Creates a record view key from the view key. This method is intended to be used
151152
/// by the record owner to enable decryption of a select record by a third party.
152-
#[wasm_bindgen(js_name = "generateRecordVk")]
153-
pub fn generate_record_vk(view_key: &ViewKey, record_ciphertext: &RecordCiphertext) -> Result<Field, String> {
153+
#[wasm_bindgen(js_name = "generateRecordViewkey")]
154+
pub fn generate_record_view_key(view_key: &ViewKey, record_ciphertext: &RecordCiphertext) -> Result<Field, String> {
154155
let record_nonce = record_ciphertext.nonce();
155156
Ok(record_nonce.scalar_multiply(&view_key.to_scalar()).to_x_coordinate())
156157
}
@@ -187,14 +188,14 @@ mod tests {
187188
use std::str::FromStr;
188189
use wasm_bindgen_test::wasm_bindgen_test;
189190

191+
const NON_OWNER_VIEW_KEY: &str = "AViewKey1e2WyreaH5H4RBcioLL2GnxvHk5Ud46EtwycnhTdXLmXp";
192+
const OWNER_CIPHERTEXT: &str = "record1qyqsqpe2szk2wwwq56akkwx586hkndl3r8vzdwve32lm7elvphh37rsyqyxx66trwfhkxun9v35hguerqqpqzqrtjzeu6vah9x2me2exkgege824sd8x2379scspmrmtvczs0d93qttl7y92ga0k0rsexu409hu3vlehe3yxjhmey3frh2z5pxm5cmxsv4un97q";
190193
const OWNER_PLAINTEXT: &str = r"{
191194
owner: aleo1j7qxyunfldj2lp8hsvy7mw5k8zaqgjfyr72x2gh3x4ewgae8v5gscf5jh3.private,
192195
microcredits: 1500000000000000u64.private,
193196
_nonce: 3077450429259593211617823051143573281856129402760267155982965992208217472983group.public
194197
}";
195-
const OWNER_CIPHERTEXT: &str = "record1qyqsqpe2szk2wwwq56akkwx586hkndl3r8vzdwve32lm7elvphh37rsyqyxx66trwfhkxun9v35hguerqqpqzqrtjzeu6vah9x2me2exkgege824sd8x2379scspmrmtvczs0d93qttl7y92ga0k0rsexu409hu3vlehe3yxjhmey3frh2z5pxm5cmxsv4un97q";
196198
const OWNER_VIEW_KEY: &str = "AViewKey1ccEt8A2Ryva5rxnKcAbn7wgTaTsb79tzkKHFpeKsm9NX";
197-
const NON_OWNER_VIEW_KEY: &str = "AViewKey1e2WyreaH5H4RBcioLL2GnxvHk5Ud46EtwycnhTdXLmXp";
198199
const RECORD_TAG: &str = "1796466189545157638691489609907096471289658804813960182690905095269699169603field";
199200

200201
#[wasm_bindgen_test]
@@ -203,7 +204,7 @@ mod tests {
203204
let owner_view_key = ViewKey::from_str(OWNER_VIEW_KEY).unwrap();
204205

205206
// Generate the record view key
206-
let record_vk = EncryptionToolkit::generate_record_vk(&owner_view_key, &owner_ciphertext).unwrap();
207+
let record_vk = EncryptionToolkit::generate_record_view_key(&owner_view_key, &owner_ciphertext).unwrap();
207208

208209
// Decrypt with the owner's view key
209210
let record_plaintext_decrypted =
@@ -217,7 +218,7 @@ mod tests {
217218
let non_owner_view_key = ViewKey::from_str(NON_OWNER_VIEW_KEY).unwrap();
218219

219220
// Generate the record view key with a non-owner view key
220-
let record_vk = EncryptionToolkit::generate_record_vk(&non_owner_view_key, &owner_ciphertext).unwrap();
221+
let record_vk = EncryptionToolkit::generate_record_view_key(&non_owner_view_key, &owner_ciphertext).unwrap();
221222

222223
// Attempt to decrypt with the non-owner's view key
223224
let result = EncryptionToolkit::decrypt_record_symmetric_unchecked(&record_vk, &owner_ciphertext);

0 commit comments

Comments
 (0)