-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Open
Description
💥 Proposal
Currently, the ledger folder contains the following (when using the snarkos start --storage flag`:
- public ledger data
.current-proposal-cache*cached_*_peersjwt_secret_*.txt
Issues:
- if a node operator recovers from a local or remote snapshot, they are likely to overwrite the entire ledger folder
- if you don't use
--storage,StorageMode::Productionis used, causing more confusingly different behaviour: the.current-proposal-cache*will then be created in the parent directory of the ledger.
Proposal:
- We create a new
--storage-local-stateflag (name t.b.d.) which stores 2./3./4. , making it explicit these cannot be recovered without backup, and should not be overwritten by an external snapshot - We ensure both
StorageMode::ProductionandStorageMode::Customwrite the appropriate files to this new folder. - Consider renaming
current-proposal-cacheto e.g..current-active-proposal
Design goals:
- Need to manually test all different storage modes
- Backwards compatible?
- Only make the new flag required for validators from the next release
- If you don't pass it, log a warning but use the old way of doing things
Metadata
Metadata
Assignees
Labels
No labels