Skip to content

Commit 968fba6

Browse files
authored
Merge pull request #3175 from ProvableHQ/fix_ci
Fix CI
2 parents d99207e + 1460259 commit 968fba6

File tree

7 files changed

+79
-10
lines changed

7 files changed

+79
-10
lines changed

.circleci/config.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -930,7 +930,7 @@ jobs:
930930
timeout: 30m # test_vm_execute_and_finalize can take over 10 minutes in the current setup
931931
no_output_timeout: 20m
932932
workspace_member: snarkvm-synthesizer
933-
flags: --test '*' --features test -- --test-threads=4
933+
flags: --test '*' --features test,dev-print -- --test-threads=4
934934
cache_key_suffix: -integration
935935

936936
synthesizer-process:
@@ -972,7 +972,7 @@ jobs:
972972
steps:
973973
- run_test:
974974
workspace_member: snarkvm-synthesizer-program
975-
flags: keccak
975+
flags: keccak -- --test-threads=4
976976
timeout: 30m
977977
no_output_timeout: 20m
978978
cache_key_suffix: -integration-keccak
@@ -992,7 +992,7 @@ jobs:
992992
steps:
993993
- run_test:
994994
workspace_member: snarkvm-synthesizer-program
995-
flags: sha
995+
flags: sha -- --test-threads=4
996996
timeout: 30m
997997
no_output_timeout: 20m
998998
cache_key_suffix: -integration-sha
@@ -1275,7 +1275,7 @@ workflows:
12751275
or pipeline.git.branch == "canary"
12761276
or pipeline.git.branch == "testnet"
12771277
or pipeline.git.branch == "mainnet"
1278-
or pipeline.git.branch == "feat/identifier-literal"
1278+
or pipeline.git.branch == "fix_ci"
12791279
jobs:
12801280
- check-unused-dependencies # This can be cleaned up before releases
12811281
- check-cargo-semver-checks # This can be cleaned up before releases

Cargo.lock

Lines changed: 44 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

synthesizer/Cargo.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -206,5 +206,9 @@ version = "0.9"
206206
[dev-dependencies.tempfile]
207207
workspace = true
208208

209+
[dev-dependencies.test-log]
210+
version = "0.2"
211+
features = [ "trace" ]
212+
209213
[dev-dependencies.walkdir]
210214
version = "2"

synthesizer/src/vm/finalize.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ impl<N: Network, C: ConsensusStorage<N>> VM<N, C> {
8989
.filter_map(|tx_id| {
9090
unordered_aborted_transaction_ids.get(&tx_id).map(|error| {
9191
warn!("Speculation safely aborted a transaction - {error} ({tx_id})");
92+
dev_eprintln!("Speculation safely aborted a transaction - {error} ({tx_id})");
9293
tx_id
9394
})
9495
})

synthesizer/tests/expectations/vm/execute_and_finalize/self_caller_and_signer_in_closure.out

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,21 @@ outputs:
44
execute:
55
self_caller_in_closure.aleo/dummy:
66
outputs:
7-
- '{"type":"private","id":"2216227416503041347433412034872956491846811102146440372685849103494739704020field","value":"ciphertext1qyqya6k83s309kj2l82tj5fr80n7e7w7t56ff72ug8ueqhqzevn2vys72rsev"}'
7+
- '{"type":"private","id":"1126549371219261677622135540139100244763419767422514369520585148590831448189field","value":"ciphertext1qyqzpsfrwmgjth29h3z5kkjy4rdnx2cjuur6j2h00zvc2td3teelvrsmequh8"}'
8+
speculate: the execution was accepted
9+
add_next_block: succeeded.
10+
- verified: true
11+
execute:
12+
self_caller_in_closure.aleo/run_check:
13+
outputs: []
814
speculate: the execution was accepted
915
add_next_block: succeeded.
10-
- execute: 'Failed to execute instruction (call check_caller self.caller;): Failed to evaluate instruction (assert.eq self.caller r0 ;): Caller address (console) is not set in the registers.'
1116
additional:
1217
- child_outputs:
1318
credits.aleo/fee_public:
1419
outputs:
15-
- '{"type":"future","id":"7718771598168275830568214808516419506185731287938173896061440207543931919734field","value":"{\n program_id: credits.aleo,\n function_name: fee_public,\n arguments: [\n aleo1gj8900ftrtm5gpjljk9tuv8tmr46m88s5dvugdx8hnmftvpfv5rqempqfd,\n 1334u64\n ]\n}"}'
16-
- {}
20+
- '{"type":"future","id":"494259290164722817317909876873778317197296441822796709748776683471356290260field","value":"{\n program_id: credits.aleo,\n function_name: fee_public,\n arguments: [\n aleo1gj8900ftrtm5gpjljk9tuv8tmr46m88s5dvugdx8hnmftvpfv5rqempqfd,\n 1334u64\n ]\n}"}'
21+
- child_outputs:
22+
credits.aleo/fee_public:
23+
outputs:
24+
- '{"type":"future","id":"7125087701862650478091264713412629351672029968343630145355670167713923010292field","value":"{\n program_id: credits.aleo,\n function_name: fee_public,\n arguments: [\n aleo1gj8900ftrtm5gpjljk9tuv8tmr46m88s5dvugdx8hnmftvpfv5rqempqfd,\n 1161u64\n ]\n}"}'

synthesizer/tests/test_vm_execute_and_finalize.rs

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ type LedgerType = snarkvm_ledger_store::helpers::memory::ConsensusMemory<Current
4848
type LedgerType = snarkvm_ledger_store::helpers::rocksdb::ConsensusDB<CurrentNetwork>;
4949

5050
#[test]
51+
#[test_log::test]
5152
fn test_vm_execute_and_finalize() {
5253
// Load the tests.
5354
let tests =
@@ -155,7 +156,11 @@ fn run_test(test: &ProgramTest) -> serde_yaml::Mapping {
155156
rng,
156157
)
157158
.unwrap();
158-
assert!(aborted_transaction_ids.is_empty());
159+
if !aborted_transaction_ids.is_empty() {
160+
// Print the program ID that was aborted.
161+
println!("Aborted program deployment: {:?}", program.id());
162+
assert!(aborted_transaction_ids.is_empty());
163+
}
159164

160165
let block = construct_next_block(
161166
&vm,
@@ -347,7 +352,11 @@ fn run_test(test: &ProgramTest) -> serde_yaml::Mapping {
347352
return (serde_yaml::Value::Mapping(result), serde_yaml::Value::Mapping(Default::default()));
348353
}
349354
};
350-
assert!(aborted_transaction_ids.is_empty());
355+
if !aborted_transaction_ids.is_empty() {
356+
// Print the function that was aborted.
357+
println!("Aborted call to {program_id}/{function_name}");
358+
assert!(aborted_transaction_ids.is_empty());
359+
}
351360

352361
// Construct the next block.
353362
let block = construct_next_block(

synthesizer/tests/tests/vm/execute_and_finalize/self_caller_and_signer_in_closure.aleo

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,3 +28,6 @@ function dummy:
2828
input r1 as u32.private;
2929
add r0 r1 into r2;
3030
output r2 as u32.private;
31+
32+
constructor:
33+
assert.eq edition 0u16;

0 commit comments

Comments
 (0)