Merge pull request #3173 from ProvableHQ/ensure_records_are_linked

Ensure records exist

Author: vicsn

.circleci/config.yml

@@ -90,7 +90,7 @@ commands:
     parameters:
       cache_key:
         type: string
-        default: v4.5.1-rust-1.88.0-snarkvm-cache
+        default: v4.6.0-rust-1.88.0-snarkvm-cache
     steps:
       - run:
           name: Prepare environment variables and install dependencies
@@ -134,8 +134,8 @@ commands:
               clang llvm-dev llvm lld pkg-config xz-utils make libssl-dev libssl-dev
       - restore_cache:
           keys:
-            - v4.5.1-rust-1.88.0-deps-{{ checksum "Cargo.lock" }}-
-            - v4.5.1-rust-1.88.0-deps-
+            - v4.6.0-rust-1.88.0-deps-{{ checksum "Cargo.lock" }}-
+            - v4.6.0-rust-1.88.0-deps-
       - restore_cache:
           keys:
             - << parameters.cache_key >>
@@ -145,11 +145,11 @@ commands:
     parameters:
       cache_key:
         type: string
-        default: v4.5.1-rust-1.88.0-snarkvm-cache
+        default: v4.6.0-rust-1.88.0-snarkvm-cache
     steps:
       - run: set +e
       - save_cache:
-          key: v4.5.1-rust-1.88.0-deps-{{ checksum "Cargo.lock" }}
+          key: v4.6.0-rust-1.88.0-deps-{{ checksum "Cargo.lock" }}
           paths:
             - /home/circleci/.cache/sccache
             - /home/circleci/.cargo/registry
@@ -188,7 +188,7 @@ commands:
           condition: << parameters.use_cache >>
           steps:
             - setup_environment:
-                cache_key: v4.5.1-rust-1.88.0-<< parameters.workspace_member >><< parameters.cache_key_suffix >>-cache
+                cache_key: v4.6.0-rust-1.88.0-<< parameters.workspace_member >><< parameters.cache_key_suffix >>-cache
 
       - run:
           name: Install debian packages (always)
@@ -436,7 +436,7 @@ commands:
           condition: << parameters.use_cache >>
           steps:
             - clear_environment:
-                cache_key: v4.5.1-rust-1.88.0-<< parameters.workspace_member >><< parameters.cache_key_suffix >>-cache
+                cache_key: v4.6.0-rust-1.88.0-<< parameters.workspace_member >><< parameters.cache_key_suffix >>-cache
 
   install_rust_nightly:
     description: "Install Rust nightly toolchain"
@@ -1054,7 +1054,7 @@ jobs:
     steps:
       - checkout
       - setup_environment:
-          cache_key: v4.5.1-rust-1.88.0-snarkvm-wasm-cache
+          cache_key: v4.6.0-rust-1.88.0-snarkvm-wasm-cache
       - run:
           no_output_timeout: 30m
           command: |
@@ -1075,7 +1075,7 @@ jobs:
             # Run the tests
             cd wasm && wasm-pack test --node
       - clear_environment:
-          cache_key: v4.5.1-rust-1.88.0-snarkvm-wasm-cache
+          cache_key: v4.6.0-rust-1.88.0-snarkvm-wasm-cache
 
   check-fmt:
     executor: rust-docker
@@ -1084,21 +1084,21 @@ jobs:
       - checkout
       - install_rust_nightly
       - setup_environment:
-          cache_key: v4.5.1-rust-1.88.0-snarkvm-fmt-cache
+          cache_key: v4.6.0-rust-1.88.0-snarkvm-fmt-cache
       - run:
           name: Check style
           no_output_timeout: 35m
           command: cargo +nightly fmt --all -- --check
       - clear_environment:
-          cache_key: v4.5.1-rust-1.88.0-snarkvm-fmt-cache
+          cache_key: v4.6.0-rust-1.88.0-snarkvm-fmt-cache
 
   check-unused-dependencies:
     executor: rust-docker
     resource_class: << pipeline.parameters.medium >>
     steps:
       - checkout
       - setup_environment:
-          cache_key: v4.5.1-rust-1.88.0-machete-cache
+          cache_key: v4.6.0-rust-1.88.0-machete-cache
       - run:
           name: Check for unused dependencies
           no_output_timeout: 10m
@@ -1109,23 +1109,23 @@ jobs:
             fi
             cargo machete
       - clear_environment:
-          cache_key: v4.5.1-rust-1.88.0-machete-cache
+          cache_key: v4.6.0-rust-1.88.0-machete-cache
 
   check-cargo-audit:
     executor: rust-docker
     resource_class: << pipeline.parameters.medium >>
     steps:
       - checkout
       - setup_environment:
-          cache_key: v4.5.1-rust-1.88.0-cargo-audit-cache
+          cache_key: v4.6.0-rust-1.88.0-cargo-audit-cache
       - run:
           name:  Check for security vulnerabilities
           no_output_timeout: 10m
           command: |
             cargo install cargo-audit@0.22.0 --locked --force
             cargo audit -D warnings
       - clear_environment:
-          cache_key: v4.5.1-rust-1.88.0-cargo-audit-cache
+          cache_key: v4.6.0-rust-1.88.0-cargo-audit-cache
 
   check-cargo-semver-checks:
     executor: rust-docker
@@ -1134,22 +1134,22 @@ jobs:
       - checkout:
           method: full
       - setup_environment:
-          cache_key: v4.5.1-rust-1.88.0-cargo-semver-checks-cache
+          cache_key: v4.6.0-rust-1.88.0-cargo-semver-checks-cache
       - run:
           name: Check for semver violations
           no_output_timeout: 15m
           command: |
             bash ./.circleci/semver-checks.sh
       - clear_environment:
-          cache_key: v4.5.1-rust-1.88.0-cargo-semver-checks-cache
+          cache_key: v4.6.0-rust-1.88.0-cargo-semver-checks-cache
 
   check-clippy:
     executor: rust-docker
     resource_class: << pipeline.parameters.xlarge >>
     steps:
       - checkout
       - setup_environment:
-          cache_key: v4.5.1-rust-1.88.0-snarkvm-clippy-cache
+          cache_key: v4.6.0-rust-1.88.0-snarkvm-clippy-cache
       - run:
           name: Check Clippy (default features)
           timeout: 20m
@@ -1161,21 +1161,21 @@ jobs:
           command: |
             cargo clippy --workspace --all-targets --all-features -- -D warnings
       - clear_environment:
-          cache_key: v4.5.1-rust-1.88.0-snarkvm-clippy-cache
+          cache_key: v4.6.0-rust-1.88.0-snarkvm-clippy-cache
 
   check-all-targets:
     executor: rust-docker
     resource_class: << pipeline.parameters.small >>
     steps:
       - checkout
       - setup_environment:
-          cache_key: v4.5.1-rust-1.88.0-snarkvm-all-targets-cache
+          cache_key: v4.6.0-rust-1.88.0-snarkvm-all-targets-cache
       - run:
           name: Check all targets
           no_output_timeout: 35m
           command: cargo check --release --workspace --all-targets
       - clear_environment:
-          cache_key: v4.5.1-rust-1.88.0-snarkvm-all-targets-cache
+          cache_key: v4.6.0-rust-1.88.0-snarkvm-all-targets-cache
 
   verify-windows:
     executor:
@@ -1280,6 +1280,7 @@ workflows:
       or pipeline.git.branch == "testnet"
       or pipeline.git.branch == "mainnet"
       or pipeline.git.branch == "feat/dynamic-dispatch"
+      or pipeline.git.branch == "reduce_ci_cost"
     jobs:
       - check-unused-dependencies # This can be cleaned up before releases
       - check-cargo-semver-checks # This can be cleaned up before releases

console/collections/Cargo.toml

@@ -52,5 +52,6 @@ workspace = true
 
 [features]
 serial = [ ]
+test-utils = [ ]
 locktick = [ "dep:locktick" ]
 timer = [ "aleo-std/timer" ]

console/collections/src/merkle_tree/mod.rs

@@ -36,6 +36,20 @@ use std::{collections::BTreeMap, mem};
 #[cfg(not(feature = "serial"))]
 use rayon::prelude::*;
 
+/// A binary Merkle tree constructed with a leaf-digest hash function and a
+/// two-to-one compressing hash function.
+///
+/// If the number of leaves is less than `2**DEPTH`, the leaf layer is first
+/// padded to the next power of 2 with the empty-hash value `e` returned by the
+/// implementation of `PathHash::hash_empty()` for `PH`, then a balanced binary
+/// tree is built. In concrete terms, at most one `e` leaf is added: the rest
+/// are only virtual in that instead nodes with the value `PH::hash_children(e,
+/// e)` are added to the next level, which is indeed full of size equal to a
+/// power of 2.
+///
+/// Padding levels are then added as needed to reach the full `DEPTH`, each of
+/// which is constructed by hashing the root of the previous level together with
+/// `e`.
 #[derive(Deserialize, Serialize)]
 #[serde(bound = "E: Serialize + DeserializeOwned, LH: Serialize + DeserializeOwned, PH: Serialize + DeserializeOwned")]
 pub struct MerkleTree<E: Environment, LH: LeafHash<Hash = PH::Hash>, PH: PathHash<Hash = Field<E>>, const DEPTH: u8> {

console/network/src/consensus_heights.rs

@@ -54,6 +54,8 @@ pub enum ConsensusVersion {
     ///      Introduces `aleo::GENERATOR`, `aleo::GENERATOR_POWERS`, `snark.verify` opcodes,
     ///      and dynamic dispatch, and identifier literal types.
     V14 = 14,
+    /// V15: Introduces the record-existence check.
+    V15 = 15,
 }
 
 impl ToBytes for ConsensusVersion {
@@ -80,6 +82,7 @@ impl FromBytes for ConsensusVersion {
             12 => Ok(Self::V12),
             13 => Ok(Self::V13),
             14 => Ok(Self::V14),
+            15 => Ok(Self::V15),
             _ => Err(io_error("Invalid consensus version")),
         }
     }
@@ -117,6 +120,7 @@ pub const CANARY_V0_CONSENSUS_VERSION_HEIGHTS: [(ConsensusVersion, u32); NUM_CON
     (ConsensusVersion::V12, 10_030_000),
     (ConsensusVersion::V13, 10_881_000),
     (ConsensusVersion::V14, u32::MAX),
+    (ConsensusVersion::V15, u32::MAX),
 ];
 
 /// The consensus version height for `MainnetV0`.
@@ -135,6 +139,7 @@ pub const MAINNET_V0_CONSENSUS_VERSION_HEIGHTS: [(ConsensusVersion, u32); NUM_CO
     (ConsensusVersion::V12, 13_815_000),
     (ConsensusVersion::V13, 16_850_000),
     (ConsensusVersion::V14, u32::MAX),
+    (ConsensusVersion::V15, u32::MAX),
 ];
 
 /// The consensus version heights for `TestnetV0`.
@@ -153,6 +158,7 @@ pub const TESTNET_V0_CONSENSUS_VERSION_HEIGHTS: [(ConsensusVersion, u32); NUM_CO
     (ConsensusVersion::V12, 12_669_000),
     (ConsensusVersion::V13, 14_906_000),
     (ConsensusVersion::V14, u32::MAX),
+    (ConsensusVersion::V15, u32::MAX),
 ];
 
 /// The consensus version heights when the `test_consensus_heights` feature is enabled.
@@ -171,6 +177,7 @@ pub const TEST_CONSENSUS_VERSION_HEIGHTS: [(ConsensusVersion, u32); NUM_CONSENSU
     (ConsensusVersion::V12, 15),
     (ConsensusVersion::V13, 16),
     (ConsensusVersion::V14, 17),
+    (ConsensusVersion::V15, 18),
 ];
 
 #[cfg(any(test, feature = "test", feature = "test_consensus_heights"))]

console/program/src/data_types/plaintext_type/mod.rs

@@ -57,6 +57,7 @@ impl<N: Network> PlaintextType<N> {
             PlaintextType::Struct(name) => PlaintextType::ExternalStruct(Locator::new(id, name)),
             PlaintextType::Array(array_type) => {
                 let element_type = array_type.next_element_type().clone().qualify(id);
+                // Safe: the length is preserved from the original array type.
                 PlaintextType::Array(ArrayType::new(element_type, vec![*array_type.length()]).unwrap())
             }
         }

synthesizer/process/src/lib.rs

@@ -69,24 +69,30 @@ use snarkvm_ledger_block::{Deployment, DeploymentVersion, Execution, Fee, Input,
 use snarkvm_ledger_store::{FinalizeStorage, FinalizeStore, atomic_batch_scope};
 use snarkvm_synthesizer_program::{
     Branch,
+    CastType,
     Command,
     FinalizeGlobalState,
     FinalizeOperation,
     Function,
     Instruction,
+    Operand,
     Program,
     StackTrait,
 };
 use snarkvm_synthesizer_snark::{ProvingKey, UniversalSRS, VerifyingKey};
 use snarkvm_utilities::{defer, dev_println};
 
 use aleo_std::prelude::{finish, lap, timer};
-use indexmap::IndexMap;
+use indexmap::{IndexMap, IndexSet};
+
 #[cfg(feature = "locktick")]
 use locktick::parking_lot::RwLock;
 #[cfg(not(feature = "locktick"))]
 use parking_lot::RwLock;
-use std::{collections::HashMap, sync::Arc};
+use std::{
+    collections::{HashMap, HashSet},
+    sync::Arc,
+};
 
 // Note: a `Process` and all of its fields are meant to be completely stateless. They have no
 // notion of block height or consensus version.

synthesizer/process/src/stack/execute.rs

@@ -14,7 +14,6 @@
 // limitations under the License.
 
 use super::*;
-use snarkvm_synthesizer_error::*;
 
 impl<N: Network> Stack<N> {
     /// Executes a program closure on the given inputs.
@@ -544,6 +543,10 @@ impl<N: Network> Stack<N> {
         // Eject the response.
         let response = response.eject_value();
 
+        if response.outputs().len() != output_types.len() {
+            return Err(anyhow!("Number of outputs does not match number of output types").into());
+        }
+
         // Ensure the outputs matches the expected value types.
         response.outputs().iter().zip_eq(&output_types).try_for_each(|(output, output_type)| {
             // Ensure the output matches its expected type.

synthesizer/process/src/stack/mod.rs

@@ -70,6 +70,7 @@ use console::{
     types::{Field, Group},
 };
 use snarkvm_ledger_block::{Deployment, Transaction, Transition};
+use snarkvm_synthesizer_error::*;
 use snarkvm_synthesizer_program::{
     CallOperator,
     Closure,

synthesizer/process/src/stack/register_types/initialize.rs

@@ -45,10 +45,10 @@ impl<N: Network> RegisterTypes<N> {
         // Step 3. Check the outputs are well-formed.
         for output in closure.outputs() {
             // Ensure the closure output register is not a static record.
-            // Dynamic records are allowed as closure outputs.
+            // ExternalRecord and DynamicRecord are disallowed at V15+ deployment time (see `VM::check_transaction`).
             ensure!(
                 !matches!(output.register_type(), RegisterType::Record(..)),
-                "Closure outputs do not support static records"
+                "Closure outputs do not support records"
             );
 
             // Check the output operand type.

synthesizer/process/src/trace/translation/assignment.rs

@@ -76,7 +76,7 @@ pub struct TranslationAssignment<N: Network> {
     /// Irrelevant if `is_to_static` is false or `is_external_record` is true.
     pub(crate) gamma: Option<Group<N>>,
     /// Index of the input operand or output destination that contains the (dynamic and static) record.
-    /// Note: The first three dynamic.call operands are reserved for call-related data,
+    /// Note: The first three call.dynamic operands are reserved for call-related data,
     /// however this operand index still starts at 0 and is the same for caller and callee.
     pub(crate) record_register_index: u16,
     /// The ID of the dynamic record.