fix(file-provider): self-review fixes — DateFormatter locale/tz, guard refactor, docstring

- Add locale=en_US_POSIX and timeZone=UTC to DateFormatter in FileProviderItem.filename
  for saveStateFile to ensure deterministic filenames regardless of user locale/timezone
- Refactor loadAllSaveStateEntries guard chain to single guard (eliminates intermediate URL? var)
- Update FileProviderEnumerator class docstring to include Save States and Screenshots categories

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: 2 people

Extensions/ROM File Provider/FileProviderEnumerator.swift

@@ -14,8 +14,11 @@ import PVPrimitives
 
 /// Enumerates items in the Provenance ROM library for the Files.app file provider.
 ///
-/// Root lists category folders (**Systems**, **Publishers**, **Years**, **Regions**, **Ratings**).
+/// Root lists category folders (**Systems**, **Publishers**, **Years**, **Regions**, **Ratings**,
+/// **Save States**, **Screenshots**).
 /// Canonical ROM files (`game:<md5>`) live only under **Systems**; other axes use symlink rows.
+/// Save states (`ss-game:<md5>` / `ss:<id>`) and screenshots (`sc-game:<md5>` / `sc:<md5>:<index>`)
+/// are enumerated read-only from their respective virtual folders.
 ///
 /// Realm access is centralized in ``RomFileProviderLibrary`` (CPDI snapshots, same App Group as Spotlight / Top Shelf).
 final class FileProviderEnumerator: NSObject, NSFileProviderEnumerator {

Extensions/ROM File Provider/FileProviderItem.swift

@@ -252,6 +252,8 @@ final class FileProviderItem: NSObject, NSFileProviderItem {
             if let name = fileURL?.lastPathComponent, !name.isEmpty { return sanitize(name) }
             let label = isAutosave ? "Auto" : (userDescription ?? "")
             let formatter = DateFormatter()
+            formatter.locale = Locale(identifier: "en_US_POSIX")
+            formatter.timeZone = TimeZone(secondsFromGMT: 0)
             formatter.dateFormat = "yyyy-MM-dd HH-mm-ss"
             let dateStr = formatter.string(from: date)
             let prefix = label.isEmpty ? dateStr : "\(label) \(dateStr)"

Extensions/ROM File Provider/RomFileProviderCPDI.swift

@@ -131,14 +131,9 @@ enum RomFileProviderLibrary {
     static func loadAllSaveStateEntries() -> [SaveStateEntry] {
         realm.objects(PVSaveState.self).compactMap { pvSS -> SaveStateEntry? in
             guard !pvSS.isInvalidated,
-                  let pvGame = pvSS.game, !pvGame.isInvalidated else { return nil }
-            let fileURL: URL?
-            if let pvFile = pvSS.file, let url = pvFile.url,
-               FileManager.default.fileExists(atPath: url.path) {
-                fileURL = url
-            } else {
-                return nil
-            }
+                  let pvGame = pvSS.game, !pvGame.isInvalidated,
+                  let pvFile = pvSS.file, let fileURL = pvFile.url,
+                  FileManager.default.fileExists(atPath: fileURL.path) else { return nil }
             return SaveStateEntry(
                 id: pvSS.id,
                 game: pvGame.asDomain(),