pce/pcecd/ra RA core fix didRelease calling didPress

Signed-off-by: Joseph Mattiello <git@joemattiello.com>

Author: JoeMatt

CoresRetro/RetroArch/PVRetroArchCore/Core/PVRetroArchCore+Controls+PCE.m

@@ -47,26 +47,24 @@ - (void)didMovePCEJoystickDirection:(PVPCEButton)button withValue:(CGFloat)value
     [self handlePCEButton:button forPlayer:player pressed:(value != 0) value:value];
 }
 - (void)handlePCEButton:(PVPCEButton)button forPlayer:(NSInteger)player pressed:(BOOL)pressed value:(CGFloat)value {
+    static float xAxis=0;
+    static float yAxis=0;
 
     switch (button) {
         case(PVPCEButtonUp):
-            yAxis = pressed ? 1.0 :0;
-            DLOG(@"Pressed %@ : %@", @"up", pressed ? @"Yes" : @"No");
+            yAxis=pressed?(!xAxis?1.0:0.5):0;
             [touch_controller.extendedGamepad.dpad setValueForXAxis:xAxis yAxis:yAxis];
             break;
         case(PVPCEButtonDown):
-            yAxis = pressed ? -1.0 :0;
-            DLOG(@"Pressed %@ : %@", @"down", pressed ? @"Yes" : @"No");
+            yAxis=pressed?(!xAxis?-1.0:-0.5):0;
             [touch_controller.extendedGamepad.dpad setValueForXAxis:xAxis yAxis:yAxis];
             break;
         case(PVPCEButtonLeft):
-            xAxis = pressed ? -1.0 :0;
-            DLOG(@"Pressed %@ : %@", @"left", pressed ? @"Yes" : @"No");
+            xAxis=pressed?(!yAxis?-1.0:-0.5):0;
             [touch_controller.extendedGamepad.dpad setValueForXAxis:xAxis yAxis:yAxis];
             break;
         case(PVPCEButtonRight):
-            xAxis = pressed ? 1.0 :0;
-            DLOG(@"Pressed %@ : %@", @"right", pressed ? @"Yes" : @"No");
+            xAxis=pressed?(!yAxis?1.0:0.5):0;
             [touch_controller.extendedGamepad.dpad setValueForXAxis:xAxis yAxis:yAxis];
             break;
         case(PVPCEButtonButton1):

CoresRetro/RetroArch/PVRetroArchCore/Core/PVRetroArchCore+Controls+PCECD.m

@@ -36,37 +36,35 @@ @interface PVRetroArchCoreBridge (PCEControls) <PVPCECDSystemResponderClient>
 @implementation PVRetroArchCoreBridge (PCEControls)
 #pragma mark - Control
 - (void)didPushPCECDButton:(PVPCECDButton)button forPlayer:(NSInteger)player {
-    [self handlePCEButton:button forPlayer:player pressed:true value:1];
+    [self handlePCECDButton:button forPlayer:player pressed:true value:1];
 }
 
 - (void)didReleasePCECDButton:(PVPCECDButton)button forPlayer:(NSInteger)player {
-    [self handlePCEButton:button forPlayer:player pressed:false value:0];
+    [self handlePCECDButton:button forPlayer:player pressed:false value:0];
 }
 
 - (void)didMovePCECDJoystickDirection:(PVPCECDButton)button withValue:(CGFloat)value forPlayer:(NSInteger)player {
-    [self handlePCEButton:button forPlayer:player pressed:(value != 0) value:value];
+    [self handlePCECDButton:button forPlayer:player pressed:(value != 0) value:value];
 }
-- (void)handlePCEButton:(PVPCECDButton)button forPlayer:(NSInteger)player pressed:(BOOL)pressed value:(CGFloat)value {
+- (void)handlePCECDButton:(PVPCECDButton)button forPlayer:(NSInteger)player pressed:(BOOL)pressed value:(CGFloat)value {
+    static float xAxis=0;
+    static float yAxis=0;
 
     switch (button) {
         case(PVPCECDButtonUp):
-            yAxis = pressed ? 1.0 :0;
-            DLOG(@"Pressed %@ : %@", @"up", pressed ? @"Yes" : @"No");
+            yAxis=pressed?(!xAxis?1.0:0.5):0;
             [touch_controller.extendedGamepad.dpad setValueForXAxis:xAxis yAxis:yAxis];
             break;
         case(PVPCECDButtonDown):
-            yAxis = pressed ? -1.0 :0;
-            DLOG(@"Pressed %@ : %@", @"down", pressed ? @"Yes" : @"No");
+            yAxis=pressed?(!xAxis?-1.0:-0.5):0;
             [touch_controller.extendedGamepad.dpad setValueForXAxis:xAxis yAxis:yAxis];
             break;
         case(PVPCECDButtonLeft):
-            xAxis = pressed ? -1.0 :0;
-            DLOG(@"Pressed %@ : %@", @"left", pressed ? @"Yes" : @"No");
+            xAxis=pressed?(!yAxis?-1.0:-0.5):0;
             [touch_controller.extendedGamepad.dpad setValueForXAxis:xAxis yAxis:yAxis];
             break;
         case(PVPCECDButtonRight):
-            xAxis = pressed ? 1.0 :0;
-            DLOG(@"Pressed %@ : %@", @"right", pressed ? @"Yes" : @"No");
+            xAxis=pressed?(!yAxis?1.0:0.5):0;
             [touch_controller.extendedGamepad.dpad setValueForXAxis:xAxis yAxis:yAxis];
             break;
         case(PVPCECDButtonButton1):

CoresRetro/RetroArch/PVRetroArchCore/Swift/PVRetroArchCoreCore.swift

@@ -421,7 +421,7 @@ extension PVRetroArchCoreCore: PVPCESystemResponderClient {
     }
 
     public func didRelease(_ button: PVCoreBridge.PVPCEButton, forPlayer player: Int) {
-        (_bridge as! PVPCESystemResponderClient).didPush(button, forPlayer: player)
+        (_bridge as! PVPCESystemResponderClient).didRelease(button, forPlayer: player)
     }
 }
 
@@ -432,7 +432,7 @@ extension PVRetroArchCoreCore: PVPCECDSystemResponderClient {
     }
 
     public func didRelease(_ button: PVCoreBridge.PVPCECDButton, forPlayer player: Int) {
-        (_bridge as! PVPCECDSystemResponderClient).didPush(button, forPlayer: player)
+        (_bridge as! PVPCECDSystemResponderClient).didRelease(button, forPlayer: player)
     }
 }
 
@@ -443,7 +443,7 @@ extension PVRetroArchCoreCore: PVPCFXSystemResponderClient {
     }
 
     public func didRelease(_ button: PVCoreBridge.PVPCFXButton, forPlayer player: Int) {
-        (_bridge as! PVPCFXSystemResponderClient).didPush(button, forPlayer: player)
+        (_bridge as! PVPCFXSystemResponderClient).didRelease(button, forPlayer: player)
     }
 }
 

PVUI/Sources/PVUIBase/SwiftUI/DeltaSkins/Models/DeltaSkinInputHandler.swift

@@ -1326,7 +1326,7 @@ public class DeltaSkinInputHandler: ObservableObject {
                 return true
             } else {
                 ELOG("Core expcted to be `PVPCESystemResponderClient` but isn't.")
-                return false
+                //return false
             }
         case .PCECD:
             if let r = core as? PVPCECDSystemResponderClient {
@@ -1339,7 +1339,7 @@ public class DeltaSkinInputHandler: ObservableObject {
                 return true
             } else {
                 ELOG("Core expcted to be `PVPCECDSystemResponderClient` but isn't.")
-                return false
+                //return false
             }
         case .MasterSystem:
             if let r = core as? PVMasterSystemSystemResponderClient {