Replace UIKit SideNavigationController with pure SwiftUI side menu

[JoeMatt]

Summary

Replace the UIKit-based SideNavigationController slide-out menu with a pure SwiftUI implementation. This is a prerequisite for eventually removing the legacy PVAppDelegate → PVRootViewController UIKit hosting chain.

Current Architecture

The side menu uses a deep UIKit wrapping stack:

1. PVAppDelegate creates PVRootViewController (UIViewController)
2. Wraps in PVRootViewNavigationController (UINavigationController)
3. Wraps in SideNavigationController (custom UIKit slide-out panel)
4. SideMenuView (SwiftUI) is hosted inside via UIHostingController
5. ConsolesWrapperView (SwiftUI) is main content, also in UIHostingController

The nav bar logo/header relies on a NavigationBarConfigurator (UIViewControllerRepresentable) that walks up the responder chain to find the UINavigationController and set the Provenance logo.

Proposed Changes

Phase 1: SwiftUI Side Menu Container

• Replace SideNavigationController with a SwiftUI overlay/offset-based menu
• Implement drag gesture to open/close (replaces UIKit pan gesture recognizers)
• Orientation-aware width (70% portrait iPhone, 30-40% iPad/landscape)
• Dimming overlay on main content when menu is open
• Preserve gamepad support (menu toggle, shoulder buttons)

Phase 2: Remove UIKit Wrappers

• Replace PVRootViewController with a SwiftUI root view
• Replace PVRootViewNavigationController with NavigationStack
• Move PVMenuDelegate / PVRootDelegate actions into SwiftUI environment or observable
• Simplify PVAppDelegate.setupSwiftUIInterface()

Files to Modify/Delete

Delete (~6 files):

• SideNavigationController/SideNavigationController.swift
• SideNavigationController/SideNavigationController+NestedTypes.swift
• SideNavigationController/UIViewController+SideNavigationController.swift
• SideMenu/SideMenuNavigationController.swift (mostly commented out)
• RootView/PVRootViewNavigationController.swift
• SideMenu/NavigationBarConfigurator (embedded in SideMenuView.swift)

Rewrite (~4 files):

• RootView/PVRootViewController.swift + extensions → SwiftUI root view
• SideMenu/SideMenuView.swift — remove UIKit hosting, use native SwiftUI nav
• App Delegate/PVAppDelegate.swift — simplify setupSwiftUIInterface()

Keep mostly unchanged:

• ConsolesWrapperView.swift
• MenuItemView.swift, MenuSectionHeaderView.swift
• PVMenuDelegate.swift, PVRootDelegate.swift (protocols)

Platform Considerations

• Must work on iOS and tvOS
• tvOS has no edge pan gestures — menu opens via gamepad/remote button
• iPad should support larger menu widths in regular size class

Context

The old SwiftUI-Introspect dependency was removed and replaced with NavigationBarConfigurator. This works but is fragile — a pure SwiftUI approach would eliminate the responder-chain walking entirely.

🤖 Generated with Claude Code

[github-actions]

✅ SwiftUI Side Menu PR Created — #3608

Completed

• 🚀 Agent started
• 📖 Read codebase context
• 🌿 Branch: agent/issue-3601
• 🔨 Created PVSwiftUISideMenuContainer (SwiftUI overlay)
• 🔨 Updated PVRootViewController (removed UIKit side nav calls)
• 🔨 Updated PVAppDelegate (replaced setupSideNavigation)
• 🗑️ Deleted SideNavigationController files (4 files)
• 📤 PR created: [Agent] Replace SideNavigationController with SwiftUI side menu container #3608
• 🤖 AI review initiated

Completed: 2026-03-29 23:05 UTC

[github-actions]

Phase 1: SwiftUI Side Menu — PR #3608

I've implemented Phase 1 of the SwiftUI side menu replacement. Here's a summary of what was done:

PR: #3608

Changes

New: PVSwiftUISideMenuContainer

• UIViewController subclass that embeds the main content as a full-screen child
• Hosts a SideMenuOverlayView (pure SwiftUI) via UIHostingController as a transparent overlay
• UIScreenEdgePanGestureRecognizer for left-edge swipe to open on iOS
• Spring-animated slide panel (response: 0.3, dampingFraction: 0.85)
• Dimming overlay with tap-to-dismiss and swipe-left-to-close

Key design decision: SideMenuView keeps its UINavigationController wrapper so the UISearchController-based search bar continues working. The UIKit nav controller is bridged into the SwiftUI overlay via UIViewControllerRepresentable, allowing SwiftUI to drive the animations while UIKit handles the internal navigation/search.

Removed (4 files):

• SideNavigationController.swift
• SideNavigationController+NestedTypes.swift
• UIViewController+SideNavigationController.swift
• SideMenuNavigationController.swift (was mostly commented out)

What's left for Phase 2

The remaining UIKit wrapper removal (replacing PVRootViewController and PVRootViewNavigationController with NavigationStack) is tracked in this issue.