Skip to content

Commit fef3084

Browse files
authored
fix gcc8 compiler warnings on string overflows (#905)
1 parent a4ff62b commit fef3084

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

client/cmdhf14b.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -679,7 +679,6 @@ int CmdSriWrite(const char *Cmd) {
679679
uint8_t blockno = -1;
680680
uint8_t data[4] = {0x00};
681681
bool isSrix4k = true;
682-
char str[20];
683682

684683
if (strlen(Cmd) < 1 || cmdp == 'h' || cmdp == 'H') {
685684
PrintAndLog("Usage: hf 14b write <1|2> <BLOCK> <DATA>");
@@ -725,6 +724,7 @@ int CmdSriWrite(const char *Cmd) {
725724
else
726725
PrintAndLog("[%s] Write block %02X [ %s ]", (isSrix4k)?"SRIX4K":"SRI512", blockno, sprint_hex(data, 4));
727726

727+
char str[22];
728728
sprintf(str, "-ss -c 09 %02x %02x%02x%02x%02x", blockno, data[0], data[1], data[2], data[3]);
729729

730730
CmdHF14BCmdRaw(str);

client/cmdhflist.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1119,11 +1119,11 @@ int CmdHFList(const char *Cmd) {
11191119
prev_EOT = &previous_EOT;
11201120
}
11211121

1122-
char load_filename[FILE_PATH_SIZE] = {0};
1122+
char load_filename[FILE_PATH_SIZE+1] = {0};
11231123
if (loadFromFile) {
11241124
strncpy(load_filename, arg_get_str(5)->sval[0], FILE_PATH_SIZE);
11251125
}
1126-
char save_filename[FILE_PATH_SIZE] = {0};
1126+
char save_filename[FILE_PATH_SIZE+1] = {0};
11271127
if (saveToFile) {
11281128
strncpy(save_filename, arg_get_str(6)->sval[0], FILE_PATH_SIZE);
11291129
}

0 commit comments

Comments
 (0)