refactor: modified the test to provide exact action and diff content

Author: Psingle20

src/proxy/processors/push-action/checkSensitiveData.js

@@ -2,6 +2,7 @@ const fs = require('fs');
 const csv = require('csv-parser');
 const XLSX = require('xlsx');
 const path = require('path');
+const Step = require('../../actions').Step;
 // const { exec: getDiffExec } = require('./getDiff');
 // Function to check for sensitive data patterns
 const checkForSensitiveData = (cell) => {
@@ -125,6 +126,7 @@ const extractFilePathsFromDiff = (diffContent) => {
 
 const exec = async (req, action) => {
     const diffStep = action.steps.find((s) => s.stepName === 'diff');
+    const step = new Step('checksensitiveData');
 
     if (diffStep && diffStep.content) {
         console.log('Diff content:', diffStep.content);
@@ -138,18 +140,18 @@ const exec = async (req, action) => {
             const anySensitiveDataDetected = sensitiveDataFound.some(found => found);
 
             if (anySensitiveDataDetected) {
-                action.pushBlocked = true;
-                action.error = true;
-                action.errorMessage = 'Your push has been blocked due to sensitive data detection.';
-                console.log(action.errorMessage);
+                step.blocked= true;
+                step.error = true;
+                step.errorMessage = 'Your push has been blocked due to sensitive data detection.';
+                console.log(step.errorMessage);
             }
         } else {
             console.log('No file paths provided in the diff step.');
         }
     } else {
         console.log('No diff content available.');
     }
-    
+    action.addStep(step);
     return action; // Returning action for testing purposes
 };
 

test/CheckSensitive.test.js

@@ -1,6 +1,8 @@
 // const path = require('path');
 const { exec } = require('../src/proxy/processors/push-action/checkSensitiveData.js'); // Adjust path as necessary
 const sinon = require('sinon');
+const {Action}=require('../src/proxy/actions/Action.js')
+const {Step}=require('../src/proxy/actions/Step.js')
 
 describe('Sensitive Data Detection', () => {
     let logStub;
@@ -19,78 +21,76 @@ describe('Sensitive Data Detection', () => {
     };
 
     it('should detect sensitive data in CSV file and block execution', async () => {
-        const action = {
-            steps: [{
-                stepName: 'diff',
-                content: createDiffContent(['test/test_data/sensitive_data.csv']) // Ensure this path is correct
-            }]
-        };
+        const action = new Action('action_id', 'push', 'create', Date.now(), 'owner/repo');
+        const step = new Step('diff');
+
+        // Create diff content simulating sensitive data in CSV
+        step.setContent(createDiffContent(['test/test_data/sensitive_data.csv']));
+        action.addStep(step)
+     
         await exec(null, action);
         sinon.assert.calledWith(logStub, sinon.match(/Your push has been blocked due to sensitive data detection/));
     });
 
     it('should detect sensitive data in XLSX file and block execution', async () => {
-        const action = {
-            steps: [{
-                stepName: 'diff',
-                content: createDiffContent(['test/test_data/sensitive_data2.xlsx']) // Ensure this path is correct
-            }]
-        };
+        const action = new Action('action_id', 'push', 'create', Date.now(), 'owner/repo');
+        const step = new Step('diff');
+        step.setContent(createDiffContent(['test/test_data/sensitive_data2.xlsx']));
+        action.addStep(step);
+       
         await exec(null, action);
         sinon.assert.calledWith(logStub, sinon.match(/Your push has been blocked due to sensitive data detection/));
     });
 
     it('should detect sensitive data in a log file and block execution', async () => {
-        const action = {
-            steps: [{
-                stepName: 'diff',
-                content: createDiffContent(['test/test_data/sensitive_data3.log']) // Ensure this path is correct
-            }]
-        };
+      
+        const action = new Action('action_id', 'push', 'create', Date.now(), 'owner/repo');
+        const step = new Step('diff');
+        step.setContent(createDiffContent(['test/test_data/sensitive_data3.log']));
+        action.addStep(step);
         await exec(null, action);
         sinon.assert.calledWith(logStub, sinon.match(/Your push has been blocked due to sensitive data detection/));
     });
 
     it('should detect sensitive data in a JSON file and block execution', async () => {
-        const action = {
-            steps: [{
-                stepName: 'diff',
-                content: createDiffContent(['test/test_data/sensitive_data4.json']) // Ensure this path is correct
-            }]
-        };
+       
+       
+        const action = new Action('action_id', 'push', 'create', Date.now(), 'owner/repo');
+        const step = new Step('diff');
+        step.setContent(createDiffContent(['test/test_data/sensitive_data4.json']));
+        action.addStep(step);
         await exec(null, action);
         sinon.assert.calledWith(logStub, sinon.match(/Your push has been blocked due to sensitive data detection/));
     });
 
     it('should allow execution if no sensitive data is found', async () => {
-        const action = {
-            steps: [{
-                stepName: 'diff',
-                content: createDiffContent(['test_data/no_sensitive_data.txt']) // Ensure this path is correct
-            }]
-        };
+       
+      
+        const action = new Action('action_id', 'push', 'create', Date.now(), 'owner/repo');
+        const step = new Step('diff');
+        step.setContent(createDiffContent(['test_data/no_sensitive_data.txt']));
+        action.addStep(step);
         await exec(null, action);
         sinon.assert.neverCalledWith(logStub, sinon.match(/Your push has been blocked due to sensitive data detection/));
     });
 
     it('should allow execution for an empty file', async () => {
-        const action = {
-            steps: [{
-                stepName: 'diff',
-                content: createDiffContent(['test_data/empty_file.txt']) // Ensure this path is correct
-            }]
-        };
+       
+      
+        const action = new Action('action_id', 'push', 'create', Date.now(), 'owner/repo');
+        const step = new Step('diff');
+        step.setContent(createDiffContent(['test_data/empty_file.txt']));
+        action.addStep(step);
         await exec(null, action);
         sinon.assert.neverCalledWith(logStub, sinon.match(/Your push has been blocked due to sensitive data detection/));
     });
 
     it('should handle file-not-found scenario gracefully', async () => {
-        const action = {
-            steps: [{
-                stepName: 'diff',
-                content: createDiffContent(['test_data/non_existent_file.txt']) // Ensure this path is correct
-            }]
-        };
+        
+        const action = new Action('action_id', 'push', 'create', Date.now(), 'owner/repo');
+        const step = new Step('diff');
+        step.setContent(createDiffContent(['test_data/non_existent_file.txt']));
+        action.addStep(step);
         try {
             await exec(null, action);
         } catch (error) {