Skip to content

Commit c6027e0

Browse files
committed
fix slicer visual issue (#227)
1 parent dadcb11 commit c6027e0

File tree

9 files changed

+31
-24
lines changed

9 files changed

+31
-24
lines changed

.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,9 @@ build
2121
eclipse
2222
run
2323
runs
24+
.kotlin
2425

2526
# Files from Forge MDK
2627
forge*changelog.txt
2728

28-
**.env
29+
**.env

src/main/java/com/possible_triangle/sliceanddice/SliceAndDice.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import com.simibubi.create.foundation.data.CreateRegistrate;
44
import net.minecraft.resources.ResourceKey;
5+
import net.minecraft.resources.ResourceLocation;
56
import net.minecraft.world.item.CreativeModeTab;
67
import net.neoforged.api.distmarker.Dist;
78
import net.neoforged.bus.api.IEventBus;
@@ -19,11 +20,15 @@ public class SliceAndDice {
1920
public static final CreateRegistrate REGISTRATE = CreateRegistrate.create(MOD_ID)
2021
.defaultCreativeTab((ResourceKey<CreativeModeTab>) null);
2122

23+
public static ResourceLocation modLoc(String path) {
24+
return ResourceLocation.fromNamespaceAndPath(MOD_ID, path);
25+
}
26+
2227
public SliceAndDice(ModContainer container, IEventBus modBus, Dist dist) {
2328
REGISTRATE.registerEventListeners(modBus);
2429
Content.INSTANCE.register(container, modBus);
2530

26-
if(dist.isClient()) {
31+
if (dist.isClient()) {
2732
Content.INSTANCE.clientInit();
2833
}
2934
}

src/main/kotlin/com/possible_triangle/sliceanddice/Content.kt

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package com.possible_triangle.sliceanddice
22

33
import com.possible_triangle.sliceanddice.SliceAndDice.MOD_ID
44
import com.possible_triangle.sliceanddice.SliceAndDice.REGISTRATE
5+
import com.possible_triangle.sliceanddice.SliceAndDice.modLoc
56
import com.possible_triangle.sliceanddice.block.slicer.*
67
import com.possible_triangle.sliceanddice.block.sprinkler.SprinkleBehaviour
78
import com.possible_triangle.sliceanddice.block.sprinkler.SprinklerBlock
@@ -21,7 +22,6 @@ import com.simibubi.create.AllFluids
2122
import com.simibubi.create.AllTags
2223
import com.simibubi.create.api.registry.CreateRegistries
2324
import com.simibubi.create.api.stress.BlockStressValues
24-
import com.simibubi.create.content.kinetics.mechanicalArm.ArmInteractionPointType
2525
import com.simibubi.create.content.processing.AssemblyOperatorBlockItem
2626
import com.simibubi.create.foundation.data.*
2727
import com.tterrag.registrate.AbstractRegistrate
@@ -53,13 +53,10 @@ import java.util.function.Supplier
5353

5454
object Content {
5555

56-
fun modLoc(path: String): ResourceLocation {
57-
return ResourceLocation.fromNamespaceAndPath(MOD_ID, path)
58-
}
59-
6056
val ALLOWED_TOOLS = TagKey.create(Registries.ITEM, modLoc("allowed_tools"))
6157

62-
val SLICER_BLOCK = REGISTRATE.block<SlicerBlock>("slicer", ::SlicerBlock).initialProperties(SharedProperties::stone)
58+
val SLICER_BLOCK = REGISTRATE.block("slicer", ::SlicerBlock)
59+
.initialProperties(SharedProperties::stone)
6360
.properties(BlockBehaviour.Properties::noOcclusion).transform(TagGen.axeOrPickaxe()).blockstate { c, p ->
6461
p.simpleBlock(c.entry, AssetLookup.partialBaseModel(c, p))
6562
}
@@ -77,7 +74,9 @@ object Content {
7774

7875
val SLICER_BLOCK_ENTITY = REGISTRATE.blockEntity("slicer", BlockEntityFactory(::SlicerBlockEntity))
7976
.visual { SimpleBlockEntityVisualizer.Factory(::SlicerVisual) }
80-
.renderer { NonNullFunction { SlicerRenderer(it) } }.validBlock(SLICER_BLOCK).register()
77+
.renderer { NonNullFunction { SlicerRenderer(it) } }
78+
.validBlock(SLICER_BLOCK)
79+
.register()
8180

8281
private fun <T : Recipe<*>> AbstractRegistrate<*>.recipeType(name: String) =
8382
generic(name, Registries.RECIPE_TYPE) {
@@ -95,12 +94,13 @@ object Content {
9594
.register()
9695

9796

98-
val WET_AIR = REGISTRATE.block<WetAir>("wet_air", ::WetAir).initialProperties { Blocks.CAVE_AIR }
97+
val WET_AIR = REGISTRATE.block("wet_air", ::WetAir)
98+
.initialProperties { Blocks.CAVE_AIR }
9999
.properties { it.randomTicks() }.blockstate { c, p ->
100100
p.simpleBlock(c.entry, p.models().withExistingParent(c.name, "block/barrier"))
101101
}.register()
102102

103-
val SPRINKLER_BLOCK = REGISTRATE.block<SprinklerBlock>("sprinkler", ::SprinklerBlock)
103+
val SPRINKLER_BLOCK = REGISTRATE.block("sprinkler", ::SprinklerBlock)
104104
.initialProperties { SharedProperties.copperMetal() }.transform(TagGen.pickaxeOnly())
105105
.addLayer { Supplier { RenderType.cutoutMipped() } }
106106
.blockstate { c, p -> p.simpleBlock(c.entry, AssetLookup.standardModel(c, p)) }
@@ -139,7 +139,7 @@ object Content {
139139

140140
val SLICER_INTERACTION_POINT =
141141
REGISTRATE
142-
.generic<ArmInteractionPointType, SlicerArmInteractionType>(
142+
.generic(
143143
"slicer",
144144
CreateRegistries.ARM_INTERACTION_POINT_TYPE
145145
) { SlicerArmInteractionType }

src/main/kotlin/com/possible_triangle/sliceanddice/SlicerPartials.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,6 @@ object SlicerPartials {
88
// Only here so the class gets loaded
99
}
1010

11-
val SLICER_HEAD = PartialModel.of(Content.modLoc("block/slicer/head"))
11+
val SLICER_HEAD = PartialModel.of(SliceAndDice.modLoc("block/slicer/head"))
1212

1313
}

src/main/kotlin/com/possible_triangle/sliceanddice/compat/FarmersDelightCompat.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ class FarmersDelightCompat private constructor() : IRecipeInjector {
6464
SliceAndDice.LOGGER.debug("Found {} cutting recipes", cuttingRecipes.size)
6565

6666
cuttingRecipes.forEach { (originalID, recipe) ->
67-
val id = Content.modLoc("cutting/${originalID.namespace}/${originalID.path}")
67+
val id = SliceAndDice.modLoc("cutting/${originalID.namespace}/${originalID.path}")
6868
add.accept(id, recipe.toBasin(id))
6969
}
7070
}
@@ -85,7 +85,7 @@ class FarmersDelightCompat private constructor() : IRecipeInjector {
8585
val generator = MixingRecipeGenerator(emptyingRecipes)
8686

8787
return cookingRecipes.forEach { (originalID, recipe) ->
88-
val id = Content.modLoc("cooking/${originalID.namespace}/${originalID.path}")
88+
val id = SliceAndDice.modLoc("cooking/${originalID.namespace}/${originalID.path}")
8989

9090
@Suppress("NULLABILITY_MISMATCH_BASED_ON_JAVA_ANNOTATIONS")
9191
// Cooking recipes do not use the registryAccess

src/main/kotlin/com/possible_triangle/sliceanddice/compat/OverweightFarmingCompat.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.possible_triangle.sliceanddice.compat
22

3-
import com.possible_triangle.sliceanddice.Content
3+
import com.possible_triangle.sliceanddice.SliceAndDice
44
import com.possible_triangle.sliceanddice.compat.ModCompat.OVERWEIGHT_FARMING
55
import com.simibubi.create.content.kinetics.deployer.DeployerApplicationRecipe
66
import com.simibubi.create.content.kinetics.deployer.ItemApplicationRecipe
@@ -36,7 +36,7 @@ class OverweightFarmingCompat private constructor() : IRecipeInjector {
3636
val recipes = MiscEvents.PEELABLES.get().map { (from, to) ->
3737
val fromId = from.builtInRegistryHolder().key().location()
3838
val toId = to.builtInRegistryHolder().key().location()
39-
val id = Content.modLoc("$OVERWEIGHT_FARMING/peeling/from_${fromId.path}_to_${toId.path}")
39+
val id = SliceAndDice.modLoc("$OVERWEIGHT_FARMING/peeling/from_${fromId.path}_to_${toId.path}")
4040
ItemApplicationRecipe.Builder(::ManualApplicationRecipe, id).let {
4141
it.output(to)
4242
it.require(from)
@@ -56,7 +56,7 @@ class OverweightFarmingCompat private constructor() : IRecipeInjector {
5656
MiscEvents.WAXABLES.get().forEach { (from, to) ->
5757
val fromId = from.builtInRegistryHolder().key().location()
5858
val toId = to.builtInRegistryHolder().key().location()
59-
val id = Content.modLoc("$OVERWEIGHT_FARMING/waxing/from_${fromId.path}_to_${toId.path}")
59+
val id = SliceAndDice.modLoc("$OVERWEIGHT_FARMING/waxing/from_${fromId.path}_to_${toId.path}")
6060
val recipe = ItemApplicationRecipe.Builder(::DeployerApplicationRecipe, id).let {
6161
it.output(to)
6262
it.require(from)

src/main/kotlin/com/possible_triangle/sliceanddice/compat/jei/CuttingProcessingCategory.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import java.util.function.Supplier
2424
class CuttingProcessingCategory() :
2525
CreateRecipeCategory<CuttingProcessingRecipe>(
2626
Info(
27-
RecipeType.createRecipeHolderType(Content.modLoc("slicer")),
27+
RecipeType.createRecipeHolderType(SliceAndDice.modLoc("slicer")),
2828
Component.translatable("${SliceAndDice.MOD_ID}.recipe.slicer"),
2929
EmptyBackground(177, 85),
3030
ItemIcon(SLICER),

src/main/kotlin/com/possible_triangle/sliceanddice/compat/jei/JEICompat.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.possible_triangle.sliceanddice.compat.jei
22

3-
import com.possible_triangle.sliceanddice.Content
3+
import com.possible_triangle.sliceanddice.SliceAndDice
44
import com.possible_triangle.sliceanddice.compat.FarmersDelightCompat
55
import com.possible_triangle.sliceanddice.compat.OverweightFarmingCompat
66
import com.simibubi.create.AllRecipeTypes
@@ -19,7 +19,7 @@ class JEICompat : IModPlugin {
1919

2020
private val cutting = CuttingProcessingCategory()
2121

22-
override fun getPluginUid() = Content.modLoc("jei")
22+
override fun getPluginUid() = SliceAndDice.modLoc("jei")
2323

2424
override fun registerCategories(registration: IRecipeCategoryRegistration) {
2525
registration.addRecipeCategories(cutting)

src/main/kotlin/com/possible_triangle/sliceanddice/data/CompatRecipes.kt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package com.possible_triangle.sliceanddice.data
22

33
import com.possible_triangle.sliceanddice.Content
4+
import com.possible_triangle.sliceanddice.SliceAndDice
45
import com.possible_triangle.sliceanddice.compat.ModCompat
56
import com.simibubi.create.AllFluids
67
import com.simibubi.create.AllItems
@@ -24,7 +25,7 @@ import vectorwing.farmersdelight.common.registry.ModItems
2425
object CompatRecipes {
2526

2627
fun generate(output: RegistrateRecipeProvider) {
27-
StandardProcessingRecipe.Builder(::FillingRecipe, Content.modLoc("hot_cocoa_from_fluid"))
28+
StandardProcessingRecipe.Builder(::FillingRecipe, SliceAndDice.modLoc("hot_cocoa_from_fluid"))
2829
.require(Items.GLASS_BOTTLE)
2930
.require(AllFluids.CHOCOLATE.get(), 250)
3031
.output(ModItems.HOT_COCOA.get())
@@ -45,7 +46,7 @@ object CompatRecipes {
4546
.withCondition(ModLoadedCondition("thermal_foundation"))
4647
.build(output)
4748

48-
StandardProcessingRecipe.Builder(::FillingRecipe, Content.modLoc("rich_soil"))
49+
StandardProcessingRecipe.Builder(::FillingRecipe, SliceAndDice.modLoc("rich_soil"))
4950
.require(ModBlocks.ORGANIC_COMPOST.get())
5051
.require(Content.FERTILIZER.get(), 500)
5152
.output(ModBlocks.RICH_SOIL.get())
@@ -61,7 +62,7 @@ object CompatRecipes {
6162
}
6263

6364
private fun fertilizerMixing(amount: Int, id: String): StandardProcessingRecipe.Builder<MixingRecipe> {
64-
return StandardProcessingRecipe.Builder(::MixingRecipe, Content.modLoc("fertilizer/from_$id"))
65+
return StandardProcessingRecipe.Builder(::MixingRecipe, SliceAndDice.modLoc("fertilizer/from_$id"))
6566
.require(Fluids.WATER, amount)
6667
.output(Content.FERTILIZER.get(), amount)
6768
}

0 commit comments

Comments
 (0)