feat: remove unecessary top-up and improve tests (#155)

## Summary

Optional change to simplify some of the logic of the treasurer.

I noticed that the "top_up" instruction is relatively useless, it only
increments a "funded_collateral_amount" counter which itself is already
a duplicate of the "run_collateral.amount"

## Details

This PR simply remove the "funded_collateral_amount" field and the
"top_up" IX

Removing this IX reduce the complexity of the program this PR also
includes more tests to increase reliability

Author: jquesnelle

architectures/decentralized/solana-tooling/src/process_treasurer_instructions.rs

@@ -6,19 +6,16 @@ use psyche_solana_coordinator::find_coordinator_instance;
 use psyche_solana_treasurer::accounts::ParticipantClaimAccounts;
 use psyche_solana_treasurer::accounts::ParticipantCreateAccounts;
 use psyche_solana_treasurer::accounts::RunCreateAccounts;
-use psyche_solana_treasurer::accounts::RunTopUpAccounts;
 use psyche_solana_treasurer::accounts::RunUpdateAccounts;
 use psyche_solana_treasurer::find_participant;
 use psyche_solana_treasurer::find_run;
 use psyche_solana_treasurer::instruction::ParticipantClaim;
 use psyche_solana_treasurer::instruction::ParticipantCreate;
 use psyche_solana_treasurer::instruction::RunCreate;
-use psyche_solana_treasurer::instruction::RunTopUp;
 use psyche_solana_treasurer::instruction::RunUpdate;
 use psyche_solana_treasurer::logic::ParticipantClaimParams;
 use psyche_solana_treasurer::logic::ParticipantCreateParams;
 use psyche_solana_treasurer::logic::RunCreateParams;
-use psyche_solana_treasurer::logic::RunTopUpParams;
 use psyche_solana_treasurer::logic::RunUpdateParams;
 use solana_sdk::instruction::Instruction;
 use solana_sdk::pubkey::Pubkey;
@@ -63,40 +60,6 @@ pub async fn process_treasurer_run_create(
     Ok((run, coordinator_instance))
 }
 
-pub async fn process_treasurer_run_top_up(
-    endpoint: &mut ToolboxEndpoint,
-    payer: &Keypair,
-    authority: &Keypair,
-    authority_collateral: &Pubkey,
-    collateral_mint: &Pubkey,
-    run: &Pubkey,
-    collateral_amount: u64,
-) -> Result<Signature, ToolboxEndpointError> {
-    let run_collateral = ToolboxEndpoint::find_spl_associated_token_account(
-        run,
-        collateral_mint,
-    );
-    let accounts = RunTopUpAccounts {
-        authority: authority.pubkey(),
-        authority_collateral: *authority_collateral,
-        collateral_mint: *collateral_mint,
-        run: *run,
-        run_collateral,
-        token_program: token::ID,
-    };
-    let instruction = Instruction {
-        accounts: accounts.to_account_metas(None),
-        data: RunTopUp {
-            params: RunTopUpParams { collateral_amount },
-        }
-        .data(),
-        program_id: psyche_solana_treasurer::ID,
-    };
-    endpoint
-        .process_instruction_with_signers(instruction, payer, &[authority])
-        .await
-}
-
 pub async fn process_treasurer_run_update(
     endpoint: &mut ToolboxEndpoint,
     payer: &Keypair,

architectures/decentralized/solana-tooling/tests/suites/memnet_coordinator_full_round.rs

@@ -165,19 +165,17 @@ pub async fn run() {
     .unwrap();
 
     // Whitelisted with the wrong account, can't join
-    assert!(
-        process_coordinator_join_run(
-            &mut endpoint,
-            &payer,
-            &payer,
-            &authorization,
-            &coordinator_instance,
-            &coordinator_account,
-            client_id
-        )
-        .await
-        .is_err()
-    );
+    process_coordinator_join_run(
+        &mut endpoint,
+        &payer,
+        &payer,
+        &authorization,
+        &coordinator_instance,
+        &coordinator_account,
+        client_id,
+    )
+    .await
+    .unwrap_err();
 
     // Whitelisted, can join
     process_coordinator_join_run(
@@ -204,17 +202,15 @@ pub async fn run() {
     );
 
     // Can't tick yet because paused
-    assert!(
-        process_coordinator_tick(
-            &mut endpoint,
-            &payer,
-            &ticker,
-            &coordinator_instance,
-            &coordinator_account,
-        )
-        .await
-        .is_err()
-    );
+    process_coordinator_tick(
+        &mut endpoint,
+        &payer,
+        &ticker,
+        &coordinator_instance,
+        &coordinator_account,
+    )
+    .await
+    .unwrap_err();
 
     // Unpause
     process_coordinator_set_paused(
@@ -305,18 +301,16 @@ pub async fn run() {
         broadcast_merkle: Default::default(),
         metadata: Default::default(),
     };
-    assert!(
-        process_coordinator_witness(
-            &mut endpoint,
-            &payer,
-            &ticker,
-            &coordinator_instance,
-            &coordinator_account,
-            &witness,
-        )
-        .await
-        .is_err()
-    );
+    process_coordinator_witness(
+        &mut endpoint,
+        &payer,
+        &ticker,
+        &coordinator_instance,
+        &coordinator_account,
+        &witness,
+    )
+    .await
+    .unwrap_err();
     process_coordinator_witness(
         &mut endpoint,
         &payer,