Skip to content

Commit 7b5cb98

Browse files
committed
DTS-50661: Renamed AiDataProcessorConstants to JobConstants.
Change-log: Batch processing ai-recommendation for performance improvement.
1 parent 812c5b4 commit 7b5cb98

File tree

19 files changed

+81
-79
lines changed

19 files changed

+81
-79
lines changed

ai-data-processor/src/main/java/com/publicissapient/kpidashboard/job/aiusagestatisticscollector/processor/AccountItemProcessor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import com.publicissapient.kpidashboard.job.aiusagestatisticscollector.dto.PagedAIUsagePerOrgLevel;
2222
import com.publicissapient.kpidashboard.job.aiusagestatisticscollector.model.AIUsageStatistics;
2323
import com.publicissapient.kpidashboard.job.aiusagestatisticscollector.service.AIUsageStatisticsService;
24-
import com.publicissapient.kpidashboard.job.constant.AiDataProcessorConstants;
24+
import com.publicissapient.kpidashboard.job.constant.JobConstants;
2525

2626
import jakarta.annotation.Nonnull;
2727
import lombok.AllArgsConstructor;
@@ -34,7 +34,7 @@ public class AccountItemProcessor implements ItemProcessor<PagedAIUsagePerOrgLev
3434

3535
@Override
3636
public AIUsageStatistics process(@Nonnull PagedAIUsagePerOrgLevel item) {
37-
log.debug("{} Fetching AI usage statistics for level name: {}", AiDataProcessorConstants.LOG_PREFIX_AI_USAGE_STATISTICS, item.levelName());
37+
log.debug("{} Fetching AI usage statistics for level name: {}", JobConstants.LOG_PREFIX_AI_USAGE_STATISTICS, item.levelName());
3838
return aiUsageStatisticsService.fetchAIUsageStatistics(item.levelName());
3939
}
4040
}

ai-data-processor/src/main/java/com/publicissapient/kpidashboard/job/aiusagestatisticscollector/reader/AccountItemReader.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
import com.publicissapient.kpidashboard.job.aiusagestatisticscollector.dto.PagedAIUsagePerOrgLevel;
2222
import com.publicissapient.kpidashboard.job.aiusagestatisticscollector.service.AccountBatchService;
23-
import com.publicissapient.kpidashboard.job.constant.AiDataProcessorConstants;
23+
import com.publicissapient.kpidashboard.job.constant.JobConstants;
2424

2525
import lombok.RequiredArgsConstructor;
2626
import lombok.extern.slf4j.Slf4j;
@@ -34,7 +34,7 @@ public class AccountItemReader implements ItemReader<PagedAIUsagePerOrgLevel> {
3434
@Override
3535
public PagedAIUsagePerOrgLevel read() {
3636
PagedAIUsagePerOrgLevel aiUsageStatistics = accountBatchService.getNextAccountPage();
37-
log.info("{} Reader fetched level name: {}", AiDataProcessorConstants.LOG_PREFIX_AI_USAGE_STATISTICS, aiUsageStatistics.levelName());
37+
log.info("{} Reader fetched level name: {}", JobConstants.LOG_PREFIX_AI_USAGE_STATISTICS, aiUsageStatistics.levelName());
3838
return aiUsageStatistics;
3939
}
4040
}

ai-data-processor/src/main/java/com/publicissapient/kpidashboard/job/aiusagestatisticscollector/writer/AccountItemWriter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323

2424
import com.publicissapient.kpidashboard.job.aiusagestatisticscollector.model.AIUsageStatistics;
2525
import com.publicissapient.kpidashboard.job.aiusagestatisticscollector.service.AIUsageStatisticsService;
26-
import com.publicissapient.kpidashboard.job.constant.AiDataProcessorConstants;
26+
import com.publicissapient.kpidashboard.job.constant.JobConstants;
2727

2828
import lombok.AllArgsConstructor;
2929
import lombok.NonNull;
@@ -36,7 +36,7 @@ public class AccountItemWriter implements ItemWriter<AIUsageStatistics> {
3636

3737
@Override
3838
public void write(@NonNull Chunk<? extends AIUsageStatistics> chunk) {
39-
log.info("{} Received chunk items for inserting into database with size: {}", AiDataProcessorConstants.LOG_PREFIX_AI_USAGE_STATISTICS, chunk.size());
39+
log.info("{} Received chunk items for inserting into database with size: {}", JobConstants.LOG_PREFIX_AI_USAGE_STATISTICS, chunk.size());
4040
aiUsageStatisticsService.saveAll((List.copyOf(chunk.getItems())));
4141
}
4242
}

ai-data-processor/src/main/java/com/publicissapient/kpidashboard/job/constant/AiDataProcessorConstants.java renamed to ai-data-processor/src/main/java/com/publicissapient/kpidashboard/job/constant/JobConstants.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
* Constants used across AI Data Processor jobs.
2323
*/
2424
@UtilityClass
25-
public final class AiDataProcessorConstants {
25+
public final class JobConstants {
2626

2727
public static final String JOB_PRODUCTIVITY_CALCULATION = "productivity-calculation";
2828
public static final String JOB_KPI_MATURITY_CALCULATION = "kpi-maturity-calculation";

ai-data-processor/src/main/java/com/publicissapient/kpidashboard/job/kpimaturitycalculation/processor/ProjectItemProcessor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import org.springframework.batch.item.ItemProcessor;
2020

2121
import com.publicissapient.kpidashboard.common.model.kpimaturity.organization.KpiMaturity;
22-
import com.publicissapient.kpidashboard.job.constant.AiDataProcessorConstants;
22+
import com.publicissapient.kpidashboard.job.constant.JobConstants;
2323
import com.publicissapient.kpidashboard.job.kpimaturitycalculation.service.KpiMaturityCalculationService;
2424
import com.publicissapient.kpidashboard.job.shared.dto.ProjectInputDTO;
2525

@@ -35,7 +35,7 @@ public class ProjectItemProcessor implements ItemProcessor<ProjectInputDTO, KpiM
3535

3636
@Override
3737
public KpiMaturity process(@Nonnull ProjectInputDTO item) {
38-
log.info("{} Starting kpi metrics calculation for project with nodeId: {}", AiDataProcessorConstants.LOG_PREFIX_KPI_MATURITY,item.nodeId());
38+
log.info("{} Starting kpi metrics calculation for project with nodeId: {}", JobConstants.LOG_PREFIX_KPI_MATURITY,item.nodeId());
3939

4040
return kpiMaturityCalculationService.calculateKpiMaturityForProject(item);
4141
}

ai-data-processor/src/main/java/com/publicissapient/kpidashboard/job/kpimaturitycalculation/reader/ProjectItemReader.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
import org.springframework.batch.item.ItemReader;
2020

21-
import com.publicissapient.kpidashboard.job.constant.AiDataProcessorConstants;
21+
import com.publicissapient.kpidashboard.job.constant.JobConstants;
2222
import com.publicissapient.kpidashboard.job.productivitycalculation.service.ProjectBatchService;
2323
import com.publicissapient.kpidashboard.job.shared.dto.ProjectInputDTO;
2424

@@ -35,7 +35,7 @@ public class ProjectItemReader implements ItemReader<ProjectInputDTO> {
3535
public ProjectInputDTO read() {
3636
ProjectInputDTO projectInputDTO = projectBatchService.getNextProjectInputData();
3737

38-
log.info("{} Received project input dto {}",AiDataProcessorConstants.LOG_PREFIX_KPI_MATURITY, projectInputDTO);
38+
log.info("{} Received project input dto {}", JobConstants.LOG_PREFIX_KPI_MATURITY, projectInputDTO);
3939

4040
return projectInputDTO;
4141
}

ai-data-processor/src/main/java/com/publicissapient/kpidashboard/job/kpimaturitycalculation/writer/ProjectItemWriter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import java.util.List;
2020

2121
import com.publicissapient.kpidashboard.common.service.ProcessorExecutionTraceLogService;
22-
import com.publicissapient.kpidashboard.job.constant.AiDataProcessorConstants;
22+
import com.publicissapient.kpidashboard.job.constant.JobConstants;
2323
import org.springframework.batch.item.Chunk;
2424
import org.springframework.batch.item.ItemWriter;
2525
import org.springframework.lang.NonNull;
@@ -40,7 +40,7 @@ public class ProjectItemWriter implements ItemWriter<KpiMaturity> {
4040
@Override
4141
public void write(@NonNull Chunk<? extends KpiMaturity> chunk) {
4242
log.info("{} Received chunk items for inserting into database with size: {}",
43-
AiDataProcessorConstants.LOG_PREFIX_KPI_MATURITY, chunk.size());
43+
JobConstants.LOG_PREFIX_KPI_MATURITY, chunk.size());
4444
kpiMaturityCalculationService.saveAll((List<KpiMaturity>) chunk.getItems());
4545
}
4646
}

ai-data-processor/src/main/java/com/publicissapient/kpidashboard/job/productivitycalculation/processor/ProjectItemProcessor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import org.springframework.batch.item.ItemProcessor;
2020

2121
import com.publicissapient.kpidashboard.common.model.productivity.calculation.Productivity;
22-
import com.publicissapient.kpidashboard.job.constant.AiDataProcessorConstants;
22+
import com.publicissapient.kpidashboard.job.constant.JobConstants;
2323
import com.publicissapient.kpidashboard.job.productivitycalculation.service.ProductivityCalculationService;
2424
import com.publicissapient.kpidashboard.job.shared.dto.ProjectInputDTO;
2525

@@ -35,7 +35,7 @@ public class ProjectItemProcessor implements ItemProcessor<ProjectInputDTO, Prod
3535

3636
@Override
3737
public Productivity process(@Nonnull ProjectInputDTO item) {
38-
log.debug("{}Starting productivity calculation for project with nodeId: {}", AiDataProcessorConstants.LOG_PREFIX_PRODUCTIVITY, item.nodeId());
38+
log.debug("{}Starting productivity calculation for project with nodeId: {}", JobConstants.LOG_PREFIX_PRODUCTIVITY, item.nodeId());
3939

4040
return productivityCalculationService.calculateProductivityGainForProject(item);
4141
}

ai-data-processor/src/main/java/com/publicissapient/kpidashboard/job/productivitycalculation/reader/ProjectItemReader.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
import org.springframework.batch.item.ItemReader;
2020

21-
import com.publicissapient.kpidashboard.job.constant.AiDataProcessorConstants;
21+
import com.publicissapient.kpidashboard.job.constant.JobConstants;
2222
import com.publicissapient.kpidashboard.job.productivitycalculation.service.ProjectBatchService;
2323
import com.publicissapient.kpidashboard.job.shared.dto.ProjectInputDTO;
2424

@@ -35,7 +35,7 @@ public class ProjectItemReader implements ItemReader<ProjectInputDTO> {
3535
public ProjectInputDTO read() {
3636
ProjectInputDTO projectInputDTO = projectBatchService.getNextProjectInputData();
3737

38-
log.info("[productivity-calculation job]Received project input dto {}", AiDataProcessorConstants.LOG_PREFIX_PRODUCTIVITY, projectInputDTO);
38+
log.info("[productivity-calculation job]Received project input dto {}", JobConstants.LOG_PREFIX_PRODUCTIVITY, projectInputDTO);
3939

4040
return projectInputDTO;
4141
}

ai-data-processor/src/main/java/com/publicissapient/kpidashboard/job/productivitycalculation/writer/ProjectItemWriter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import java.util.List;
2020

2121
import com.publicissapient.kpidashboard.common.service.ProcessorExecutionTraceLogService;
22-
import com.publicissapient.kpidashboard.job.constant.AiDataProcessorConstants;
22+
import com.publicissapient.kpidashboard.job.constant.JobConstants;
2323
import org.springframework.batch.item.Chunk;
2424
import org.springframework.batch.item.ItemWriter;
2525
import org.springframework.lang.NonNull;
@@ -40,7 +40,7 @@ public class ProjectItemWriter implements ItemWriter<Productivity> {
4040
@Override
4141
public void write(@NonNull Chunk<? extends Productivity> chunk) {
4242
log.info("{} Received chunk items for inserting into database with size: {}",
43-
AiDataProcessorConstants.LOG_PREFIX_PRODUCTIVITY, chunk.size());
43+
JobConstants.LOG_PREFIX_PRODUCTIVITY, chunk.size());
4444
productivityCalculationService.saveAll((List<Productivity>) chunk.getItems());
4545
}
4646
}

0 commit comments

Comments
 (0)