DTS-50661: Review comment unit test fixes

Change-log: Batch processing ai-recommendation for performance improvement.

Author: shunaray

ai-data-processor/src/test/java/com/publicissapient/kpidashboard/job/recommendationcalculation/processor/ProjectItemProcessorTest.java

@@ -177,7 +177,7 @@ void process_ServiceException_ReturnsNullAndLogsTrace() throws Exception {
 
 			// Assert
 			assertNull(result);
-			verify(processorExecutionTraceLogService, times(1)).upsertTraceLog(eq("Recommendation"), eq("project-1"),
+			verify(processorExecutionTraceLogService, times(1)).upsertTraceLog(eq("recommendation-calculation"), eq("project-1"),
 					eq(false), anyString());
 		}
 
@@ -194,7 +194,7 @@ void process_Exception_CapturesDetailedErrorMessage() throws Exception {
 
 			// Assert
 			ArgumentCaptor<String> errorMessageCaptor = ArgumentCaptor.forClass(String.class);
-			verify(processorExecutionTraceLogService).upsertTraceLog(eq("Recommendation"), eq("project-1"), eq(false),
+			verify(processorExecutionTraceLogService).upsertTraceLog(eq("recommendation-calculation"), eq("project-1"), eq(false),
 					errorMessageCaptor.capture());
 
 			String errorMessage = errorMessageCaptor.getValue();
@@ -346,7 +346,7 @@ void process_Failure_LogsWithCorrectJobName() throws Exception {
 			processor.process(projectInput);
 
 			// Assert
-			verify(processorExecutionTraceLogService).upsertTraceLog(eq("Recommendation"), anyString(), eq(false),
+			verify(processorExecutionTraceLogService).upsertTraceLog(eq("recommendation-calculation"), anyString(), eq(false),
 					anyString());
 		}
 

ai-data-processor/src/test/java/com/publicissapient/kpidashboard/job/recommendationcalculation/service/RecommendationCalculationServiceTest.java

@@ -223,8 +223,8 @@ void calculateRecommendationsForProject_ParsingFails_ThrowsIllegalStateException
 		}
 
 		@Test
-		@DisplayName("Should wrap AI Gateway exception in IllegalStateException")
-		void calculateRecommendationsForProject_AiGatewayFails_WrapsException() {
+		@DisplayName("Should throw RuntimeException when AI Gateway fails")
+		void calculateRecommendationsForProject_AiGatewayFails_ThrowsRuntimeException() {
 			// Arrange
 			RuntimeException aiException = new RuntimeException("AI Gateway connection failed");
 			when(recommendationCalculationConfig.getCalculationConfig()).thenReturn(testCalculationConfig);
@@ -233,28 +233,25 @@ void calculateRecommendationsForProject_AiGatewayFails_WrapsException() {
 			when(aiGatewayClient.generate(any())).thenThrow(aiException);
 
 			// Act & Assert
-			IllegalStateException exception = assertThrows(IllegalStateException.class,
+			RuntimeException exception = assertThrows(RuntimeException.class,
 					() -> recommendationCalculationService.calculateRecommendationsForProject(testProjectInput));
 
-			assertTrue(exception.getMessage().contains("Failed to calculate recommendations"));
-			assertTrue(exception.getMessage().contains(testProjectInput.nodeId()));
-			assertEquals(aiException, exception.getCause());
+			assertEquals("AI Gateway connection failed", exception.getMessage());
 		}
 
 		@Test
-		@DisplayName("Should wrap KPI extraction exception in IllegalStateException")
-		void calculateRecommendationsForProject_KpiExtractionFails_WrapsException() {
+		@DisplayName("Should throw RuntimeException when KPI extraction fails")
+		void calculateRecommendationsForProject_KpiExtractionFails_ThrowsRuntimeException() {
 			// Arrange
 			RuntimeException kpiException = new RuntimeException("KPI data fetch failed");
 			when(recommendationCalculationConfig.getCalculationConfig()).thenReturn(testCalculationConfig);
 			when(kpiDataExtractionService.fetchKpiDataForProject(testProjectInput)).thenThrow(kpiException);
 
 			// Act & Assert
-			IllegalStateException exception = assertThrows(IllegalStateException.class,
+			RuntimeException exception = assertThrows(RuntimeException.class,
 					() -> recommendationCalculationService.calculateRecommendationsForProject(testProjectInput));
 
-			assertTrue(exception.getMessage().contains("Failed to calculate recommendations"));
-			assertEquals(kpiException, exception.getCause());
+			assertEquals("KPI data fetch failed", exception.getMessage());
 
 			verify(promptService, never()).getKpiRecommendationPrompt(anyMap(), any());
 			verify(aiGatewayClient, never()).generate(any());
@@ -276,7 +273,7 @@ void calculateRecommendationsForProject_MissingTTLConfig_ThrowsIllegalStateExcep
 			IllegalStateException exception = assertThrows(IllegalStateException.class,
 					() -> recommendationCalculationService.calculateRecommendationsForProject(testProjectInput));
 
-			assertFalse(exception.getMessage().contains("TTL configuration not found"));
+			assertTrue(exception.getMessage().contains("TTL configuration"));
 		}
 
 		@Test

ai-data-processor/src/test/java/com/publicissapient/kpidashboard/job/recommendationcalculation/writer/ProjectItemWriterTest.java

@@ -222,7 +222,7 @@ void write_MultipleRecommendations_LogsTraceForEach() {
 			writer.write(chunk);
 
 			// Assert
-			verify(processorExecutionTraceLogService, times(3)).upsertTraceLog(eq("Recommendation"), anyString(),
+			verify(processorExecutionTraceLogService, times(3)).upsertTraceLog(eq("recommendation-calculation"), anyString(),
 					eq(true), eq(null));
 		}
 
@@ -236,9 +236,9 @@ void write_Recommendations_LogsWithCorrectProjectIds() {
 			writer.write(chunk);
 
 			// Assert
-			verify(processorExecutionTraceLogService).upsertTraceLog(eq("Recommendation"), eq("project-1"), eq(true),
+			verify(processorExecutionTraceLogService).upsertTraceLog(eq("recommendation-calculation"), eq("project-1"), eq(true),
 					eq(null));
-			verify(processorExecutionTraceLogService).upsertTraceLog(eq("Recommendation"), eq("project-2"), eq(true),
+			verify(processorExecutionTraceLogService).upsertTraceLog(eq("recommendation-calculation"), eq("project-2"), eq(true),
 					eq(null));
 		}
 
@@ -266,7 +266,7 @@ void write_ChunkWithNulls_LogsOnlyForNonNulls() {
 			writer.write(chunk);
 
 			// Assert
-			verify(processorExecutionTraceLogService, times(2)).upsertTraceLog(eq("Recommendation"), anyString(),
+			verify(processorExecutionTraceLogService, times(2)).upsertTraceLog(eq("recommendation-calculation"), anyString(),
 					eq(true), eq(null));
 		}
 
@@ -314,7 +314,7 @@ void write_NullProjectId_HandlesGracefully() {
 
 			// Assert
 			verify(recommendationRepository, times(1)).saveAll(anyList());
-			verify(processorExecutionTraceLogService).upsertTraceLog(eq("Recommendation"), eq(null), eq(true),
+			verify(processorExecutionTraceLogService).upsertTraceLog(eq("recommendation-calculation"), eq(null), eq(true),
 					eq(null));
 		}
 
@@ -331,7 +331,7 @@ void write_EmptyProjectId_HandlesGracefully() {
 
 			// Assert
 			verify(recommendationRepository, times(1)).saveAll(anyList());
-			verify(processorExecutionTraceLogService).upsertTraceLog(eq("Recommendation"), eq(""), eq(true), eq(null));
+			verify(processorExecutionTraceLogService).upsertTraceLog(eq("recommendation-calculation"), eq(""), eq(true), eq(null));
 		}
 
 		@Test