Skip to content

Commit 1d459c4

Browse files
tklausergopherbot
authored andcommitted
all: delete more windows/arm remnants
Updates golang#71671 Change-Id: I663c4a659ad45bcebfc03d6eb4783e5f5d3afa0d Reviewed-on: https://go-review.googlesource.com/c/go/+/699176 Auto-Submit: Tobias Klauser <[email protected]> Reviewed-by: Quim Muntal <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1 parent 27ce6e4 commit 1d459c4

File tree

4 files changed

+5
-8
lines changed

4 files changed

+5
-8
lines changed

src/cmd/dist/test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1835,7 +1835,6 @@ func (t *tester) fipsSupported() bool {
18351835
switch {
18361836
case goarch == "wasm",
18371837
goos == "windows" && goarch == "386",
1838-
goos == "windows" && goarch == "arm",
18391838
goos == "openbsd",
18401839
goos == "aix":
18411840
return false

src/cmd/dist/util.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -366,9 +366,8 @@ func xgetgoarm() string {
366366
// If we're building on an actual arm system, and not building
367367
// a cross-compiling toolchain, try to exec ourselves
368368
// to detect whether VFP is supported and set the default GOARM.
369-
// Windows requires ARMv7, so we can skip the check.
370-
// We've always assumed Android is ARMv7 too.
371-
if gohostarch == "arm" && goarch == "arm" && goos == gohostos && goos != "windows" && goos != "android" {
369+
// We've always assumed Android is ARMv7.
370+
if gohostarch == "arm" && goarch == "arm" && goos == gohostos && goos != "android" {
372371
// Try to exec ourselves in a mode to detect VFP support.
373372
// Seeing how far it gets determines which instructions failed.
374373
// The test is OS-agnostic.

src/net/http/client_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1227,7 +1227,7 @@ func testClientTimeout(t *testing.T, mode testMode) {
12271227
t.Logf("timeout before response received")
12281228
continue
12291229
}
1230-
if runtime.GOOS == "windows" && strings.HasPrefix(runtime.GOARCH, "arm") {
1230+
if runtime.GOOS == "windows" && runtime.GOARCH == "arm64" {
12311231
testenv.SkipFlaky(t, 43120)
12321232
}
12331233
t.Fatal(err)
@@ -1256,7 +1256,7 @@ func testClientTimeout(t *testing.T, mode testMode) {
12561256
t.Errorf("ReadAll error = %q; expected some context.DeadlineExceeded", err)
12571257
}
12581258
if got := ne.Error(); !strings.Contains(got, "(Client.Timeout") {
1259-
if runtime.GOOS == "windows" && strings.HasPrefix(runtime.GOARCH, "arm") {
1259+
if runtime.GOOS == "windows" && runtime.GOARCH == "arm64" {
12601260
testenv.SkipFlaky(t, 43120)
12611261
}
12621262
t.Errorf("error string = %q; missing timeout substring", got)
@@ -1302,7 +1302,7 @@ func testClientTimeout_Headers(t *testing.T, mode testMode) {
13021302
t.Errorf("ReadAll error = %q; expected some context.DeadlineExceeded", err)
13031303
}
13041304
if got := ne.Error(); !strings.Contains(got, "Client.Timeout exceeded") {
1305-
if runtime.GOOS == "windows" && strings.HasPrefix(runtime.GOARCH, "arm") {
1305+
if runtime.GOOS == "windows" && runtime.GOARCH == "arm64" {
13061306
testenv.SkipFlaky(t, 43120)
13071307
}
13081308
t.Errorf("error string = %q; missing timeout substring", got)

src/runtime/memclr_arm.s

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
// See memclrNoHeapPointers Go doc for important implementation constraints.
3434

3535
// func memclrNoHeapPointers(ptr unsafe.Pointer, n uintptr)
36-
// Also called from assembly in sys_windows_arm.s without g (but using Go stack convention).
3736
TEXT runtime·memclrNoHeapPointers(SB),NOSPLIT,$0-8
3837
MOVW ptr+0(FP), TO
3938
MOVW n+4(FP), N

0 commit comments

Comments
 (0)