Skip to content

Commit 80f3bb5

Browse files
committed
reflect: remove timeout in TestChanOfGC
This test has an arbitrary 5 second timeout, and this seems to fire on Darwin with mayMoreStackMove enabled (which is slow). Just rely on the regular test timeout instead of this arbitrary shorter timeout to eliminate the possibility that the test is just too slow. On my Linux VM, I can get this test to take up to 2 seconds with mayMoreStackMove set on all the same packages dist does, so this failure mode is actually plausible. Fixes golang#75742. Change-Id: Iebcc859cab26e9205b57b869690162a9a424dfce Reviewed-on: https://go-review.googlesource.com/c/go/+/710618 Reviewed-by: Cherry Mui <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Michael Knyszek <[email protected]>
1 parent 9db7e30 commit 80f3bb5

File tree

1 file changed

+0
-13
lines changed

1 file changed

+0
-13
lines changed

src/reflect/all_test.go

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -6198,19 +6198,6 @@ func TestChanOfDir(t *testing.T) {
61986198
}
61996199

62006200
func TestChanOfGC(t *testing.T) {
6201-
done := make(chan bool, 1)
6202-
go func() {
6203-
select {
6204-
case <-done:
6205-
case <-time.After(5 * time.Second):
6206-
panic("deadlock in TestChanOfGC")
6207-
}
6208-
}()
6209-
6210-
defer func() {
6211-
done <- true
6212-
}()
6213-
62146201
type T *uintptr
62156202
tt := TypeOf(T(nil))
62166203
ct := ChanOf(BothDir, tt)

0 commit comments

Comments
 (0)