runtime: delete timediv

rsc · gopherbot · commit d32b1f02c3e8 · 2025-10-30T09:55:06.000-07:00
Now that the compiler handles constant 64-bit divisions without function calls on 32-bit systems, we no longer need to maintain and test a bad custom implementation of 64-bit division. Change-Id: If28807ad4f86507267ae69bc8f0b09ec18e98b66 Reviewed-on: https://go-review.googlesource.com/c/go/+/716463 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Russ Cox <rsc@golang.org> Reviewed-by: Alan Donovan <adonovan@google.com>
diff --git a/src/runtime/defs1_netbsd_386.go b/src/runtime/defs1_netbsd_386.go
@@ -121,7 +121,8 @@ type timespec struct {
 
 //go:nosplit
 func (ts *timespec) setNsec(ns int64) {
-	ts.tv_sec = int64(timediv(ns, 1e9, &ts.tv_nsec))
+	ts.tv_sec = int64(ns / 1e9)
+	ts.tv_nsec = int32(ns % 1e9)
 }
 
 type timeval struct {
diff --git a/src/runtime/defs1_netbsd_arm.go b/src/runtime/defs1_netbsd_arm.go
@@ -123,7 +123,8 @@ type timespec struct {
 
 //go:nosplit
 func (ts *timespec) setNsec(ns int64) {
-	ts.tv_sec = int64(timediv(ns, 1e9, &ts.tv_nsec))
+	ts.tv_sec = int64(ns / 1e9)
+	ts.tv_nsec = int32(ns % 1e9)
 }
 
 type timeval struct {
diff --git a/src/runtime/defs_freebsd_386.go b/src/runtime/defs_freebsd_386.go
diff --git a/src/runtime/defs_freebsd_arm.go b/src/runtime/defs_freebsd_arm.go
diff --git a/src/runtime/defs_linux_386.go b/src/runtime/defs_linux_386.go
@@ -146,7 +146,8 @@ type timespec32 struct {
 
 //go:nosplit
 func (ts *timespec32) setNsec(ns int64) {
-	ts.tv_sec = timediv(ns, 1e9, &ts.tv_nsec)
+	ts.tv_sec = int32(ns / 1e9)
+	ts.tv_nsec = int32(ns % 1e9)
 }
 
 type timespec struct {
@@ -156,9 +157,8 @@ type timespec struct {
 
 //go:nosplit
 func (ts *timespec) setNsec(ns int64) {
-	var newNS int32
-	ts.tv_sec = int64(timediv(ns, 1e9, &newNS))
-	ts.tv_nsec = int64(newNS)
+	ts.tv_sec = int64(ns / 1e9)
+	ts.tv_nsec = int64(ns % 1e9)
 }
 
 type timeval struct {
diff --git a/src/runtime/defs_linux_arm.go b/src/runtime/defs_linux_arm.go
@@ -105,7 +105,8 @@ type timespec32 struct {
 
 //go:nosplit
 func (ts *timespec32) setNsec(ns int64) {
-	ts.tv_sec = timediv(ns, 1e9, &ts.tv_nsec)
+	ts.tv_sec = int32(ns / 1e9)
+	ts.tv_nsec = int32(ns % 1e9)
 }
 
 type timespec struct {
@@ -115,9 +116,8 @@ type timespec struct {
 
 //go:nosplit
 func (ts *timespec) setNsec(ns int64) {
-	var newNS int32
-	ts.tv_sec = int64(timediv(ns, 1e9, &newNS))
-	ts.tv_nsec = int64(newNS)
+	ts.tv_sec = int64(ns / 1e9)
+	ts.tv_nsec = int64(ns % 1e9)
 }
 
 type stackt struct {
diff --git a/src/runtime/defs_linux_mipsx.go b/src/runtime/defs_linux_mipsx.go
@@ -103,7 +103,8 @@ type timespec32 struct {
 
 //go:nosplit
 func (ts *timespec32) setNsec(ns int64) {
-	ts.tv_sec = timediv(ns, 1e9, &ts.tv_nsec)
+	ts.tv_sec = int32(ns / 1e9)
+	ts.tv_nsec = int32(ns % 1e9)
 }
 
 type timespec struct {
@@ -113,9 +114,8 @@ type timespec struct {
 
 //go:nosplit
 func (ts *timespec) setNsec(ns int64) {
-	var newNS int32
-	ts.tv_sec = int64(timediv(ns, 1e9, &newNS))
-	ts.tv_nsec = int64(newNS)
+	ts.tv_sec = int64(ns / 1e9)
+	ts.tv_nsec = int64(ns % 1e9)
 }
 
 type timeval struct {
diff --git a/src/runtime/defs_openbsd_386.go b/src/runtime/defs_openbsd_386.go
@@ -147,7 +147,8 @@ type timespec struct {
 
 //go:nosplit
 func (ts *timespec) setNsec(ns int64) {
-	ts.tv_sec = int64(timediv(ns, 1e9, &ts.tv_nsec))
+	ts.tv_sec = int64(ns / 1e9)
+	ts.tv_nsec = int32(ns % 1e9)
 }
 
 type timeval struct {
diff --git a/src/runtime/defs_openbsd_arm.go b/src/runtime/defs_openbsd_arm.go
@@ -152,7 +152,8 @@ type timespec struct {
 
 //go:nosplit
 func (ts *timespec) setNsec(ns int64) {
-	ts.tv_sec = int64(timediv(ns, 1e9, &ts.tv_nsec))
+	ts.tv_sec = int64(ns / 1e9)
+	ts.tv_nsec = int32(ns % 1e9)
 }
 
 type timeval struct {
diff --git a/src/runtime/export_test.go b/src/runtime/export_test.go
@@ -1472,8 +1472,6 @@ func Releasem() {
 	releasem(getg().m)
 }
 
-var Timediv = timediv
-
 type PIController struct {
 	piController
 }
diff --git a/src/runtime/os_dragonfly.go b/src/runtime/os_dragonfly.go
@@ -113,7 +113,7 @@ func futexsleep1(addr *uint32, val uint32, ns int64) {
 		// The timeout is specified in microseconds - ensure that we
 		// do not end up dividing to zero, which would put us to sleep
 		// indefinitely...
-		timeout = timediv(ns, 1000, nil)
+		timeout = int32(ns / 1000)
 		if timeout == 0 {
 			timeout = 1
 		}
diff --git a/src/runtime/os_plan9.go b/src/runtime/os_plan9.go
@@ -486,7 +486,7 @@ func semacreate(mp *m) {
 func semasleep(ns int64) int {
 	gp := getg()
 	if ns >= 0 {
-		ms := timediv(ns, 1000000, nil)
+		ms := int32(ns / 1000000)
 		if ms == 0 {
 			ms = 1
 		}
diff --git a/src/runtime/os_windows.go b/src/runtime/os_windows.go
@@ -664,7 +664,7 @@ func semasleep(ns int64) int32 {
 		start := nanotime()
 		elapsed := int64(0)
 		for {
-			ms := int64(timediv(ns-elapsed, 1000000, nil))
+			ms := (ns - elapsed) / 1000000
 			if ms == 0 {
 				ms = 1
 			}
diff --git a/src/runtime/runtime1.go b/src/runtime/runtime1.go
@@ -212,10 +212,6 @@ func check() {
 		throw("bad unsafe.Sizeof y1")
 	}
 
-	if timediv(12345*1000000000+54321, 1000000000, &e) != 12345 || e != 54321 {
-		throw("bad timediv")
-	}
-
 	var z uint32
 	z = 1
 	if !atomic.Cas(&z, 1, 2) {
@@ -593,35 +589,6 @@ func setTraceback(level string) {
 	atomic.Store(&traceback_cache, t)
 }
 
-// Poor mans 64-bit division.
-// This is a very special function, do not use it if you are not sure what you are doing.
-// int64 division is lowered into _divv() call on 386, which does not fit into nosplit functions.
-// Handles overflow in a time-specific manner.
-// This keeps us within no-split stack limits on 32-bit processors.
-//
-//go:nosplit
-func timediv(v int64, div int32, rem *int32) int32 {
-	res := int32(0)
-	for bit := 30; bit >= 0; bit-- {
-		if v >= int64(div)<<uint(bit) {
-			v = v - (int64(div) << uint(bit))
-			// Before this for loop, res was 0, thus all these
-			// power of 2 increments are now just bitsets.
-			res |= 1 << uint(bit)
-		}
-	}
-	if v >= int64(div) {
-		if rem != nil {
-			*rem = 0
-		}
-		return 0x7fffffff
-	}
-	if rem != nil {
-		*rem = int32(v)
-	}
-	return res
-}
-
 // Helpers for Go. Must be NOSPLIT, must only call NOSPLIT functions, and must not block.
 
 //go:nosplit
diff --git a/src/runtime/runtime_test.go b/src/runtime/runtime_test.go
@@ -6,7 +6,6 @@ package runtime_test
 
 import (
 	"flag"
-	"fmt"
 	"internal/asan"
 	"internal/cpu"
 	"internal/msan"
@@ -498,81 +497,6 @@ func TestVersion(t *testing.T) {
 	}
 }
 
-func TestTimediv(t *testing.T) {
-	for _, tc := range []struct {
-		num int64
-		div int32
-		ret int32
-		rem int32
-	}{
-		{
-			num: 8,
-			div: 2,
-			ret: 4,
-			rem: 0,
-		},
-		{
-			num: 9,
-			div: 2,
-			ret: 4,
-			rem: 1,
-		},
-		{
-			// Used by runtime.check.
-			num: 12345*1000000000 + 54321,
-			div: 1000000000,
-			ret: 12345,
-			rem: 54321,
-		},
-		{
-			num: 1<<32 - 1,
-			div: 2,
-			ret: 1<<31 - 1, // no overflow.
-			rem: 1,
-		},
-		{
-			num: 1 << 32,
-			div: 2,
-			ret: 1<<31 - 1, // overflow.
-			rem: 0,
-		},
-		{
-			num: 1 << 40,
-			div: 2,
-			ret: 1<<31 - 1, // overflow.
-			rem: 0,
-		},
-		{
-			num: 1<<40 + 1,
-			div: 1 << 10,
-			ret: 1 << 30,
-			rem: 1,
-		},
-	} {
-		name := fmt.Sprintf("%d div %d", tc.num, tc.div)
-		t.Run(name, func(t *testing.T) {
-			// Double check that the inputs make sense using
-			// standard 64-bit division.
-			ret64 := tc.num / int64(tc.div)
-			rem64 := tc.num % int64(tc.div)
-			if ret64 != int64(int32(ret64)) {
-				// Simulate timediv overflow value.
-				ret64 = 1<<31 - 1
-				rem64 = 0
-			}
-			if ret64 != int64(tc.ret) {
-				t.Errorf("%d / %d got ret %d rem %d want ret %d rem %d", tc.num, tc.div, ret64, rem64, tc.ret, tc.rem)
-			}
-
-			var rem int32
-			ret := Timediv(tc.num, tc.div, &rem)
-			if ret != tc.ret || rem != tc.rem {
-				t.Errorf("timediv %d / %d got ret %d rem %d want ret %d rem %d", tc.num, tc.div, ret, rem, tc.ret, tc.rem)
-			}
-		})
-	}
-}
-
 func BenchmarkProcYield(b *testing.B) {
 	benchN := func(n uint32) func(*testing.B) {
 		return func(b *testing.B) {

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,8 @@ type timespec struct {`
`121`	`121`
`122`	`122`	`//go:nosplit`
`123`	`123`	`func (ts *timespec) setNsec(ns int64) {`
`124`		`- ts.tv_sec = int64(timediv(ns, 1e9, &ts.tv_nsec))`
	`124`	`+ ts.tv_sec = int64(ns / 1e9)`
	`125`	`+ ts.tv_nsec = int32(ns % 1e9)`
`125`	`126`	`}`
`126`	`127`
`127`	`128`	`type timeval struct {`
Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,8 @@ type timespec struct {`
`123`	`123`
`124`	`124`	`//go:nosplit`
`125`	`125`	`func (ts *timespec) setNsec(ns int64) {`
`126`		`- ts.tv_sec = int64(timediv(ns, 1e9, &ts.tv_nsec))`
	`126`	`+ ts.tv_sec = int64(ns / 1e9)`
	`127`	`+ ts.tv_nsec = int32(ns % 1e9)`
`127`	`128`	`}`
`128`	`129`
`129`	`130`	`type timeval struct {`
Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,8 @@ type timespec struct {`
`147`	`147`
`148`	`148`	`//go:nosplit`
`149`	`149`	`func (ts *timespec) setNsec(ns int64) {`
`150`		`- ts.tv_sec = int64(timediv(ns, 1e9, &ts.tv_nsec))`
	`150`	`+ ts.tv_sec = int64(ns / 1e9)`
	`151`	`+ ts.tv_nsec = int32(ns % 1e9)`
`151`	`152`	`}`
`152`	`153`
`153`	`154`	`type timeval struct {`
Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,8 @@ type timespec struct {`
`152`	`152`
`153`	`153`	`//go:nosplit`
`154`	`154`	`func (ts *timespec) setNsec(ns int64) {`
`155`		`- ts.tv_sec = int64(timediv(ns, 1e9, &ts.tv_nsec))`
	`155`	`+ ts.tv_sec = int64(ns / 1e9)`
	`156`	`+ ts.tv_nsec = int32(ns % 1e9)`
`156`	`157`	`}`
`157`	`158`
`158`	`159`	`type timeval struct {`
Original file line number	Diff line number	Diff line change
`@@ -1472,8 +1472,6 @@ func Releasem() {`
`1472`	`1472`	`releasem(getg().m)`
`1473`	`1473`	`}`
`1474`	`1474`
`1475`		`-var Timediv = timediv`
`1476`		`-`
`1477`	`1475`	`type PIController struct {`
`1478`	`1476`	`piController`
`1479`	`1477`	`}`