feat: close only after ICE restart

this prevents possible spurious ICE restarts on disconnect

Author: lherman-cs

demo-react/src/App.tsx

@@ -328,7 +328,7 @@ function ChatDialog(props: ChatDialogProps) {
           const date = new Date(Number.parseInt(ts));
 
           return (
-            <nav>
+            <nav key={key}>
               <button className="circle capitalize">
                 {peerId.substring(0, 1)}
               </button>

peer/src/session.ts

@@ -75,19 +75,19 @@ export class Session {
   /**
    * See {@link https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/ondatachannel}
    */
-  public ondatachannel: RTCPeerConnection["ondatachannel"] = () => {};
+  public ondatachannel: RTCPeerConnection["ondatachannel"] = () => { };
 
   /**
    * See {@link https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/onconnectionstatechange}
    */
   public onconnectionstatechange: RTCPeerConnection["onconnectionstatechange"] =
-    () => {};
+    () => { };
 
   /**
    * Callback invoked when a new media track is added to the connection.
    * See {@link https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/ontrack}
    */
-  public ontrack: RTCPeerConnection["ontrack"] = () => {};
+  public ontrack: RTCPeerConnection["ontrack"] = () => { };
 
   /**
    * Adds a media track to the connection.
@@ -183,6 +183,7 @@ export class Session {
 
     this.logger.debug("session closed", {
       connectionState: this.connectionState,
+      reason,
     });
   }
 
@@ -274,10 +275,9 @@ export class Session {
           break;
         }
         case "disconnected":
-          this.triggerIceRestart();
           break;
         case "failed":
-          this.close("connection failed");
+          this.triggerIceRestart();
           break;
         case "closed":
           break;
@@ -423,9 +423,9 @@ export class Session {
   }
 
   private triggerIceRestart = () => {
-    // the impolite offer will trigger the polite peer's to also restart Ice
-    if (!this.impolite) return;
-
+    // // the impolite offer will trigger the polite peer's to also restart Ice
+    // if (!this.impolite) return;
+    //
     const elapsed = performance.now() - this.lastIceRestart;
     if (elapsed < ICE_RESTART_DEBOUNCE_DELAY_MS) {
       // schedule ice restart after some delay;

peer/src/store.ts

@@ -140,13 +140,10 @@ export class PeerStore {
         if (sess.connectionState === "closed") {
           const current = this.$_remotePeers.get();
           delete current[id];
-          this.$_remotePeers.set({ ...current });
-          return;
-        }
-
-        if (sess.connectionState === "failed") {
           delete this.sendChannels[id];
           console.log(`connection failed, removed ${id}`);
+          this.$_remotePeers.set({ ...current });
+          return;
         }
 
         const remotePeer = this.$_remotePeers.get()[id];