add safeguard to unrecoverable analytics

Author: lherman-cs

peer/proto

@@ -1,4 +1,6 @@
 // @ts-nocheck
+// @ts-nocheck
+// @ts-nocheck
 // @generated by protobuf-ts 2.9.4 with parameter client_generic
 // @generated from protobuf file "google/protobuf/timestamp.proto" (package "google.protobuf", syntax proto3)
 // tslint:disable

peer/src/google/protobuf/timestamp.ts

@@ -15,11 +15,10 @@ import {
 import { asleep, retry } from "./util.ts";
 import { jwtDecode } from "jwt-decode";
 import { calculateWebRTCQuality, collectWebRTCStats } from "./quality.ts";
-import { Timestamp } from "./google/protobuf/timestamp.ts";
 
 export type { PeerInfo } from "./signaling.ts";
 
-const ANALYTICS_POLL_INTERVAL_MS = 5_000;
+const ANALYTICS_POLL_INTERVAL_MS = 60_000;
 
 /**
  * Streamline real-time application development.`@pulsebeam/peer` abstracts
@@ -327,12 +326,12 @@ export class Peer {
       const events: AnalyticsEvent[] = [];
       for (const sess of this.sessions) {
         const rawStats = await sess.getStats();
-        const at = Timestamp.now();
+        const at = Date.now() * 1_000;
         const stats = collectWebRTCStats(rawStats);
         const quality = calculateWebRTCQuality(stats);
 
         events.push({
-          timestamp: at,
+          timestampUs: BigInt(at),
           tags: {
             src: this.transport.info,
             dst: sess.other,

peer/src/peer.ts

@@ -92,7 +92,8 @@ export function calculateWebRTCQuality(stats: WebRTCStats): number {
   };
 
   const aggregateAndScore = (channelStats: ChannelStats[]): number => {
-    if (channelStats.length === 0) return 100;
+    // no data, we assume not connecting
+    if (channelStats.length === 0) return 0;
 
     const aggregated = aggregateChannelStats(channelStats);
 

peer/src/quality.ts

@@ -3,7 +3,6 @@
 // tslint:disable
 import { ServiceType } from "@protobuf-ts/runtime-rpc";
 import { MessageType } from "@protobuf-ts/runtime";
-import { Timestamp } from "./google/protobuf/timestamp.ts";
 /**
  * @generated from protobuf message pulsebeam.v1.PrepareReq
  */
@@ -326,9 +325,9 @@ export interface AnalyticsReportReq {
  */
 export interface AnalyticsEvent {
     /**
-     * @generated from protobuf field: google.protobuf.Timestamp timestamp = 1;
+     * @generated from protobuf field: sint64 timestamp_us = 1;
      */
-    timestamp?: Timestamp;
+    timestampUs: bigint;
     /**
      * @generated from protobuf field: pulsebeam.v1.AnalyticsTags tags = 2;
      */
@@ -688,7 +687,7 @@ export const AnalyticsReportReq = new AnalyticsReportReq$Type();
 class AnalyticsEvent$Type extends MessageType<AnalyticsEvent> {
     constructor() {
         super("pulsebeam.v1.AnalyticsEvent", [
-            { no: 1, name: "timestamp", kind: "message", T: () => Timestamp },
+            { no: 1, name: "timestamp_us", kind: "scalar", T: 18 /*ScalarType.SINT64*/, L: 0 /*LongType.BIGINT*/ },
             { no: 2, name: "tags", kind: "message", T: () => AnalyticsTags },
             { no: 3, name: "metrics", kind: "message", T: () => AnalyticsMetrics }
         ]);

peer/src/signaling.ts

@@ -15,6 +15,9 @@ const POLL_TIMEOUT_MS = 900000;
 const POLL_RETRY_BASE_DELAY_MS = 50;
 const POLL_RETRY_MAX_DELAY_MS = 1000;
 
+const ANALYTICS_POLL_RETRY_BASE_DELAY_MS = 1000;
+const ANALYTICS_POLL_RETRY_MAX_DELAY_MS = 4000;
+
 export enum ReservedConnId {
   Discovery = 0,
   Max = 16,
@@ -339,9 +342,9 @@ export class Transport {
       timeout: POLL_TIMEOUT_MS,
     };
     const retryOpt: RetryOptions = {
-      baseDelay: POLL_RETRY_BASE_DELAY_MS,
-      maxDelay: POLL_RETRY_MAX_DELAY_MS,
-      maxRetries: -1,
+      baseDelay: ANALYTICS_POLL_RETRY_BASE_DELAY_MS,
+      maxDelay: ANALYTICS_POLL_RETRY_MAX_DELAY_MS,
+      maxRetries: 3,
       abortSignal: this.abort.signal,
       isRecoverable: this.isRecoverable,
     };
@@ -360,8 +363,10 @@ export class Transport {
 
       return;
     } catch (err) {
-      this.logger.error("unrecoverable error, force closing", { err });
-      this.close();
+      this.logger.error(
+        "analytics backend is in unrecoverable state, dropping analytics event",
+        { err },
+      );
       return;
     }
   }