remove external participant id coupling

Author: lherman-cs

pulsebeam/src/entity.rs

@@ -194,23 +194,13 @@ impl AsRef<str> for ExternalRoomId {
 }
 
 pub struct ParticipantId {
-    pub external: ExternalParticipantId,
     pub internal: EntityId,
 }
 
 impl ParticipantId {
-    pub fn new(external: ExternalParticipantId) -> Self {
+    pub fn new() -> Self {
         let internal = new_entity_id(prefix::PARTICIPANT_ID);
-        Self { external, internal }
-    }
-}
-
-impl TryFrom<&str> for ParticipantId {
-    type Error = IdValidationError;
-
-    fn try_from(value: &str) -> Result<Self, Self::Error> {
-        let external = ExternalParticipantId::from_str(value)?;
-        Ok(Self::new(external))
+        Self { internal }
     }
 }
 
@@ -469,15 +459,10 @@ mod tests {
     #[test]
     fn test_participant_id_equality_and_hash() {
         let internal = "pa_xyz987".to_string();
-        let ext = ExternalParticipantId::new("external_pa".into()).unwrap();
         let id1 = ParticipantId {
-            external: ext.clone(),
             internal: internal.clone(),
         };
-        let id2 = ParticipantId {
-            external: ext,
-            internal,
-        };
+        let id2 = ParticipantId { internal };
 
         assert_eq!(id1, id2);
         use std::collections::hash_map::DefaultHasher;
@@ -487,12 +472,4 @@ mod tests {
         id2.hash(&mut h2);
         assert_eq!(h1.finish(), h2.finish());
     }
-
-    #[test]
-    fn test_participant_id_equality_multiple() {
-        let ext = ExternalParticipantId::new("external_pa".into()).unwrap();
-        let participant_id1 = ParticipantId::new(ext.clone());
-        let participant_id2 = ParticipantId::new(ext);
-        assert_ne!(participant_id1, participant_id2);
-    }
 }

pulsebeam/src/signaling.rs

@@ -1,8 +1,5 @@
 use crate::entity::{ParticipantId, RoomId};
-use crate::{
-    controller,
-    entity::{ExternalParticipantId, ExternalRoomId},
-};
+use crate::{controller, entity::ExternalRoomId};
 use axum::{
     Router,
     extract::{Query, State},
@@ -54,7 +51,6 @@ impl IntoResponse for SignalingError {
 #[derive(serde::Deserialize, serde::Serialize, Debug)]
 pub struct ParticipantInfo {
     room: ExternalRoomId,
-    participant: ExternalParticipantId,
 }
 
 #[axum::debug_handler]
@@ -67,7 +63,7 @@ async fn spawn_participant(
     // TODO: validate content_type = "application/sdp"
 
     let room_id = RoomId::new(info.room);
-    let participant_id = ParticipantId::new(info.participant);
+    let participant_id = ParticipantId::new();
     tracing::info!("allocated {} to {}", participant_id, room_id);
 
     // TODO: better unique ID to handle session.

pulsebeam/src/test_utils.rs

@@ -5,8 +5,7 @@ use pulsebeam_runtime::net;
 use str0m::media::Mid;
 
 pub fn create_participant_id() -> Arc<entity::ParticipantId> {
-    let external = entity::ExternalParticipantId::new(entity::new_random_id("tp", 10)).unwrap();
-    let participant_id = entity::ParticipantId::new(external);
+    let participant_id = entity::ParticipantId::new();
     Arc::new(participant_id)
 }