Skip to content

Commit b45e65e

Browse files
committed
revert loss based quality
1 parent 690c3d0 commit b45e65e

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

pulsebeam/src/rtp/monitor.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -249,8 +249,10 @@ impl StreamMonitor {
249249
}
250250

251251
let jitter_score = metrics.calculate_jitter_score();
252-
let loss_score = metrics.calculate_loss_score();
253-
let quality_score = jitter_score.min(loss_score);
252+
// TODO: loss_score is too noisy to be usable, needs to stabilize this first.
253+
// let loss_score = metrics.calculate_loss_score();
254+
// let quality_score = jitter_score.min(loss_score);
255+
let quality_score = jitter_score;
254256

255257
let new_quality = metrics.quality_hysteresis(quality_score, self.current_quality);
256258
if new_quality == self.current_quality {
@@ -289,13 +291,11 @@ impl StreamMonitor {
289291
// Finally, commit the state change.
290292
tracing::info!(
291293
stream_id = %self.stream_id,
292-
"Stream quality transition: {:?} -> {:?} (score: {:.1}, jitter_score: {:.1}, loss_score: {:.1}, loss: {:.2}%, m_hat: {:.3}, bitrate: {})",
294+
"Stream quality transition: {:?} -> {:?} (score: {:.1}, jitter_score: {:.1}, m_hat: {:.3}, bitrate: {})",
293295
self.current_quality,
294296
new_quality,
295297
quality_score,
296298
jitter_score,
297-
loss_score,
298-
metrics.packet_loss() * 100.0,
299299
metrics.m_hat,
300300
Bitrate::from(self.bwe.bwe_bps_ewma),
301301
);

0 commit comments

Comments
 (0)