Merge pull request #151 from PureStorage-OpenConnect/150-fix-arrays_space_collectorgo-when-aspacesystem-=-nil-on-eg1-arrays

Fix arrays_space_collector.go when a.Space.System = nil on EG1 arrays

Author: sdodsley

internal/openmetrics-exporter/arrays_space_collector.go

@@ -134,16 +134,29 @@ func (c *ArraySpaceCollector) Collect(ch chan<- prometheus.Metric) {
 			float64(*a.Space.TotalEffective), "total_effective",
 		)
 	}
-	ch <- prometheus.MustNewConstMetric(
-		c.SpaceDesc,
-		prometheus.GaugeValue,
-		a.Capacity-(float64(*a.Space.System)+float64(*a.Space.Replication)+float64(*a.Space.Shared)+float64(*a.Space.Snapshots)+float64(*a.Space.Unique)), "empty",
-	)
-	ch <- prometheus.MustNewConstMetric(
-		c.UtilizationDesc,
-		prometheus.GaugeValue,
-		(float64(*a.Space.System)+float64(*a.Space.Replication)+float64(*a.Space.Shared)+float64(*a.Space.Snapshots)+float64(*a.Space.Unique))/a.Capacity*100,
-	)
+	if a.Space.System != nil {
+		ch <- prometheus.MustNewConstMetric(
+			c.SpaceDesc,
+			prometheus.GaugeValue,
+			a.Capacity-(float64(*a.Space.System)+float64(*a.Space.Replication)+float64(*a.Space.Shared)+float64(*a.Space.Snapshots)+float64(*a.Space.Unique)), "empty",
+		)
+		ch <- prometheus.MustNewConstMetric(
+			c.UtilizationDesc,
+			prometheus.GaugeValue,
+			(float64(*a.Space.System)+float64(*a.Space.Replication)+float64(*a.Space.Shared)+float64(*a.Space.Snapshots)+float64(*a.Space.Unique))/a.Capacity*100,
+		)
+	} else {
+		ch <- prometheus.MustNewConstMetric(
+			c.SpaceDesc,
+			prometheus.GaugeValue,
+			a.Capacity-(float64(*a.Space.Replication)+float64(*a.Space.Shared)+float64(*a.Space.Snapshots)+float64(*a.Space.Unique)), "empty",
+		)
+		ch <- prometheus.MustNewConstMetric(
+			c.UtilizationDesc,
+			prometheus.GaugeValue,
+			(float64(*a.Space.Replication)+float64(*a.Space.Shared)+float64(*a.Space.Snapshots)+float64(*a.Space.Unique))/a.Capacity*100,
+		)
+	}
 }
 
 func NewArraySpaceCollector(fa *client.FAClient) *ArraySpaceCollector {