Update pod_replica_links_lag_collector.go

Author: chrroberts-pure

internal/openmetrics-exporter/pod_replica_links_lag_collector.go

@@ -1,14 +1,17 @@
 package collectors
 
-
 import (
+	client "purestorage/fa-openmetrics-exporter/internal/rest-client"
+
 	"github.com/prometheus/client_golang/prometheus"
-	"purestorage/fa-openmetrics-exporter/internal/rest-client"
 )
 
 type PodReplicaLinksLagCollector struct {
-	AvgLagDesc    *prometheus.Desc
-	MaxLagDesc    *prometheus.Desc
+	AvgLagDesc *prometheus.Desc
+	MaxLagDesc *prometheus.Desc
+	// AvgLagSecDesc & MaxLagSecDesc can be removed after 1.0.19
+	AvgLagSecDesc *prometheus.Desc
+	MaxLagSecDesc *prometheus.Desc
 	Client        *client.FAClient
 }
 
@@ -34,20 +37,46 @@ func (c *PodReplicaLinksLagCollector) Collect(ch chan<- prometheus.Metric) {
 			p.Lag.Max,
 			p.Remotes[0].Name, p.LocalPod.Name, p.RemotePod.Name, p.Direction, p.Status,
 		)
+		// AvgLagSecDesc & MaxLagSecDesc can be removed after 1.0.19
+		ch <- prometheus.MustNewConstMetric(
+			c.AvgLagSecDesc,
+			prometheus.GaugeValue,
+			p.Lag.Avg,
+			p.Remotes[0].Name, p.LocalPod.Name, p.RemotePod.Name, p.Direction, p.Status,
+		)
+		ch <- prometheus.MustNewConstMetric(
+			c.MaxLagSecDesc,
+			prometheus.GaugeValue,
+			p.Lag.Max,
+			p.Remotes[0].Name, p.LocalPod.Name, p.RemotePod.Name, p.Direction, p.Status,
+		)
 	}
 }
 
 func NewPodReplicaLinksLagCollector(fa *client.FAClient) *PodReplicaLinksLagCollector {
 	return &PodReplicaLinksLagCollector{
 		AvgLagDesc: prometheus.NewDesc(
-			"purefa_pod_replica_links_lag_average_sec",
-			"FlashArray pod links average lag seconds",
+			"purefa_pod_replica_links_lag_average_msec",
+			"FlashArray pod links average lag in milliseconds",
 			[]string{"remote", "local_pod", "remote_pod", "direction", "status"},
 			prometheus.Labels{},
 		),
 		MaxLagDesc: prometheus.NewDesc(
+			"purefa_pod_replica_links_lag_max_msec",
+			"FlashArray pod links max lag in milliseconds",
+			[]string{"remote", "local_pod", "remote_pod", "direction", "status"},
+			prometheus.Labels{},
+		),
+		// AvgLagSecDesc & MaxLagSecDesc can be removed after 1.0.19
+		AvgLagSecDesc: prometheus.NewDesc(
+			"purefa_pod_replica_links_lag_average_sec",
+			"FlashArray pod links average lag in milliseconds (deprecated, please use purefa_pod_replica_links_lag_average_msec)",
+			[]string{"remote", "local_pod", "remote_pod", "direction", "status"},
+			prometheus.Labels{},
+		),
+		MaxLagSecDesc: prometheus.NewDesc(
 			"purefa_pod_replica_links_lag_max_sec",
-			"FlashArray pod links max lag seconds",
+			"FlashArray pod links max lag in milliseconds (deprecated, please use purefa_pod_replica_links_lag_max_msec)",
 			[]string{"remote", "local_pod", "remote_pod", "direction", "status"},
 			prometheus.Labels{},
 		),