Skip to content

Commit fc92306

Browse files
sdodsleysdodsley
authored
Merge pull request #129 from PureStorage-OpenConnect/118-podreplicalink-is-not-in-seconds
Update purefa_pod_replica_links_lag_[max|avg]_sec to reflect the correct units of milliseconds.
2 parents 6a23ddd + c0eccf9 commit fc92306

File tree

2 files changed

+86
-55
lines changed

2 files changed

+86
-55
lines changed

‎README.md‎

Lines changed: 50 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -266,54 +266,56 @@ purefa_info{array_name="arrayname",os="Purity//FA",system_id="xxxxxxxx-xxxx-xxxx
266266

267267
Please refer to the [purefa metrics specification](specification/metrics/purefa-metrics.md) for full details about all metrics.
268268

269-
| Metric Name | Description |
270-
| ---------------------------------------------------- | -------------------------------------------------------------- |
271-
| purefa_info | FlashArray system information |
272-
| purefa_alerts_open | FlashArray open alert events |
273-
| purefa_array_performance_average_bytes | FlashArray array average operations size in bytes |
274-
| purefa_array_performance_bandwidth_bytes | FlashArray array throughput in bytes per second |
275-
| purefa_array_performance_latency_usec | FlashArray array latency in microseconds |
276-
| purefa_array_performance_queue_depth_ops | FlashArray array queue depth size |
277-
| purefa_array_performance_throughput_iops | FlashArray array throughput in iops |
278-
| purefa_array_space_bytes | FlashArray array space in bytes |
279-
| purefa_array_space_data_reduction_ratio | FlashArray array space data reduction |
280-
| purefa_array_space_utilization | FlashArray array space utilization in percent |
281-
| purefa_directory_performance_average_bytes | FlashArray directory average operations size in bytes |
282-
| purefa_directory_performance_bandwidth_bytes | FlashArray directory throughput in bytes per second |
283-
| purefa_directory_performance_latency_usec | FlashArray directory latency in microseconds |
284-
| purefa_directory_performance_throughput_iops | FlashArray directory throughput in iops |
285-
| purefa_directory_space_bytes | FlashArray directory space in bytes |
286-
| purefa_directory_space_data_reduction_ratio | FlashArray directory space data reduction |
287-
| purefa_host_connections_info | FlashArray host volumes connections |
288-
| purefa_host_performance_average_bytes | FlashArray host average operations size in bytes |
289-
| purefa_host_performance_bandwidth_bytes | FlashArray host bandwidth in bytes per second |
290-
| purefa_host_performance_latency_usec | FlashArray host latency in microseconds |
291-
| purefa_host_performance_throughput_iops | FlashArray host throughput in iops |
292-
| purefa_host_space_bytes | FlashArray host space in bytes |
293-
| purefa_host_space_data_reduction_ratio | FlashArray host space data reduction |
294-
| purefa_host_space_size_bytes | FlashArray host volumes size |
295-
| purefa_hw_component_status | FlashArray hardware component status |
296-
| purefa_hw_component_temperature_celsius | FlashArray hardware component temperature in C |
297-
| purefa_hw_component_voltage_volt | FlashArray hardware component voltage |
298-
| purefa_network_interface_performance_bandwidth_bytes | network interfaces bandwidth in bytes per second |
299-
| purefa_network_interface_performance_throughput_pkts | FlashArray network interfaces throughput in packets per second |
300-
| purefa_network_interface_performance_errors | FlashArray network interfaces errors per second |
301-
| purefa_pod_performance_average_bytes | FlashArray pod average operations size |
302-
| purefa_pod_performance_bandwidth_bytes | FlashArray pod throughput in bytes per second |
303-
| purefa_pod_performance_latency_usec | FlashArray pod latency in microseconds |
304-
| purefa_pod_performance_throughput_iops | FlashArray pod throughput in iops |
305-
| purefa_pod_space_bytes | FlashArray pod space in bytes |
306-
| purefa_pod_space_data_reduction_ratio | FlashArray pod space data reduction |
307-
| purefa_pod_performance_replication_bandwidth_bytes | FlashArray pod replication bandwidth in bytes per second |
308-
| purefa_pod_replica_links_performance_bandwidth_bytes | FlashArray pod replica links throughput in bytes per second |
309-
| purefa_pod_replica_links_lag_average_sec | FlashArray pod replica links average lag in seconds |
310-
| purefa_pod_replica_links_lag_max_sec | FlashArray pod replica links maximum lag in seconds |
311-
| purefa_volume_performance_average_bytes | FlashArray volume average operations size in bytes |
312-
| purefa_volume_performance_bandwidth_bytes | FlashArray volume throughput in bytes per second |
313-
| purefa_volume_performance_latency_usec | FlashArray volume latency in microseconds |
314-
| purefa_volume_performance_throughput_iops | FlashArray volume throughput in iops |
315-
| purefa_volume_space_bytes | FlashArray volume space in bytes |
316-
| purefa_volume_space_data_reduction_ratio | FlashArray volume space data reduction |
269+
| Metric Name | Description |
270+
| ---------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------- |
271+
| purefa_info | FlashArray system information |
272+
| purefa_alerts_open | FlashArray open alert events |
273+
| purefa_array_performance_average_bytes | FlashArray array average operations size in bytes |
274+
| purefa_array_performance_bandwidth_bytes | FlashArray array throughput in bytes per second |
275+
| purefa_array_performance_latency_usec | FlashArray array latency in microseconds |
276+
| purefa_array_performance_queue_depth_ops | FlashArray array queue depth size |
277+
| purefa_array_performance_throughput_iops | FlashArray array throughput in iops |
278+
| purefa_array_space_bytes | FlashArray array space in bytes |
279+
| purefa_array_space_data_reduction_ratio | FlashArray array space data reduction |
280+
| purefa_array_space_utilization | FlashArray array space utilization in percent |
281+
| purefa_directory_performance_average_bytes | FlashArray directory average operations size in bytes |
282+
| purefa_directory_performance_bandwidth_bytes | FlashArray directory throughput in bytes per second |
283+
| purefa_directory_performance_latency_usec | FlashArray directory latency in microseconds |
284+
| purefa_directory_performance_throughput_iops | FlashArray directory throughput in iops |
285+
| purefa_directory_space_bytes | FlashArray directory space in bytes |
286+
| purefa_directory_space_data_reduction_ratio | FlashArray directory space data reduction |
287+
| purefa_host_connections_info | FlashArray host volumes connections |
288+
| purefa_host_performance_average_bytes | FlashArray host average operations size in bytes |
289+
| purefa_host_performance_bandwidth_bytes | FlashArray host bandwidth in bytes per second |
290+
| purefa_host_performance_latency_usec | FlashArray host latency in microseconds |
291+
| purefa_host_performance_throughput_iops | FlashArray host throughput in iops |
292+
| purefa_host_space_bytes | FlashArray host space in bytes |
293+
| purefa_host_space_data_reduction_ratio | FlashArray host space data reduction |
294+
| purefa_host_space_size_bytes | FlashArray host volumes size |
295+
| purefa_hw_component_status | FlashArray hardware component status |
296+
| purefa_hw_component_temperature_celsius | FlashArray hardware component temperature in C |
297+
| purefa_hw_component_voltage_volt | FlashArray hardware component voltage |
298+
| purefa_network_interface_performance_bandwidth_bytes | network interfaces bandwidth in bytes per second |
299+
| purefa_network_interface_performance_throughput_pkts | FlashArray network interfaces throughput in packets per second |
300+
| purefa_network_interface_performance_errors | FlashArray network interfaces errors per second |
301+
| purefa_pod_performance_average_bytes | FlashArray pod average operations size |
302+
| purefa_pod_performance_bandwidth_bytes | FlashArray pod throughput in bytes per second |
303+
| purefa_pod_performance_latency_usec | FlashArray pod latency in microseconds |
304+
| purefa_pod_performance_throughput_iops | FlashArray pod throughput in iops |
305+
| purefa_pod_space_bytes | FlashArray pod space in bytes |
306+
| purefa_pod_space_data_reduction_ratio | FlashArray pod space data reduction |
307+
| purefa_pod_performance_replication_bandwidth_bytes | FlashArray pod replication bandwidth in bytes per second |
308+
| purefa_pod_replica_links_performance_bandwidth_bytes | FlashArray pod replica links throughput in bytes per second |
309+
| purefa_pod_replica_links_lag_average_sec | FlashArray pod replica links average lag in milliseconds (deprecated, please use purefa_pod_replica_links_lag_average_msec) |
310+
| purefa_pod_replica_links_lag_max_sec | FlashArray pod replica links maximum lag in milliseconds (deprecated, please use purefa_pod_replica_links_lag_average_msec) |
311+
| purefa_pod_replica_links_lag_average_msec | FlashArray pod replica links average lag in milliseconds |
312+
| purefa_pod_replica_links_lag_max_msec | FlashArray pod replica links maximum lag in in milliseconds |
313+
| purefa_volume_performance_average_bytes | FlashArray volume average operations size in bytes |
314+
| purefa_volume_performance_bandwidth_bytes | FlashArray volume throughput in bytes per second |
315+
| purefa_volume_performance_latency_usec | FlashArray volume latency in microseconds |
316+
| purefa_volume_performance_throughput_iops | FlashArray volume throughput in iops |
317+
| purefa_volume_space_bytes | FlashArray volume space in bytes |
318+
| purefa_volume_space_data_reduction_ratio | FlashArray volume space data reduction |
317319

318320

319321
## Integrating with Observability Platforms

‎internal/openmetrics-exporter/pod_replica_links_lag_collector.go‎

Lines changed: 36 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,17 @@
11
package collectors
22

3-
43
import (
4+
client "purestorage/fa-openmetrics-exporter/internal/rest-client"
5+
56
"github.com/prometheus/client_golang/prometheus"
6-
"purestorage/fa-openmetrics-exporter/internal/rest-client"
77
)
88

99
type PodReplicaLinksLagCollector struct {
10-
AvgLagDesc *prometheus.Desc
11-
MaxLagDesc *prometheus.Desc
10+
AvgLagDesc *prometheus.Desc
11+
MaxLagDesc *prometheus.Desc
12+
// AvgLagSecDesc & MaxLagSecDesc can be removed after 1.0.19
13+
AvgLagSecDesc *prometheus.Desc
14+
MaxLagSecDesc *prometheus.Desc
1215
Client *client.FAClient
1316
}
1417

@@ -34,20 +37,46 @@ func (c *PodReplicaLinksLagCollector) Collect(ch chan<- prometheus.Metric) {
3437
p.Lag.Max,
3538
p.Remotes[0].Name, p.LocalPod.Name, p.RemotePod.Name, p.Direction, p.Status,
3639
)
40+
// AvgLagSecDesc & MaxLagSecDesc can be removed after 1.0.19
41+
ch <- prometheus.MustNewConstMetric(
42+
c.AvgLagSecDesc,
43+
prometheus.GaugeValue,
44+
p.Lag.Avg,
45+
p.Remotes[0].Name, p.LocalPod.Name, p.RemotePod.Name, p.Direction, p.Status,
46+
)
47+
ch <- prometheus.MustNewConstMetric(
48+
c.MaxLagSecDesc,
49+
prometheus.GaugeValue,
50+
p.Lag.Max,
51+
p.Remotes[0].Name, p.LocalPod.Name, p.RemotePod.Name, p.Direction, p.Status,
52+
)
3753
}
3854
}
3955

4056
func NewPodReplicaLinksLagCollector(fa *client.FAClient) *PodReplicaLinksLagCollector {
4157
return &PodReplicaLinksLagCollector{
4258
AvgLagDesc: prometheus.NewDesc(
43-
"purefa_pod_replica_links_lag_average_sec",
44-
"FlashArray pod links average lag seconds",
59+
"purefa_pod_replica_links_lag_average_msec",
60+
"FlashArray pod links average lag in milliseconds",
4561
[]string{"remote", "local_pod", "remote_pod", "direction", "status"},
4662
prometheus.Labels{},
4763
),
4864
MaxLagDesc: prometheus.NewDesc(
65+
"purefa_pod_replica_links_lag_max_msec",
66+
"FlashArray pod links max lag in milliseconds",
67+
[]string{"remote", "local_pod", "remote_pod", "direction", "status"},
68+
prometheus.Labels{},
69+
),
70+
// AvgLagSecDesc & MaxLagSecDesc can be removed after 1.0.19
71+
AvgLagSecDesc: prometheus.NewDesc(
72+
"purefa_pod_replica_links_lag_average_sec",
73+
"FlashArray pod links average lag in milliseconds (deprecated, please use purefa_pod_replica_links_lag_average_msec)",
74+
[]string{"remote", "local_pod", "remote_pod", "direction", "status"},
75+
prometheus.Labels{},
76+
),
77+
MaxLagSecDesc: prometheus.NewDesc(
4978
"purefa_pod_replica_links_lag_max_sec",
50-
"FlashArray pod links max lag seconds",
79+
"FlashArray pod links max lag in milliseconds (deprecated, please use purefa_pod_replica_links_lag_max_msec)",
5180
[]string{"remote", "local_pod", "remote_pod", "direction", "status"},
5281
prometheus.Labels{},
5382
),

0 commit comments

Comments
 (0)