Skip to content

Commit 7d7cd4c

Browse files
authored
Merge pull request #687 from PureStorage-OpenConnect/no_post_script
No post script
2 parents 55c5511 + bb8b05c commit 7d7cd4c

8 files changed

Lines changed: 10 additions & 68 deletions

File tree

README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -126,19 +126,19 @@ async-dr Deploys 2 clusters with Portworx, sets up and confi
126126
configures an async DR schedule with a loadbalancer in front of the setup.
127127
backup-restore Deploys a Kubernetes cluster, Minio S3 storage, Petclinic Application and
128128
Backup/Restore config
129-
elk Deploys an ELK stack of 3 master nodes, 3 data nodes and 2 coordinator nodes, as per
130-
https://docs.portworx.com/portworx-install-with-kubernetes/application-install-with-kubernetes/elastic-search-and-kibana/
131-
harbor Deploys a single K8s cluster with Portworx and Harbor (https://goharbor.io/)
129+
ceph Install and run Ceph on each cluster
130+
dude Deploys clusters with Portworx, sets up and configures a cluster pairing from
131+
odd to even clusters, configures an async DR schedule, installs PX-Backup on the
132+
last cluster
133+
eks-multicloud-target setup EKS cluster with PX as clusterpair migration target
134+
kubevirt Install kubevirt on a bare-metal cluster
132135
metro Deploys 2 K8s clusters in AWS with a stretched Portworx cluster. It configures
133136
Metro, a GUI and Petclinic, ready for a manual failover demo
134137
migration Deploys 2 clusters with Portworx, sets up and configures a cluster pairing, and
135138
deploys a set of apps and a migration template.
139+
ocp-kubevirt Two Cluster OCP Virtualization Demo with Backup & AsyncDR on a aws bare-metal
136140
px-backup A single Kubernetes cluster with Portworx and PX-Backup via Helm installed
137-
px-fio-example An example fio benchmark on a gp2 disk and a Portworx volume on a gp2 disk
138-
px-vs-storageos-fio-example An example fio benchmark on a gp2 disk, a Portworx volume on a gp2 disk, and a
139-
StorageOS volume on a gp2 disk
140141
px A single Kubernetes cluster with Portworx installed
141-
storageos A single Kubernetes cluster with StorageOS installed
142142
training Deploys training clusters
143143
```
144144

defaults.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ nodes: 3
66
k8s_version: 1.31.8
77
px_version: 3.3.1.1
88
stop_after: 6
9-
post_script: show-ip
109
quiet: false
1110
tags: "project=pxdeploy"
1211

px-deploy.go

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ type Config struct {
4949
K8s_Version string
5050
Px_Version string
5151
Stop_After string
52-
Post_Script string
5352
DryRun bool
5453
NoSync bool
5554
IgnoreVersion bool
@@ -720,16 +719,6 @@ func validate_config(config *Config) []string {
720719
errormsg = append(errormsg, "Script '"+s+"' is not valid Bash")
721720
}
722721
}
723-
if config.Post_Script != "" {
724-
if _, err := os.Stat("scripts/" + config.Post_Script); os.IsNotExist(err) {
725-
errormsg = append(errormsg, "Postscript '"+config.Post_Script+"' does not exist")
726-
}
727-
cmd := exec.Command("bash", "-n", "scripts/"+config.Post_Script)
728-
err := cmd.Run()
729-
if err != nil {
730-
errormsg = append(errormsg, "Postscript '"+config.Post_Script+"' is not valid Bash")
731-
}
732-
}
733722

734723
if config.Platform == "ocp4" {
735724
checkvar := []string{"ocp4_domain", "ocp4_pull_secret"}
@@ -1876,22 +1865,6 @@ func write_nodescripts(config Config) {
18761865
}
18771866
}
18781867

1879-
// add post_script if defined
1880-
if config.Post_Script != "" {
1881-
content, err := os.ReadFile("/px-deploy/.px-deploy/scripts/" + config.Post_Script)
1882-
if err == nil {
1883-
tf_post_script = append(tf_post_script, "(\n"...)
1884-
tf_post_script = append(tf_post_script, "echo \"Started $(date)\"\n"...)
1885-
tf_post_script = append(tf_post_script, "echo \""+config.Post_Script+"_start,$(date +%s)\" >>/var/log/px-deploy/script_tracking\n"...)
1886-
tf_post_script = append(tf_post_script, content...)
1887-
tf_post_script = append(tf_post_script, "\necho \"Finished $(date)\"\n"...)
1888-
tf_post_script = append(tf_post_script, "echo \""+config.Post_Script+"_stop,$(date +%s)\" >>/var/log/px-deploy/script_tracking\n"...)
1889-
tf_post_script = append(tf_post_script, "\n) >&/var/log/px-deploy/"+config.Post_Script+"\n"...)
1890-
}
1891-
} else {
1892-
tf_post_script = nil
1893-
}
1894-
18951868
// loop clusters (masters and nodes) to build tfvars and master/node scripts
18961869
for c := 1; c <= Clusters; c++ {
18971870
masternum := strconv.Itoa(c)

scripts/cat

Lines changed: 0 additions & 4 deletions
This file was deleted.

scripts/px-fio-example

Lines changed: 0 additions & 14 deletions
This file was deleted.

scripts/show-ip

Lines changed: 0 additions & 4 deletions
This file was deleted.

scripts/training-cluster

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,6 @@ done
1010

1111
# Provision MinIO
1212
kubectl apply -f /assets/minio/minio-deployment.yml
13+
14+
# Delete AWS keys
15+
rm -f /root/.aws/credentials

templates/px-fio-example.yml

Lines changed: 0 additions & 11 deletions
This file was deleted.

0 commit comments

Comments
 (0)